Changeset 12510 in webkit

Timestamp:

Jan 31, 2006 6:44:22 PM (18 years ago)

Author:

adele

Message:

LayoutTests:

• test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6862 Input's value doesn't get updated after typing in new text field

• fast/forms/input-changing-value-expected.txt: Added.
• fast/forms/input-changing-value.html: Added.

WebCore:

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6862
Input's value doesn't get updated after typing in new text field

Added test:
fast/forms/input-changing-value.html

Added an event listener for a DOMCharacterDataModifiedEvent on the inner div.
When we get the event, then we update the input element's value field.

There may be performance problems with this approach that we will have to
address before flipping the switch to use these new text fields.

• rendering/RenderTextField.cpp: (WebCore::InputMutationListener::handleEvent): calls subtreeHasChanged (WebCore::m_mutationListener): (WebCore::RenderTextField::~RenderTextField): remove the event listener. (WebCore::RenderTextField::setStyle): Remove unnecessary setStyle on text node. It should inherit style from the div already. (WebCore::RenderTextField::updateFromElement): add the event listener. (WebCore::RenderTextField::subtreeHasChanged): updates the input element's value.
• rendering/RenderTextField.h: (WebCore::InputMutationListener::InputMutationListener): Added. (WebCore::InputMutationListener::renderTextField): Added. (WebCore::InputMutationListener::setInputElement): Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/input-changing-value-expected.txt (added)
• LayoutTests/fast/forms/input-changing-value.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/RenderTextField.cpp (modified) (5 diffs)
• WebCore/rendering/RenderTextField.h (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2006-01-31  Adele Peterson  <adele@apple.com>
+
+        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6862
+        Input's value doesn't get updated after typing in new text field
+
+        * fast/forms/input-changing-value-expected.txt: Added.
+        * fast/forms/input-changing-value.html: Added.
+
 2006-01-31  Timothy Hatcher  <timothy@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2006-01-31  Adele Peterson  <adele@apple.com>
+
+        Reviewed by Darin.
+
+        http://bugzilla.opendarwin.org/show_bug.cgi?id=6862
+        Input's value doesn't get updated after typing in new text field
+
+        Added test:
+        fast/forms/input-changing-value.html
+
+        Added an event listener for a DOMCharacterDataModifiedEvent on the inner div.
+        When we get the event, then we update the input element's value field.
+
+        There may be performance problems with this approach that we will have to
+        address before flipping the switch to use these new text fields.
+
+        * rendering/RenderTextField.cpp:
+        (WebCore::InputMutationListener::handleEvent): calls subtreeHasChanged
+        (WebCore::m_mutationListener):
+        (WebCore::RenderTextField::~RenderTextField): remove the event listener.
+        (WebCore::RenderTextField::setStyle): Remove unnecessary setStyle on text node.  
+         It should inherit style from the div already.
+        (WebCore::RenderTextField::updateFromElement): add the event listener.
+        (WebCore::RenderTextField::subtreeHasChanged): updates the input element's value.
+        * rendering/RenderTextField.h:
+        (WebCore::InputMutationListener::InputMutationListener): Added.
+        (WebCore::InputMutationListener::renderTextField): Added.
+        (WebCore::InputMutationListener::setInputElement): Added.
+
 2006-01-31  Antti Koivisto <koivisto@iki.fi>
 

trunk/WebCore/rendering/RenderTextField.cpp

@@ -27 +27 @@
 #include "htmlnames.h"
 #include "HTMLInputElementImpl.h"
+#include "xml/dom_elementimpl.h"
+#include "xml/EventNames.h"
+#include "xml/dom2_eventsimpl.h"
 
 namespace WebCore {
 
 using namespace HTMLNames;
+using namespace EventNames;
+
+void InputMutationListener::handleEvent(EventImpl *event, bool isWindowEvent)
+{
+    if (!m_renderTextField)
+        return;
+    
+    if (event->type() == DOMCharacterDataModifiedEvent)
+        m_renderTextField->subtreeHasChanged();
+}
 
 RenderTextField::RenderTextField(NodeImpl* node)
-:RenderBlock(node)
+:RenderBlock(node), m_mutationListener(new InputMutationListener(this))
 {
 }
@@ -40 +53 @@
 {
     // The renderer for the div has already been destroyed by destroyLeftoverChildren
-    if (m_div)
+    if (m_div) {
+        m_div->removeEventListener(DOMCharacterDataModifiedEvent, m_mutationListener.get(), false);
         m_div->detach();
+    }
 }
 
@@ -50 +65 @@
         RenderBlock* divRenderer = static_cast<RenderBlock*>(m_div->renderer());
         RenderStyle* divStyle = createDivStyle(style);
-        if (divRenderer->firstChild())
-            divRenderer->firstChild()->setStyle(divStyle);
         divRenderer->setStyle(divStyle);
     }
@@ -103 +116 @@
             int exception = 0;
             m_div->appendChild(text, exception);
+            m_div->addEventListener(DOMCharacterDataModifiedEvent, m_mutationListener.get(), false);
         }
         
@@ -153 +167 @@
 }
 
+void RenderTextField::subtreeHasChanged()
+{
+    HTMLInputElementImpl* input = static_cast<HTMLInputElementImpl*>(element());
+    if (input && m_div)
+        input->setValueFromRenderer(m_div->textContent());
 }
+
+}

trunk/WebCore/rendering/RenderTextField.h

@@ -21 +21 @@
 #define RenderTextField_H
 
+#include "dom2_events.h"
 #include "render_flexbox.h"
 #include "html_blockimpl.h"
@@ -26 +27 @@
 namespace WebCore
 {
+
+class RenderTextField;
+
+class InputMutationListener : public EventListener
+{
+public:
+    InputMutationListener() { m_renderTextField = 0; }
+    InputMutationListener(RenderTextField *r) { m_renderTextField = r; }
+    RenderTextField *renderTextField() const { return m_renderTextField; }
+    void setInputElement(RenderTextField *r) { m_renderTextField = r; }
+    
+    virtual void handleEvent(EventListenerEvent evt, bool isWindowEvent);
+    
+private:
+    RenderTextField *m_renderTextField;
+};
 
 class RenderTextField : public RenderBlock
@@ -47 +64 @@
     void setSelectionRange(int, int);
 
+    void subtreeHasChanged();
+
 protected:
     RefPtr<HTMLDivElementImpl> m_div;
+    RefPtr<InputMutationListener> m_mutationListener;
 };