Changeset 125280 in webkit
- Timestamp:
- Aug 10, 2012 8:20:41 AM (12 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 6 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r125277 r125280 1 2012-08-10 Jon Lee <jonlee@apple.com> 2 3 Change Notification.permissionLevel() to Notification.permission 4 https://bugs.webkit.org/show_bug.cgi?id=88919 5 <rdar://problem/11650319> 6 7 Reviewed by Kentaro Hara. 8 9 * fast/notifications/notifications-permission-expected.txt: Added. 10 * fast/notifications/notifications-permission.html: Added. 11 * platform/chromium/TestExpectations: V8 does not properly support IDL static 12 attributes. This is tracked in bug 93488. 13 1 14 2012-08-10 Andrey Kosyakov <caseq@chromium.org> 2 15 -
trunk/LayoutTests/platform/chromium/TestExpectations
r125264 r125280 3472 3472 // Should only need rebaselining after bug 93558, if both squares are fully green. 3473 3473 BUGWK93558 : compositing/masks/layer-mask-placement.html = IMAGE 3474 3475 // V8 does not support static attributes 3476 BUGWK93488 SKIP : fast/notifications/notifications-permission.html = TEXT 3477 -
trunk/Source/WebCore/ChangeLog
r125279 r125280 1 2012-08-10 Jon Lee <jonlee@apple.com> 2 3 Change Notification.permissionLevel() to Notification.permission 4 https://bugs.webkit.org/show_bug.cgi?id=88919 5 <rdar://problem/11650319> 6 7 Reviewed by Kentaro Hara. 8 9 Retrieving the permission level has changed to Notification.permission, per this discussion: 10 http://lists.w3.org/Archives/Public/public-web-notification/2012Jun/0000.html 11 12 Test: fast/notifications/notifications-permission.html 13 14 * Modules/notifications/Notification.cpp: Rename to match attribute name. 15 (WebCore::Notification::permission): 16 * Modules/notifications/Notification.h: Rename to match attribute name. 17 (Notification): 18 * Modules/notifications/Notification.idl: Change to static readonly attribute. 19 1 20 2012-08-10 Kentaro Hara <haraken@chromium.org> 2 21 -
trunk/Source/WebCore/Modules/notifications/Notification.cpp
r121882 r125280 255 255 256 256 #if ENABLE(NOTIFICATIONS) 257 const String& Notification::permission Level(ScriptExecutionContext* context)257 const String& Notification::permission(ScriptExecutionContext* context) 258 258 { 259 259 ASSERT(context->isDocument()); -
trunk/Source/WebCore/Modules/notifications/Notification.h
r121882 r125280 139 139 140 140 #if ENABLE(NOTIFICATIONS) 141 static const String& permission Level(ScriptExecutionContext*);141 static const String& permission(ScriptExecutionContext*); 142 142 static const String& permissionString(NotificationClient::Permission); 143 143 static void requestPermission(ScriptExecutionContext*, PassRefPtr<NotificationPermissionCallback>); -
trunk/Source/WebCore/Modules/notifications/Notification.idl
r121882 r125280 53 53 54 54 #if defined(ENABLE_NOTIFICATIONS) && ENABLE_NOTIFICATIONS 55 [CallWith=ScriptExecutionContext] static DOMString permissionLevel();55 static readonly attribute [CallWith=ScriptExecutionContext] DOMString permission; 56 56 [Custom] static void requestPermission(in NotificationPermissionCallback callback); 57 57 #endif
Note: See TracChangeset
for help on using the changeset viewer.