Changeset 125280 in webkit


Ignore:
Timestamp:
Aug 10, 2012 8:20:41 AM (12 years ago)
Author:
jonlee@apple.com
Message:

Change Notification.permissionLevel() to Notification.permission
https://bugs.webkit.org/show_bug.cgi?id=88919
<rdar://problem/11650319>

Reviewed by Kentaro Hara.

Source/WebCore:

Retrieving the permission level has changed to Notification.permission, per this discussion:
http://lists.w3.org/Archives/Public/public-web-notification/2012Jun/0000.html

Test: fast/notifications/notifications-permission.html

  • Modules/notifications/Notification.cpp: Rename to match attribute name.

(WebCore::Notification::permission):

  • Modules/notifications/Notification.h: Rename to match attribute name.

(Notification):

  • Modules/notifications/Notification.idl: Change to static readonly attribute.

LayoutTests:

  • fast/notifications/notifications-permission-expected.txt: Added.
  • fast/notifications/notifications-permission.html: Added.
  • platform/chromium/TestExpectations: V8 does not properly support IDL static

attributes. This is tracked in bug 93488.

Location:
trunk
Files:
2 added
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r125277 r125280  
     12012-08-10  Jon Lee  <jonlee@apple.com>
     2
     3        Change Notification.permissionLevel() to Notification.permission
     4        https://bugs.webkit.org/show_bug.cgi?id=88919
     5        <rdar://problem/11650319>
     6
     7        Reviewed by Kentaro Hara.
     8
     9        * fast/notifications/notifications-permission-expected.txt: Added.
     10        * fast/notifications/notifications-permission.html: Added.
     11        * platform/chromium/TestExpectations: V8 does not properly support IDL static
     12        attributes. This is tracked in bug 93488.
     13
    1142012-08-10  Andrey Kosyakov  <caseq@chromium.org>
    215
  • trunk/LayoutTests/platform/chromium/TestExpectations

    r125264 r125280  
    34723472// Should only need rebaselining after bug 93558, if both squares are fully green.
    34733473BUGWK93558 : compositing/masks/layer-mask-placement.html = IMAGE
     3474
     3475// V8 does not support static attributes
     3476BUGWK93488 SKIP : fast/notifications/notifications-permission.html = TEXT
     3477
  • trunk/Source/WebCore/ChangeLog

    r125279 r125280  
     12012-08-10  Jon Lee  <jonlee@apple.com>
     2
     3        Change Notification.permissionLevel() to Notification.permission
     4        https://bugs.webkit.org/show_bug.cgi?id=88919
     5        <rdar://problem/11650319>
     6
     7        Reviewed by Kentaro Hara.
     8
     9        Retrieving the permission level has changed to Notification.permission, per this discussion:
     10        http://lists.w3.org/Archives/Public/public-web-notification/2012Jun/0000.html
     11
     12        Test: fast/notifications/notifications-permission.html
     13
     14        * Modules/notifications/Notification.cpp: Rename to match attribute name.
     15        (WebCore::Notification::permission):
     16        * Modules/notifications/Notification.h: Rename to match attribute name.
     17        (Notification):
     18        * Modules/notifications/Notification.idl: Change to static readonly attribute.
     19
    1202012-08-10  Kentaro Hara  <haraken@chromium.org>
    221
  • trunk/Source/WebCore/Modules/notifications/Notification.cpp

    r121882 r125280  
    255255
    256256#if ENABLE(NOTIFICATIONS)
    257 const String& Notification::permissionLevel(ScriptExecutionContext* context)
     257const String& Notification::permission(ScriptExecutionContext* context)
    258258{
    259259    ASSERT(context->isDocument());
  • trunk/Source/WebCore/Modules/notifications/Notification.h

    r121882 r125280  
    139139
    140140#if ENABLE(NOTIFICATIONS)
    141     static const String& permissionLevel(ScriptExecutionContext*);
     141    static const String& permission(ScriptExecutionContext*);
    142142    static const String& permissionString(NotificationClient::Permission);
    143143    static void requestPermission(ScriptExecutionContext*, PassRefPtr<NotificationPermissionCallback>);
  • trunk/Source/WebCore/Modules/notifications/Notification.idl

    r121882 r125280  
    5353
    5454#if defined(ENABLE_NOTIFICATIONS) && ENABLE_NOTIFICATIONS
    55         [CallWith=ScriptExecutionContext] static DOMString permissionLevel();
     55        static readonly attribute [CallWith=ScriptExecutionContext] DOMString permission;
    5656        [Custom] static void requestPermission(in NotificationPermissionCallback callback);
    5757#endif
Note: See TracChangeset for help on using the changeset viewer.