Changeset 125394 in webkit


Ignore:
Timestamp:
Aug 13, 2012 12:19:14 AM (12 years ago)
Author:
commit-queue@webkit.org
Message:

REGRESSION (r124723-r124741): 5 inspector/debugger tests failing on Apple Lion Debug WK1 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=93387

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-08-13
Reviewed by Pavel Feldman.

Now the front-end has problem when setting the positon of breakpoint, so remove the comparing
of "column" to make the behavior back to the time as JSC cannot provide "column" info.
Refer to https://bugs.webkit.org/show_bug.cgi?id=93473.

No new test case for this bug.

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::hasBreakpoint):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r125391 r125394  
     12012-08-13  Peter Wang  <peter.wang@torchmobile.com.cn>
     2
     3        REGRESSION (r124723-r124741): 5 inspector/debugger tests failing on Apple Lion Debug WK1 (Tests)
     4        https://bugs.webkit.org/show_bug.cgi?id=93387
     5
     6        Reviewed by Pavel Feldman.
     7
     8        Now the front-end has problem when setting the positon of breakpoint, so remove the comparing
     9        of "column" to make the behavior back to the time as JSC cannot provide "column" info.
     10        Refer to https://bugs.webkit.org/show_bug.cgi?id=93473. 
     11
     12        No new test case for this bug.
     13
     14        * bindings/js/ScriptDebugServer.cpp:
     15        (WebCore::ScriptDebugServer::hasBreakpoint):
     16
    1172012-08-10  Kinuko Yasuda  <kinuko@chromium.org>
    218
  • trunk/Source/WebCore/bindings/js/ScriptDebugServer.cpp

    r124729 r125394  
    188188    unsigned i;
    189189    for (i = 0; i < breaksCount; i++) {
    190         int breakColumn = breaksVector.at(i).columnNumber;
    191190        int breakLine = breaksVector.at(i).lineNumber;
    192         if (lineNumber == breakLine && columnNumber == breakColumn) {
     191        if (lineNumber == breakLine) {
    193192            hit = true;
    194193            break;
Note: See TracChangeset for help on using the changeset viewer.