Changeset 125615 in webkit
- Timestamp:
- Aug 14, 2012 3:34:01 PM (12 years ago)
- Location:
- trunk/Source
- Files:
-
- 64 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r125614 r125615 1 2012-08-14 Adam Barth <abarth@webkit.org> 2 3 Delete Frame::domWindow() and Frame::existingDOMWindow() 4 https://bugs.webkit.org/show_bug.cgi?id=93990 5 6 Reviewed by Eric Seidel. 7 8 These functions just call through to document()->domWindow(). This 9 patch updates the callers so it's clearer what's going on. 10 11 * bindings/js/JSDOMBinding.cpp: 12 (WebCore::shouldAllowAccessToFrame): 13 (WebCore::printErrorMessageForFrame): 14 * bindings/js/JSDocumentCustom.cpp: 15 (WebCore::JSDocument::location): 16 (WebCore::JSDocument::setLocation): 17 * bindings/js/JSEventListener.cpp: 18 (WebCore::JSEventListener::handleEvent): 19 * bindings/js/ScriptCachedFrameData.cpp: 20 (WebCore::ScriptCachedFrameData::restore): 21 * bindings/js/ScriptController.cpp: 22 (WebCore::ScriptController::createWindowShell): 23 * bindings/objc/DOMAbstractView.mm: 24 (core): 25 * bindings/v8/NPV8Object.cpp: 26 (WebCore::toV8Context): 27 * bindings/v8/ScriptController.cpp: 28 (WebCore::createScriptObject): 29 (WebCore::ScriptController::createScriptObjectForPluginElement): 30 * bindings/v8/V8DOMWindowShell.cpp: 31 (WebCore::V8DOMWindowShell::initContextIfNeeded): 32 * bindings/v8/V8IsolatedContext.cpp: 33 (WebCore::V8IsolatedContext::V8IsolatedContext): 34 * bindings/v8/V8Proxy.cpp: 35 (WebCore::V8Proxy::retrieveFrame): 36 * bindings/v8/custom/V8DOMWindowCustom.cpp: 37 (WebCore::V8DOMWindow::indexedPropertyGetter): 38 (WebCore::V8DOMWindow::namedPropertyGetter): 39 * bindings/v8/custom/V8DocumentLocationCustom.cpp: 40 (WebCore::V8Document::locationAccessorGetter): 41 (WebCore::V8Document::locationAccessorSetter): 42 * bindings/v8/custom/V8HTMLDocumentCustom.cpp: 43 (WebCore::V8HTMLDocument::GetNamedProperty): 44 * bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp: 45 (WebCore::V8HTMLFrameSetElement::namedPropertyGetter): 46 * dom/Document.cpp: 47 (WebCore::printNavigationErrorMessage): 48 * dom/ViewportArguments.cpp: 49 (WebCore::reportViewportWarning): 50 * editing/AlternativeTextController.cpp: 51 (WebCore::AlternativeTextController::insertDictatedText): 52 * editing/Editor.cpp: 53 (WebCore::Editor::pasteAsPlainText): 54 (WebCore::Editor::pasteAsFragment): 55 (WebCore::Editor::setComposition): 56 * history/PageCache.cpp: 57 (WebCore::logCanCacheFrameDecision): 58 (WebCore::PageCache::canCachePageContainingThisFrame): 59 * html/HTMLFormElement.cpp: 60 (WebCore::HTMLFormElement::validateInteractively): 61 * html/HTMLFrameOwnerElement.cpp: 62 (WebCore::HTMLFrameOwnerElement::contentWindow): 63 * html/canvas/WebGLRenderingContext.cpp: 64 (WebCore): 65 (WebCore::WebGLRenderingContext::printWarningToConsole): 66 * inspector/InspectorDOMStorageAgent.cpp: 67 (WebCore::InspectorDOMStorageAgent::storageId): 68 * loader/DocumentLoader.cpp: 69 (WebCore::DocumentLoader::checkLoadComplete): 70 * loader/DocumentWriter.cpp: 71 (WebCore::DocumentWriter::begin): 72 * loader/FrameLoader.cpp: 73 (WebCore::FrameLoader::stopLoading): 74 (WebCore::FrameLoader::didOpenURL): 75 (WebCore::FrameLoader::checkIfDisplayInsecureContent): 76 (WebCore::FrameLoader::checkIfRunInsecureContent): 77 (WebCore::FrameLoader::reportLocalLoadFailed): 78 (WebCore::FrameLoader::prepareForCachedPageRestore): 79 (WebCore::FrameLoader::open): 80 (WebCore::FrameLoader::fireBeforeUnloadEvent): 81 * loader/MainResourceLoader.cpp: 82 (WebCore::MainResourceLoader::didReceiveResponse): 83 * loader/appcache/ApplicationCacheGroup.cpp: 84 (WebCore::ApplicationCacheGroup::abort): 85 (WebCore::ApplicationCacheGroup::didReceiveResponse): 86 (WebCore::ApplicationCacheGroup::didFinishLoading): 87 (WebCore::ApplicationCacheGroup::didFail): 88 (WebCore::ApplicationCacheGroup::didReceiveManifestResponse): 89 (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): 90 (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): 91 * loader/cache/CachedResourceLoader.cpp: 92 (WebCore::CachedResourceLoader::printAccessDeniedMessage): 93 * page/DOMWindow.cpp: 94 (WebCore::DOMWindow::isCurrentlyDisplayedInFrame): 95 (WebCore::DOMWindow::self): 96 (WebCore::DOMWindow::opener): 97 (WebCore::DOMWindow::parent): 98 (WebCore::DOMWindow::top): 99 (WebCore::DOMWindow::createWindow): 100 (WebCore::DOMWindow::open): 101 * page/DOMWindowProperty.cpp: 102 (WebCore::DOMWindowProperty::DOMWindowProperty): 103 (WebCore::DOMWindowProperty::reconnectFrameFromPageCache): 104 * page/DragController.cpp: 105 (WebCore::DragController::dispatchTextInputEventFor): 106 * page/EventHandler.cpp: 107 (WebCore::EventHandler::handleTextInputEvent): 108 * page/Frame.cpp: 109 * page/Frame.h: 110 (Frame): 111 * page/Location.cpp: 112 (WebCore::Location::replace): 113 (WebCore::Location::reload): 114 (WebCore::Location::setLocation): 115 * storage/StorageEventDispatcher.cpp: 116 (WebCore::StorageEventDispatcher::dispatch): 117 * svg/SVGDocumentExtensions.cpp: 118 (WebCore::reportMessage): 119 * xml/XSLStyleSheetLibxslt.cpp: 120 (WebCore::XSLStyleSheet::parseString): 121 * xml/XSLTProcessorLibxslt.cpp: 122 (WebCore::docLoaderFunc): 123 * xml/XSLTProcessorQt.cpp: 124 (WebCore::XSLTMessageHandler::handleMessage): 125 1 126 2012-08-14 Mike West <mkwst@chromium.org> 2 127 -
trunk/Source/WebCore/WebCore.exp.in
r125612 r125615 1298 1298 __ZNK7WebCore5Frame31displayStringModifiedByEncodingERKN3WTF6StringE 1299 1299 __ZNK7WebCore5Frame8settingsEv 1300 __ZNK7WebCore5Frame9domWindowEv1301 1300 __ZNK7WebCore5Range11startOffsetERi 1302 1301 __ZNK7WebCore5Range12endContainerERi -
trunk/Source/WebCore/bindings/js/JSDOMBinding.cpp
r125484 r125615 225 225 bool result = BindingSecurity::shouldAllowAccessToFrame(exec, frame, DoNotReportSecurityError); 226 226 // FIXME: The following line of code should move somewhere that it can be shared with immediatelyReportUnsafeAccessTo. 227 message = frame->do mWindow()->crossDomainAccessErrorMessage(activeDOMWindow(exec));227 message = frame->document()->domWindow()->crossDomainAccessErrorMessage(activeDOMWindow(exec)); 228 228 return result; 229 229 } … … 233 233 if (!frame) 234 234 return; 235 frame->do mWindow()->printErrorMessage(message);235 frame->document()->domWindow()->printErrorMessage(message); 236 236 } 237 237 -
trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp
r125152 r125615 100 100 static JSValue childFrameGetter(ExecState* exec, JSValue slotBase, PropertyName propertyName) 101 101 { 102 return toJS(exec, jsCast<JSDOMWindow*>(asObject(slotBase))->impl()->frame()->tree()->scopedChild(propertyNameToAtomicString(propertyName))->do mWindow());102 return toJS(exec, jsCast<JSDOMWindow*>(asObject(slotBase))->impl()->frame()->tree()->scopedChild(propertyNameToAtomicString(propertyName))->document()->domWindow()); 103 103 } 104 104 105 105 static JSValue indexGetter(ExecState* exec, JSValue slotBase, unsigned index) 106 106 { 107 return toJS(exec, jsCast<JSDOMWindow*>(asObject(slotBase))->impl()->frame()->tree()->scopedChild(index)->do mWindow());107 return toJS(exec, jsCast<JSDOMWindow*>(asObject(slotBase))->impl()->frame()->tree()->scopedChild(index)->document()->domWindow()); 108 108 } 109 109 -
trunk/Source/WebCore/bindings/js/JSDocumentCustom.cpp
r114098 r125615 55 55 return jsNull(); 56 56 57 Location* location = frame->do mWindow()->location();57 Location* location = frame->document()->domWindow()->location(); 58 58 if (JSDOMWrapper* wrapper = getCachedWrapper(currentWorld(exec), location)) 59 59 return wrapper; … … 74 74 return; 75 75 76 if (Location* location = frame->do mWindow()->location())76 if (Location* location = frame->document()->domWindow()->location()) 77 77 location->setHref(ustringToString(locationString), activeDOMWindow(exec), firstDOMWindow(exec)); 78 78 } -
trunk/Source/WebCore/bindings/js/JSEventListener.cpp
r121381 r125615 86 86 return; 87 87 88 Frame* frame = 0;89 88 if (scriptExecutionContext->isDocument()) { 90 89 JSDOMWindow* window = jsCast<JSDOMWindow*>(globalObject); 91 frame = window->impl()->frame(); 92 if (!frame) 93 return; 94 // The window must still be active in its frame. See <https://bugs.webkit.org/show_bug.cgi?id=21921>. 95 // FIXME: A better fix for this may be to change DOMWindow::frame() to not return a frame the detached window used to be in. 96 if (frame->domWindow() != window->impl()) 90 if (!window->impl()->isCurrentlyDisplayedInFrame()) 97 91 return; 98 92 // FIXME: Is this check needed for other contexts? 99 ScriptController* script = frame->script();93 ScriptController* script = window->impl()->frame()->script(); 100 94 if (!script->canExecuteScripts(AboutToExecuteScript) || script->isPaused()) 101 95 return; -
trunk/Source/WebCore/bindings/js/ScriptCachedFrameData.cpp
r121381 r125615 81 81 windowShell->setWindow(window->globalData(), window); 82 82 else { 83 windowShell->setWindow(frame->do mWindow());83 windowShell->setWindow(frame->document()->domWindow()); 84 84 85 85 if (Page* page = frame->page()) { -
trunk/Source/WebCore/bindings/js/ScriptController.cpp
r125592 r125615 112 112 ASSERT(!m_windowShells.contains(world)); 113 113 Structure* structure = JSDOMWindowShell::createStructure(*world->globalData(), jsNull()); 114 Strong<JSDOMWindowShell> windowShell(*world->globalData(), JSDOMWindowShell::create(m_frame->do mWindow(), structure, world));114 Strong<JSDOMWindowShell> windowShell(*world->globalData(), JSDOMWindowShell::create(m_frame->document()->domWindow(), structure, world)); 115 115 Strong<JSDOMWindowShell> windowShell2(windowShell); 116 116 m_windowShells.add(world, windowShell); -
trunk/Source/WebCore/bindings/objc/DOMAbstractView.mm
r95901 r125615 51 51 if (!_internal) 52 52 return nil; 53 return kit(IMPL->do mWindow()->document());53 return kit(IMPL->document()); 54 54 } 55 55 … … 73 73 if (!wrapper->_internal) 74 74 return 0; 75 return reinterpret_cast<WebCore::Frame*>(wrapper->_internal)->do mWindow();75 return reinterpret_cast<WebCore::Frame*>(wrapper->_internal)->document()->domWindow(); 76 76 } 77 77 -
trunk/Source/WebCore/bindings/v8/NPV8Object.cpp
r125495 r125615 64 64 { 65 65 V8NPObject* object = reinterpret_cast<V8NPObject*>(npObject); 66 DOMWindow* domWindow = object->rootObject;67 if (! domWindow || !domWindow->frame() || domWindow != domWindow->frame()->domWindow())66 DOMWindow* window = object->rootObject; 67 if (!window || !window->isCurrentlyDisplayedInFrame()) 68 68 return v8::Local<v8::Context>(); 69 69 return V8Proxy::mainWorldContext(object->rootObject->frame()); -
trunk/Source/WebCore/bindings/v8/ScriptController.cpp
r125592 r125615 429 429 430 430 v8::Context::Scope scope(v8Context); 431 DOMWindow* window = frame->do mWindow();431 DOMWindow* window = frame->document()->domWindow(); 432 432 v8::Handle<v8::Value> global = toV8(window); 433 433 ASSERT(global->IsObject()); … … 469 469 v8::Context::Scope scope(v8Context); 470 470 471 DOMWindow* window = m_frame->do mWindow();471 DOMWindow* window = m_frame->document()->domWindow(); 472 472 v8::Handle<v8::Value> v8plugin = toV8(static_cast<HTMLEmbedElement*>(plugin)); 473 473 if (!v8plugin->IsObject()) -
trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp
r125482 r125615 335 335 } 336 336 337 if (!installDOMWindow(v8Context, m_frame->do mWindow())) {337 if (!installDOMWindow(v8Context, m_frame->document()->domWindow())) { 338 338 disposeContextHandles(); 339 339 return false; -
trunk/Source/WebCore/bindings/v8/V8IsolatedContext.cpp
r125242 r125615 92 92 93 93 // FIXME: This will go away once we have a windowShell for the isolated world. 94 proxy->windowShell()->installDOMWindow(m_context->get(), m_frame->do mWindow());94 proxy->windowShell()->installDOMWindow(m_context->get(), m_frame->document()->domWindow()); 95 95 96 96 // Using the default security token means that the canAccess is always -
trunk/Source/WebCore/bindings/v8/V8Proxy.cpp
r125495 r125615 368 368 { 369 369 DOMWindow* window = retrieveWindow(context); 370 Frame* frame = window->frame(); 371 if (frame && frame->domWindow() == window) 372 return frame; 370 if (window->isCurrentlyDisplayedInFrame()) 371 return window->frame(); 373 372 // We return 0 here because |context| is detached from the Frame. If we 374 373 // did return |frame| we could get in trouble because the frame could be -
trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp
r125495 r125615 480 480 Frame* child = frame->tree()->scopedChild(index); 481 481 if (child) 482 return toV8(child->do mWindow(), info.GetIsolate());482 return toV8(child->document()->domWindow(), info.GetIsolate()); 483 483 484 484 return v8Undefined(); … … 503 503 Frame* child = frame->tree()->scopedChild(propName); 504 504 if (child) 505 return toV8(child->do mWindow(), info.GetIsolate());505 return toV8(child->document()->domWindow(), info.GetIsolate()); 506 506 507 507 // Search IDL functions defined in the prototype -
trunk/Source/WebCore/bindings/v8/custom/V8DocumentLocationCustom.cpp
r124835 r125615 41 41 return v8::Null(info.GetIsolate()); 42 42 43 DOMWindow* window = document-> frame()->domWindow();43 DOMWindow* window = document->domWindow(); 44 44 return toV8(window->location(), info.GetIsolate()); 45 45 } … … 61 61 return; 62 62 63 DOMWindow* window = document-> frame()->domWindow();63 DOMWindow* window = document->domWindow(); 64 64 if (Location* location = window->location()) 65 65 location->setHref(toWebCoreString(value), active, first); -
trunk/Source/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp
r125495 r125615 95 95 Frame* frame = 0; 96 96 if (node->hasTagName(HTMLNames::iframeTag) && (frame = static_cast<HTMLIFrameElement*>(node)->contentFrame())) 97 return toV8(frame->do mWindow(), isolate);97 return toV8(frame->document()->domWindow(), isolate); 98 98 99 99 return toV8(node, isolate); -
trunk/Source/WebCore/bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp
r125482 r125615 51 51 HTMLFrameSetElement* imp = V8HTMLFrameSetElement::toNative(info.Holder()); 52 52 Node* frameNode = imp->children()->namedItem(toWebCoreAtomicString(name)); 53 if (frameNode && frameNode->hasTagName(HTMLNames::frameTag)) { 54 Document* doc = static_cast<HTMLFrameElement*>(frameNode)->contentDocument(); 55 if (!doc) 56 return v8::Undefined(); 57 if (Frame* frame = doc->frame()) 58 return toV8(frame->domWindow(), info.GetIsolate()); 59 } 60 return v8Undefined(); 53 if (!frameNode) 54 return v8Undefined(); 55 if (!frameNode->hasTagName(HTMLNames::frameTag)) 56 return v8Undefined(); 57 Document* document = static_cast<HTMLFrameElement*>(frameNode)->contentDocument(); 58 if (!document) 59 return v8Undefined(); 60 if (!document->frame()) 61 return v8Undefined(); 62 return toV8(document->domWindow(), info.GetIsolate()); 61 63 } 62 64 -
trunk/Source/WebCore/dom/Document.cpp
r125592 r125615 386 386 387 387 // FIXME: should we print to the console of the document performing the navigation instead? 388 frame->do mWindow()->printErrorMessage(message);388 frame->document()->domWindow()->printErrorMessage(message); 389 389 } 390 390 -
trunk/Source/WebCore/dom/ViewportArguments.cpp
r121661 r125615 364 364 message.replace("%replacement2", replacement2); 365 365 366 frame->domWindow()->console()->addMessage(HTMLMessageSource, LogMessageType, viewportErrorMessageLevel(errorCode), message, document->url().string(), parserLineNumber(document));366 document->domWindow()->console()->addMessage(HTMLMessageSource, LogMessageType, viewportErrorMessageLevel(errorCode), message, document->url().string(), parserLineNumber(document)); 367 367 } 368 368 -
trunk/Source/WebCore/editing/AlternativeTextController.cpp
r121299 r125615 705 705 view->resetDeferredRepaintDelay(); 706 706 707 RefPtr<TextEvent> event = TextEvent::createForDictation(m_frame->do mWindow(), text, dictationAlternatives);707 RefPtr<TextEvent> event = TextEvent::createForDictation(m_frame->document()->domWindow(), text, dictationAlternatives); 708 708 event->setUnderlyingEvent(triggeringEvent); 709 709 -
trunk/Source/WebCore/editing/Editor.cpp
r125247 r125615 347 347 return; 348 348 ExceptionCode ec = 0; 349 target->dispatchEvent(TextEvent::createForPlainTextPaste(m_frame->do mWindow(), pastingText, smartReplace), ec);349 target->dispatchEvent(TextEvent::createForPlainTextPaste(m_frame->document()->domWindow(), pastingText, smartReplace), ec); 350 350 } 351 351 … … 356 356 return; 357 357 ExceptionCode ec = 0; 358 target->dispatchEvent(TextEvent::createForFragmentPaste(m_frame->do mWindow(), pastingFragment, smartReplace, matchStyle), ec);358 target->dispatchEvent(TextEvent::createForFragmentPaste(m_frame->document()->domWindow(), pastingFragment, smartReplace, matchStyle), ec); 359 359 } 360 360 … … 1364 1364 Node* target = m_frame->document()->focusedNode(); 1365 1365 if (target) { 1366 RefPtr<CompositionEvent> event = CompositionEvent::create(eventNames().compositionendEvent, m_frame->do mWindow(), text);1366 RefPtr<CompositionEvent> event = CompositionEvent::create(eventNames().compositionendEvent, m_frame->document()->domWindow(), text); 1367 1367 ExceptionCode ec = 0; 1368 1368 target->dispatchEvent(event, ec); … … 1427 1427 // function doesn't create a composition node when the text is empty. 1428 1428 if (!text.isEmpty()) { 1429 target->dispatchEvent(CompositionEvent::create(eventNames().compositionstartEvent, m_frame->do mWindow(), text));1430 event = CompositionEvent::create(eventNames().compositionupdateEvent, m_frame->do mWindow(), text);1429 target->dispatchEvent(CompositionEvent::create(eventNames().compositionstartEvent, m_frame->document()->domWindow(), text)); 1430 event = CompositionEvent::create(eventNames().compositionupdateEvent, m_frame->document()->domWindow(), text); 1431 1431 } 1432 1432 } else { 1433 1433 if (!text.isEmpty()) 1434 event = CompositionEvent::create(eventNames().compositionupdateEvent, m_frame->do mWindow(), text);1434 event = CompositionEvent::create(eventNames().compositionupdateEvent, m_frame->document()->domWindow(), text); 1435 1435 else 1436 event = CompositionEvent::create(eventNames().compositionendEvent, m_frame->do mWindow(), text);1436 event = CompositionEvent::create(eventNames().compositionendEvent, m_frame->document()->domWindow(), text); 1437 1437 } 1438 1438 ExceptionCode ec = 0; -
trunk/Source/WebCore/history/PageCache.cpp
r117112 r125615 138 138 rejectReasons |= 1 << IsHttpsAndCacheControlled; 139 139 } 140 if (frame->do mWindow() && frame->domWindow()->hasEventListeners(eventNames().unloadEvent)) {140 if (frame->document()->domWindow() && frame->document()->domWindow()->hasEventListeners(eventNames().unloadEvent)) { 141 141 PCLOG(" -Frame has an unload event listener"); 142 142 rejectReasons |= 1 << HasUnloadListener; … … 344 344 && (!frameLoader->subframeLoader()->containsPlugins() || frame->page()->settings()->pageCacheSupportsPlugins()) 345 345 && (!document->url().protocolIs("https") || (!documentLoader->response().cacheControlContainsNoCache() && !documentLoader->response().cacheControlContainsNoStore())) 346 && (! frame->domWindow() || !frame->domWindow()->hasEventListeners(eventNames().unloadEvent))346 && (!document->domWindow() || !document->domWindow()->hasEventListeners(eventNames().unloadEvent)) 347 347 #if ENABLE(SQL_DATABASE) 348 348 && !DatabaseContext::hasOpenDatabases(document) -
trunk/Source/WebCore/html/HTMLFormElement.cpp
r122584 r125615 253 253 } 254 254 // Warn about all of unfocusable controls. 255 if ( Frame* frame =document()->frame()) {255 if (document()->frame()) { 256 256 for (unsigned i = 0; i < unhandledInvalidControls.size(); ++i) { 257 257 FormAssociatedElement* unhandledAssociatedElement = unhandledInvalidControls[i].get(); … … 261 261 String message("An invalid form control with name='%name' is not focusable."); 262 262 message.replace("%name", unhandledAssociatedElement->name()); 263 frame->domWindow()->console()->addMessage(HTMLMessageSource, LogMessageType, ErrorMessageLevel, message, document()->url().string());263 document()->domWindow()->console()->addMessage(HTMLMessageSource, LogMessageType, ErrorMessageLevel, message, document()->url().string()); 264 264 } 265 265 } -
trunk/Source/WebCore/html/HTMLFrameOwnerElement.cpp
r117242 r125615 74 74 DOMWindow* HTMLFrameOwnerElement::contentWindow() const 75 75 { 76 return m_contentFrame ? m_contentFrame->do mWindow() : 0;76 return m_contentFrame ? m_contentFrame->document()->domWindow() : 0; 77 77 } 78 78 -
trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp
r125580 r125615 5174 5174 if (!canvas()) 5175 5175 return; 5176 // FIXME: This giant cascade of null checks seems a bit paranoid. 5176 5177 Document* document = canvas()->document(); 5177 5178 if (!document) … … 5180 5181 if (!frame) 5181 5182 return; 5182 DOMWindow* window = frame->domWindow();5183 DOMWindow* window = document->domWindow(); 5183 5184 if (!window) 5184 5185 return; -
trunk/Source/WebCore/inspector/InspectorDOMStorageAgent.cpp
r124332 r125615 157 157 Frame* frame = storage->frame(); 158 158 ExceptionCode ec = 0; 159 bool isLocalStorage = (frame->do mWindow()->localStorage(ec) == storage && !ec);159 bool isLocalStorage = (frame->document()->domWindow()->localStorage(ec) == storage && !ec); 160 160 return storageId(frame->document()->securityOrigin(), isLocalStorage); 161 161 } -
trunk/Source/WebCore/loader/DocumentLoader.cpp
r124884 r125615 423 423 ASSERT(this == frameLoader()->activeDocumentLoader()); 424 424 425 if (DOMWindow* window = m_frame-> existingDOMWindow())425 if (DOMWindow* window = m_frame->document()->domWindow()) 426 426 window->finishedLoading(); 427 427 } -
trunk/Source/WebCore/loader/FrameLoader.cpp
r125613 r125615 358 358 if (currentFocusedNode) 359 359 currentFocusedNode->aboutToUnload(); 360 if (m_frame->do mWindow() && m_pageDismissalEventBeingDispatched == NoDismissal) {360 if (m_frame->document()->domWindow() && m_pageDismissalEventBeingDispatched == NoDismissal) { 361 361 if (unloadEventPolicy == UnloadEventPolicyUnloadAndPageHide) { 362 362 m_pageDismissalEventBeingDispatched = PageHideDismissal; 363 m_frame->do mWindow()->dispatchEvent(PageTransitionEvent::create(eventNames().pagehideEvent, m_frame->document()->inPageCache()), m_frame->document());363 m_frame->document()->domWindow()->dispatchEvent(PageTransitionEvent::create(eventNames().pagehideEvent, m_frame->document()->inPageCache()), m_frame->document()); 364 364 } 365 365 if (!m_frame->document()->inPageCache()) { … … 374 374 ASSERT(timing->navigationStart()); 375 375 timing->markUnloadEventStart(); 376 m_frame->do mWindow()->dispatchEvent(unloadEvent, m_frame->domWindow()->document());376 m_frame->document()->domWindow()->dispatchEvent(unloadEvent, m_frame->document()); 377 377 timing->markUnloadEventEnd(); 378 378 } else 379 m_frame->do mWindow()->dispatchEvent(unloadEvent, m_frame->domWindow()->document());379 m_frame->document()->domWindow()->dispatchEvent(unloadEvent, m_frame->document()); 380 380 } 381 381 } … … 465 465 // since it may cause clients to attempt to render the frame. 466 466 if (!m_stateMachine.creatingInitialEmptyDocument()) { 467 if (DOMWindow* window = m_frame-> existingDOMWindow()) {467 if (DOMWindow* window = m_frame->document()->domWindow()) { 468 468 window->setStatus(String()); 469 469 window->setDefaultStatus(String()); … … 887 887 m_frame->document()->url().string() + " displayed insecure content from " + url.string() + ".\n"; 888 888 889 m_frame->do mWindow()->console()->addMessage(HTMLMessageSource, LogMessageType, WarningMessageLevel, message);889 m_frame->document()->domWindow()->console()->addMessage(HTMLMessageSource, LogMessageType, WarningMessageLevel, message); 890 890 891 891 if (allowed) … … 905 905 m_frame->document()->url().string() + " ran insecure content from " + url.string() + ".\n"; 906 906 907 m_frame->do mWindow()->console()->addMessage(HTMLMessageSource, LogMessageType, WarningMessageLevel, message);907 m_frame->document()->domWindow()->console()->addMessage(HTMLMessageSource, LogMessageType, WarningMessageLevel, message); 908 908 909 909 if (allowed) … … 1372 1372 return; 1373 1373 1374 frame->do mWindow()->console()->addMessage(JSMessageSource, LogMessageType, ErrorMessageLevel, "Not allowed to load local resource: " + url);1374 frame->document()->domWindow()->console()->addMessage(JSMessageSource, LogMessageType, ErrorMessageLevel, "Not allowed to load local resource: " + url); 1375 1375 } 1376 1376 … … 1903 1903 // Delete old status bar messages (if it _was_ activated on last URL). 1904 1904 if (m_frame->script()->canExecuteScripts(NotAboutToExecuteScript)) { 1905 if (DOMWindow* window = m_frame-> existingDOMWindow()) {1905 if (DOMWindow* window = m_frame->document()->domWindow()) { 1906 1906 window->setStatus(String()); 1907 1907 window->setDefaultStatus(String()); … … 2693 2693 bool FrameLoader::fireBeforeUnloadEvent(Chrome* chrome) 2694 2694 { 2695 DOMWindow* domWindow = m_frame-> existingDOMWindow();2695 DOMWindow* domWindow = m_frame->document()->domWindow(); 2696 2696 if (!domWindow) 2697 2697 return true; -
trunk/Source/WebCore/loader/MainResourceLoader.cpp
r125265 r125615 368 368 InspectorInstrumentation::continueAfterXFrameOptionsDenied(m_frame.get(), documentLoader(), identifier(), r); 369 369 DEFINE_STATIC_LOCAL(String, consoleMessage, ("Refused to display document because display forbidden by X-Frame-Options.\n")); 370 m_frame->do mWindow()->console()->addMessage(JSMessageSource, LogMessageType, ErrorMessageLevel, consoleMessage);370 m_frame->document()->domWindow()->console()->addMessage(JSMessageSource, LogMessageType, ErrorMessageLevel, consoleMessage); 371 371 372 372 cancel(); -
trunk/Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp
r125570 r125615 470 470 return; 471 471 472 frame->do mWindow()->console()->addMessage(OtherMessageSource, LogMessageType, TipMessageLevel, "Application Cache download process was aborted.");472 frame->document()->domWindow()->console()->addMessage(OtherMessageSource, LogMessageType, TipMessageLevel, "Application Cache download process was aborted."); 473 473 cacheUpdateFailed(); 474 474 } … … 564 564 if (response.httpStatusCode() / 100 != 2 || response.url() != m_currentHandle->firstRequest().url()) { 565 565 if ((type & ApplicationCacheResource::Explicit) || (type & ApplicationCacheResource::Fallback)) { 566 m_frame->do mWindow()->console()->addMessage(OtherMessageSource, LogMessageType, ErrorMessageLevel, "Application Cache update failed, because " + m_currentHandle->firstRequest().url().string() +566 m_frame->document()->domWindow()->console()->addMessage(OtherMessageSource, LogMessageType, ErrorMessageLevel, "Application Cache update failed, because " + m_currentHandle->firstRequest().url().string() + 567 567 ((response.httpStatusCode() / 100 != 2) ? " could not be fetched." : " was redirected.")); 568 568 // Note that cacheUpdateFailed() can cause the cache group to be deleted. … … 641 641 if (m_originQuotaExceededPreviously && m_availableSpaceInQuota < m_cacheBeingUpdated->estimatedSizeInStorage()) { 642 642 m_currentResource = 0; 643 m_frame->do mWindow()->console()->addMessage(OtherMessageSource, LogMessageType, ErrorMessageLevel, "Application Cache update failed, because size quota was exceeded.");643 m_frame->document()->domWindow()->console()->addMessage(OtherMessageSource, LogMessageType, ErrorMessageLevel, "Application Cache update failed, because size quota was exceeded."); 644 644 cacheUpdateFailed(); 645 645 return; … … 674 674 675 675 if ((type & ApplicationCacheResource::Explicit) || (type & ApplicationCacheResource::Fallback)) { 676 m_frame->do mWindow()->console()->addMessage(OtherMessageSource, LogMessageType, ErrorMessageLevel, "Application Cache update failed, because " + url.string() + " could not be fetched.");676 m_frame->document()->domWindow()->console()->addMessage(OtherMessageSource, LogMessageType, ErrorMessageLevel, "Application Cache update failed, because " + url.string() + " could not be fetched."); 677 677 // Note that cacheUpdateFailed() can cause the cache group to be deleted. 678 678 cacheUpdateFailed(); … … 703 703 704 704 if (response.httpStatusCode() / 100 != 2) { 705 m_frame->do mWindow()->console()->addMessage(OtherMessageSource, LogMessageType, ErrorMessageLevel, "Application Cache manifest could not be fetched.");705 m_frame->document()->domWindow()->console()->addMessage(OtherMessageSource, LogMessageType, ErrorMessageLevel, "Application Cache manifest could not be fetched."); 706 706 cacheUpdateFailed(); 707 707 return; … … 709 709 710 710 if (response.url() != m_manifestHandle->firstRequest().url()) { 711 m_frame->do mWindow()->console()->addMessage(OtherMessageSource, LogMessageType, ErrorMessageLevel, "Application Cache manifest could not be fetched, because a redirection was attempted.");711 m_frame->document()->domWindow()->console()->addMessage(OtherMessageSource, LogMessageType, ErrorMessageLevel, "Application Cache manifest could not be fetched, because a redirection was attempted."); 712 712 cacheUpdateFailed(); 713 713 return; … … 729 729 if (!isUpgradeAttempt && !m_manifestResource) { 730 730 // The server returned 304 Not Modified even though we didn't send a conditional request. 731 m_frame->do mWindow()->console()->addMessage(OtherMessageSource, LogMessageType, ErrorMessageLevel, "Application Cache manifest could not be fetched because of an unexpected 304 Not Modified server response.");731 m_frame->document()->domWindow()->console()->addMessage(OtherMessageSource, LogMessageType, ErrorMessageLevel, "Application Cache manifest could not be fetched because of an unexpected 304 Not Modified server response."); 732 732 cacheUpdateFailed(); 733 733 return; … … 755 755 if (!parseManifest(m_manifestURL, m_manifestResource->data()->data(), m_manifestResource->data()->size(), manifest)) { 756 756 // At the time of this writing, lack of "CACHE MANIFEST" signature is the only reason for parseManifest to fail. 757 m_frame->do mWindow()->console()->addMessage(OtherMessageSource, LogMessageType, ErrorMessageLevel, "Application Cache manifest could not be parsed. Does it start with CACHE MANIFEST?");757 m_frame->document()->domWindow()->console()->addMessage(OtherMessageSource, LogMessageType, ErrorMessageLevel, "Application Cache manifest could not be parsed. Does it start with CACHE MANIFEST?"); 758 758 cacheUpdateFailed(); 759 759 return; … … 944 944 // after recording this state. 945 945 m_originQuotaExceededPreviously = true; 946 m_frame->do mWindow()->console()->addMessage(OtherMessageSource, LogMessageType, ErrorMessageLevel, "Application Cache update failed, because size quota was exceeded.");946 m_frame->document()->domWindow()->console()->addMessage(OtherMessageSource, LogMessageType, ErrorMessageLevel, "Application Cache update failed, because size quota was exceeded."); 947 947 } 948 948 -
trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp
r124884 r125615 617 617 618 618 // FIXME: provide line number and source URL. 619 frame()->do mWindow()->console()->addMessage(OtherMessageSource, LogMessageType, ErrorMessageLevel, message);619 frame()->document()->domWindow()->console()->addMessage(OtherMessageSource, LogMessageType, ErrorMessageLevel, message); 620 620 } 621 621 -
trunk/Source/WebCore/page/DOMWindow.cpp
r125613 r125615 595 595 bool DOMWindow::isCurrentlyDisplayedInFrame() const 596 596 { 597 return m_frame && m_frame->do mWindow() == this;597 return m_frame && m_frame->document()->domWindow() == this; 598 598 } 599 599 … … 1261 1261 return 0; 1262 1262 1263 return m_frame->do mWindow();1263 return m_frame->document()->domWindow(); 1264 1264 } 1265 1265 … … 1273 1273 return 0; 1274 1274 1275 return opener->do mWindow();1275 return opener->document()->domWindow(); 1276 1276 } 1277 1277 … … 1283 1283 Frame* parent = m_frame->tree()->parent(); 1284 1284 if (parent) 1285 return parent->do mWindow();1286 1287 return m_frame->do mWindow();1285 return parent->document()->domWindow(); 1286 1287 return m_frame->document()->domWindow(); 1288 1288 } 1289 1289 … … 1297 1297 return 0; 1298 1298 1299 return m_frame->tree()->top()->do mWindow();1299 return m_frame->tree()->top()->document()->domWindow(); 1300 1300 } 1301 1301 … … 1824 1824 newFrame->page()->setOpenedByDOM(); 1825 1825 1826 if (newFrame->do mWindow()->isInsecureScriptAccess(activeWindow, completedURL))1826 if (newFrame->document()->domWindow()->isInsecureScriptAccess(activeWindow, completedURL)) 1827 1827 return newFrame; 1828 1828 1829 1829 if (function) 1830 function(newFrame->do mWindow(), functionContext);1830 function(newFrame->document()->domWindow(), functionContext); 1831 1831 1832 1832 if (created) … … 1876 1876 KURL completedURL = firstFrame->document()->completeURL(urlString); 1877 1877 1878 if (targetFrame->do mWindow()->isInsecureScriptAccess(activeWindow, completedURL))1879 return targetFrame->do mWindow();1878 if (targetFrame->document()->domWindow()->isInsecureScriptAccess(activeWindow, completedURL)) 1879 return targetFrame->document()->domWindow(); 1880 1880 1881 1881 if (urlString.isEmpty()) 1882 return targetFrame->do mWindow();1882 return targetFrame->document()->domWindow(); 1883 1883 1884 1884 // For whatever reason, Firefox uses the first window rather than the active window to … … 1891 1891 lockHistory, 1892 1892 false); 1893 return targetFrame->do mWindow();1893 return targetFrame->document()->domWindow(); 1894 1894 } 1895 1895 … … 1905 1905 1906 1906 Frame* result = createWindow(urlString, frameName, windowFeatures, activeWindow, firstFrame, m_frame); 1907 return result ? result->do mWindow() : 0;1907 return result ? result->document()->domWindow() : 0; 1908 1908 } 1909 1909 -
trunk/Source/WebCore/page/DOMWindowProperty.cpp
r119136 r125615 29 29 30 30 #include "DOMWindow.h" 31 #include "Document.h" 31 32 #include "Frame.h" 32 33 … … 41 42 // We should fix that. <rdar://problem/11567132> 42 43 if (m_frame) { 43 m_associatedDOMWindow = m_frame->do mWindow();44 m_associatedDOMWindow = m_frame->document()->domWindow(); 44 45 m_associatedDOMWindow->registerProperty(this); 45 46 } … … 71 72 ASSERT(frame); 72 73 ASSERT(!m_frame); 73 ASSERT(frame->do mWindow() == m_associatedDOMWindow);74 ASSERT(frame->document()->domWindow() == m_associatedDOMWindow); 74 75 75 76 m_frame = frame; -
trunk/Source/WebCore/page/DragController.cpp
r124588 r125615 424 424 Node* target = innerFrame->editor()->findEventTargetFrom(m_page->dragCaretController()->caretPosition()); 425 425 ExceptionCode ec = 0; 426 return target->dispatchEvent(TextEvent::createForDrop(innerFrame->do mWindow(), text), ec);426 return target->dispatchEvent(TextEvent::createForDrop(innerFrame->document()->domWindow(), text), ec); 427 427 } 428 428 -
trunk/Source/WebCore/page/EventHandler.cpp
r125389 r125615 3293 3293 view->resetDeferredRepaintDelay(); 3294 3294 3295 RefPtr<TextEvent> event = TextEvent::create(m_frame->do mWindow(), text, inputType);3295 RefPtr<TextEvent> event = TextEvent::create(m_frame->document()->domWindow(), text, inputType); 3296 3296 event->setUnderlyingEvent(underlyingEvent); 3297 3297 -
trunk/Source/WebCore/page/Frame.cpp
r125592 r125615 681 681 } 682 682 683 DOMWindow* Frame::domWindow() const684 {685 ASSERT(m_doc->domWindow());686 return m_doc->domWindow();687 }688 689 683 void Frame::willDetachPage() 690 684 { -
trunk/Source/WebCore/page/Frame.h
r125592 r125615 129 129 String layerTreeAsText(bool showDebugInfo = false) const; 130 130 131 // FIXME: Callers should use document()->domWindow() directly.132 DOMWindow* domWindow() const;133 DOMWindow* existingDOMWindow() { return domWindow(); }134 135 131 static Frame* frameForWidget(const Widget*); 136 132 -
trunk/Source/WebCore/page/Location.cpp
r120005 r125615 242 242 return; 243 243 // Note: We call DOMWindow::setLocation directly here because replace() always operates on the current frame. 244 m_frame->do mWindow()->setLocation(url, activeWindow, firstWindow, LockHistoryAndBackForwardList);244 m_frame->document()->domWindow()->setLocation(url, activeWindow, firstWindow, LockHistoryAndBackForwardList); 245 245 } 246 246 … … 252 252 // We allow one page to change the location of another. Why block attempts to reload? 253 253 // Other location operations simply block use of JavaScript URLs cross origin. 254 DOMWindow* targetWindow = m_frame->do mWindow();254 DOMWindow* targetWindow = m_frame->document()->domWindow(); 255 255 if (!activeWindow->securityOrigin()->canAccess(targetWindow->securityOrigin())) { 256 256 targetWindow->printErrorMessage(targetWindow->crossDomainAccessErrorMessage(activeWindow)); … … 269 269 if (!frame) 270 270 return; 271 frame->do mWindow()->setLocation(url, activeWindow, firstWindow);271 frame->document()->domWindow()->setLocation(url, activeWindow, firstWindow); 272 272 } 273 273 -
trunk/Source/WebCore/storage/StorageEventDispatcher.cpp
r118349 r125615 58 58 for (unsigned i = 0; i < frames.size(); ++i) { 59 59 ExceptionCode ec = 0; 60 Storage* storage = frames[i]->do mWindow()->sessionStorage(ec);60 Storage* storage = frames[i]->document()->domWindow()->sessionStorage(ec); 61 61 if (!ec) 62 62 frames[i]->document()->enqueueWindowEvent(StorageEvent::create(eventNames().storageEvent, key, oldValue, newValue, sourceFrame->document()->url(), storage)); … … 76 76 for (unsigned i = 0; i < frames.size(); ++i) { 77 77 ExceptionCode ec = 0; 78 Storage* storage = frames[i]->do mWindow()->localStorage(ec);78 Storage* storage = frames[i]->document()->domWindow()->localStorage(ec); 79 79 if (!ec) 80 80 frames[i]->document()->enqueueWindowEvent(StorageEvent::create(eventNames().storageEvent, key, oldValue, newValue, sourceFrame->document()->url(), storage)); -
trunk/Source/WebCore/svg/SVGDocumentExtensions.cpp
r122278 r125615 197 197 static void reportMessage(Document* document, MessageLevel level, const String& message) 198 198 { 199 if ( Frame* frame =document->frame())200 frame->domWindow()->console()->addMessage(JSMessageSource, LogMessageType, level, message, document->documentURI(), parserLineNumber(document));199 if (document->frame()) 200 document->domWindow()->console()->addMessage(JSMessageSource, LogMessageType, level, message, document->documentURI(), parserLineNumber(document)); 201 201 } 202 202 -
trunk/Source/WebCore/xml/XSLStyleSheetLibxslt.cpp
r113922 r125615 146 146 147 147 Console* console = 0; 148 if ( Frame* frame =ownerDocument()->frame())149 console = frame->domWindow()->console();148 if (ownerDocument()->frame()) 149 console = ownerDocument()->domWindow()->console(); 150 150 151 151 XMLDocumentParserScope scope(cachedResourceLoader(), XSLTProcessor::genericErrorFunc, XSLTProcessor::parseErrorFunc, console); -
trunk/Source/WebCore/xml/XSLTProcessorLibxslt.cpp
r105524 r125615 139 139 140 140 Console* console = 0; 141 if ( Frame* frame =globalProcessor->xslStylesheet()->ownerDocument()->frame())142 console = frame->domWindow()->console();141 if (globalProcessor->xslStylesheet()->ownerDocument()->frame()) 142 console = globalProcessor->xslStylesheet()->ownerDocument()->domWindow()->console(); 143 143 xmlSetStructuredErrorFunc(console, XSLTProcessor::parseErrorFunc); 144 144 xmlSetGenericErrorFunc(console, XSLTProcessor::genericErrorFunc); -
trunk/Source/WebCore/xml/XSLTProcessorQt.cpp
r104803 r125615 84 84 } 85 85 86 Console* console = m_document->frame()->domWindow()->console(); 87 console->addMessage(XMLMessageSource, LogMessageType, level, description, 88 sourceLocation.uri().toString(), sourceLocation.line()); 86 Console* console = m_document->domWindow()->console(); 87 console->addMessage(XMLMessageSource, LogMessageType, level, description, sourceLocation.uri().toString(), sourceLocation.line()); 89 88 } 90 89 -
trunk/Source/WebKit/blackberry/ChangeLog
r125611 r125615 1 2012-08-14 Adam Barth <abarth@webkit.org> 2 3 Delete Frame::domWindow() and Frame::existingDOMWindow() 4 https://bugs.webkit.org/show_bug.cgi?id=93990 5 6 Reviewed by Eric Seidel. 7 8 * WebCoreSupport/ChromeClientBlackBerry.cpp: 9 (WebCore::toOriginString): 10 (WebCore::ChromeClientBlackBerry::runJavaScriptAlert): 11 (WebCore::ChromeClientBlackBerry::runJavaScriptConfirm): 12 (WebCore::ChromeClientBlackBerry::runJavaScriptPrompt): 13 (WebCore::ChromeClientBlackBerry::runBeforeUnloadConfirmPanel): 14 (WebCore::ChromeClientBlackBerry::requestWebGLPermission): 15 1 16 2012-08-14 Leo Yang <leoyang@rim.com> 2 17 -
trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp
r124285 r125615 79 79 namespace WebCore { 80 80 81 static CString frameOrigin(Frame* frame) 82 { 83 DOMWindow* window = frame->domWindow(); 84 SecurityOrigin* origin = window->securityOrigin(); 85 CString latinOrigin = origin->toString().latin1(); 86 return latinOrigin; 81 static CString toOriginString(Frame* frame) 82 { 83 return frame->document()->securityOrigin()->toString().latin1(); 87 84 } 88 85 … … 112 109 113 110 TimerBase::fireTimersInNestedEventLoop(); 114 CString latinOrigin = frameOrigin(frame);111 CString latinOrigin = toOriginString(frame); 115 112 m_webPagePrivate->m_client->runJavaScriptAlert(message.characters(), message.length(), latinOrigin.data(), latinOrigin.length()); 116 113 } … … 124 121 125 122 TimerBase::fireTimersInNestedEventLoop(); 126 CString latinOrigin = frameOrigin(frame);123 CString latinOrigin = toOriginString(frame); 127 124 return m_webPagePrivate->m_client->runJavaScriptConfirm(message.characters(), message.length(), latinOrigin.data(), latinOrigin.length()); 128 125 } … … 138 135 139 136 TimerBase::fireTimersInNestedEventLoop(); 140 CString latinOrigin = frameOrigin(frame);137 CString latinOrigin = toOriginString(frame); 141 138 WebString clientResult; 142 139 if (m_webPagePrivate->m_client->runJavaScriptPrompt(message.characters(), message.length(), defaultValue.characters(), defaultValue.length(), latinOrigin.data(), latinOrigin.length(), clientResult)) { … … 387 384 388 385 TimerBase::fireTimersInNestedEventLoop(); 389 CString latinOrigin = frameOrigin(frame);386 CString latinOrigin = toOriginString(frame); 390 387 return m_webPagePrivate->m_client->runBeforeUnloadConfirmPanel(message.characters(), message.length(), latinOrigin.data(), latinOrigin.length()); 391 388 } … … 769 766 { 770 767 if (frame) { 771 CString latinOrigin = frameOrigin(frame);768 CString latinOrigin = toOriginString(frame); 772 769 m_webPagePrivate->m_client->requestWebGLPermission(latinOrigin.data()); 773 770 } -
trunk/Source/WebKit/chromium/ChangeLog
r125581 r125615 1 2012-08-14 Adam Barth <abarth@webkit.org> 2 3 Delete Frame::domWindow() and Frame::existingDOMWindow() 4 https://bugs.webkit.org/show_bug.cgi?id=93990 5 6 Reviewed by Eric Seidel. 7 8 * src/StorageAreaProxy.cpp: 9 (WebCore::StorageAreaProxy::dispatchLocalStorageEvent): 10 (WebCore::StorageAreaProxy::dispatchSessionStorageEvent): 11 * src/WebDOMMessageEvent.cpp: 12 (WebKit::WebDOMMessageEvent::initMessageEvent): 13 * src/WebFrameImpl.cpp: 14 (WebKit::WebFrameImpl::performance): 15 (WebKit::WebFrameImpl::addMessageToConsole): 16 (WebKit::WebFrameImpl::unloadListenerCount): 17 (WebKit::WebFrameImpl::addEventListener): 18 (WebKit::WebFrameImpl::removeEventListener): 19 (WebKit::WebFrameImpl::dispatchEvent): 20 (WebKit::WebFrameImpl::dispatchMessageEventWithOriginCheck): 21 (WebKit::WebFrameImpl::deliverIntent): 22 * src/WebPagePopupImpl.cpp: 23 (WebKit::WebPagePopupImpl::initPage): 24 1 25 2012-08-14 Iain Merrick <husky@chromium.org> 2 26 -
trunk/Source/WebKit/chromium/src/StorageAreaProxy.cpp
r124332 r125615 132 132 for (HashSet<Page*>::const_iterator it = pages.begin(); it != pages.end(); ++it) { 133 133 for (Frame* frame = (*it)->mainFrame(); frame; frame = frame->tree()->traverseNext()) { 134 Storage* storage = frame->do mWindow()->optionalLocalStorage();134 Storage* storage = frame->document()->domWindow()->optionalLocalStorage(); 135 135 if (storage && frame->document()->securityOrigin()->equal(securityOrigin) && !isEventSource(storage, sourceAreaInstance)) 136 136 frame->document()->enqueueWindowEvent(StorageEvent::create(eventNames().storageEvent, key, oldValue, newValue, pageURL, storage)); … … 161 161 162 162 for (Frame* frame = page->mainFrame(); frame; frame = frame->tree()->traverseNext()) { 163 Storage* storage = frame->do mWindow()->optionalSessionStorage();163 Storage* storage = frame->document()->domWindow()->optionalSessionStorage(); 164 164 if (storage && frame->document()->securityOrigin()->equal(securityOrigin) && !isEventSource(storage, sourceAreaInstance)) 165 165 frame->document()->enqueueWindowEvent(StorageEvent::create(eventNames().storageEvent, key, oldValue, newValue, pageURL, storage)); -
trunk/Source/WebKit/chromium/src/WebDOMMessageEvent.cpp
r102496 r125615 33 33 34 34 #include "DOMWindow.h" 35 #include "Document.h" 35 36 #include "MessageEvent.h" 36 37 #include "MessagePort.h" … … 56 57 DOMWindow* window = 0; 57 58 if (sourceFrame) 58 window = static_cast<const WebFrameImpl*>(sourceFrame)->frame()->do mWindow();59 window = static_cast<const WebFrameImpl*>(sourceFrame)->frame()->document()->domWindow(); 59 60 OwnPtr<MessagePortArray> ports; 60 61 unwrap<MessageEvent>()->initMessageEvent(type, canBubble, cancelable, messageData, origin, lastEventId, window, ports.release()); -
trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp
r125385 r125615 810 810 WebPerformance WebFrameImpl::performance() const 811 811 { 812 if (!m_frame || !m_frame->domWindow())812 if (!m_frame) 813 813 return WebPerformance(); 814 814 815 return WebPerformance(m_frame->do mWindow()->performance());815 return WebPerformance(m_frame->document()->domWindow()->performance()); 816 816 } 817 817 … … 888 888 } 889 889 890 frame()->do mWindow()->console()->addMessage(OtherMessageSource, LogMessageType, webCoreMessageLevel, message.text);890 frame()->document()->domWindow()->console()->addMessage(OtherMessageSource, LogMessageType, webCoreMessageLevel, message.text); 891 891 } 892 892 … … 1181 1181 unsigned WebFrameImpl::unloadListenerCount() const 1182 1182 { 1183 return frame()->do mWindow()->pendingUnloadEventListeners();1183 return frame()->document()->domWindow()->pendingUnloadEventListeners(); 1184 1184 } 1185 1185 … … 1957 1957 void WebFrameImpl::addEventListener(const WebString& eventType, WebDOMEventListener* listener, bool useCapture) 1958 1958 { 1959 DOMWindow* window = m_frame->domWindow(); 1960 1961 EventListenerWrapper* listenerWrapper = 1962 listener->createEventListenerWrapper(eventType, useCapture, window); 1963 1964 m_frame->domWindow()->addEventListener(eventType, adoptRef(listenerWrapper), useCapture); 1959 DOMWindow* window = m_frame->document()->domWindow(); 1960 EventListenerWrapper* listenerWrapper = listener->createEventListenerWrapper(eventType, useCapture, window); 1961 window->addEventListener(eventType, adoptRef(listenerWrapper), useCapture); 1965 1962 } 1966 1963 1967 1964 void WebFrameImpl::removeEventListener(const WebString& eventType, WebDOMEventListener* listener, bool useCapture) 1968 1965 { 1969 DOMWindow* window = m_frame->domWindow(); 1970 1971 EventListenerWrapper* listenerWrapper = 1972 listener->getEventListenerWrapper(eventType, useCapture, window); 1966 DOMWindow* window = m_frame->document()->domWindow(); 1967 EventListenerWrapper* listenerWrapper = listener->getEventListenerWrapper(eventType, useCapture, window); 1973 1968 window->removeEventListener(eventType, listenerWrapper, useCapture); 1974 1969 } … … 1977 1972 { 1978 1973 ASSERT(!event.isNull()); 1979 return m_frame->do mWindow()->dispatchEvent(event);1974 return m_frame->document()->domWindow()->dispatchEvent(event); 1980 1975 } 1981 1976 … … 1984 1979 ASSERT(!event.isNull()); 1985 1980 // Pass an empty call stack, since we don't have the one from the other process. 1986 m_frame->do mWindow()->dispatchMessageEventWithOriginCheck(intendedTargetOrigin.get(), event, 0);1981 m_frame->document()->domWindow()->dispatchMessageEventWithOriginCheck(intendedTargetOrigin.get(), event, 0); 1987 1982 } 1988 1983 … … 2191 2186 } 2192 2187 } 2193 OwnPtr<MessagePortArray> portArray = WebCore::MessagePort::entanglePorts(*(m_frame->do mWindow()->scriptExecutionContext()), channels.release());2188 OwnPtr<MessagePortArray> portArray = WebCore::MessagePort::entanglePorts(*(m_frame->document()), channels.release()); 2194 2189 2195 2190 RefPtr<DeliveredIntent> deliveredIntent = DeliveredIntent::create(m_frame, client.release(), intent.action(), intent.type(), intentData, portArray.release(), webcoreIntent->extras()); 2196 2191 2197 DOMWindowIntents::from(m_frame->do mWindow())->deliver(deliveredIntent.release());2192 DOMWindowIntents::from(m_frame->document()->domWindow())->deliver(deliveredIntent.release()); 2198 2193 #endif 2199 2194 } -
trunk/Source/WebKit/chromium/src/WebPagePopupImpl.cpp
r125169 r125615 199 199 writer->end(); 200 200 201 ASSERT(frame->existingDOMWindow()); 202 DOMWindowPagePopup::install(frame->existingDOMWindow(), m_popupClient); 201 DOMWindowPagePopup::install(frame->document()->domWindow(), m_popupClient); 203 202 return true; 204 203 } -
trunk/Source/WebKit/efl/ChangeLog
r125500 r125615 1 2012-08-14 Adam Barth <abarth@webkit.org> 2 3 Delete Frame::domWindow() and Frame::existingDOMWindow() 4 https://bugs.webkit.org/show_bug.cgi?id=93990 5 6 Reviewed by Eric Seidel. 7 8 * WebCoreSupport/DumpRenderTreeSupportEfl.cpp: 9 (DumpRenderTreeSupportEfl::pendingUnloadEventCount): 10 * ewk/ewk_frame.cpp: 11 (ewk_frame_intent_deliver): 12 1 13 2012-08-13 Tom Sepez <tsepez@chromium.org> 2 14 -
trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp
r123711 r125615 226 226 { 227 227 if (WebCore::Frame* frame = EWKPrivate::coreFrame(ewkFrame)) 228 return frame->do mWindow()->pendingUnloadEventListeners();228 return frame->document()->domWindow()->pendingUnloadEventListeners(); 229 229 230 230 return 0; -
trunk/Source/WebKit/efl/ewk/ewk_frame.cpp
r124945 r125615 767 767 (*channels)[i] = origChannels->at(i).release(); 768 768 } 769 OwnPtr<WebCore::MessagePortArray> ports = WebCore::MessagePort::entanglePorts(*(smartData->frame->do mWindow()->scriptExecutionContext()), channels.release());769 OwnPtr<WebCore::MessagePortArray> ports = WebCore::MessagePort::entanglePorts(*(smartData->frame->document()), channels.release()); 770 770 771 771 OwnPtr<WebCore::DeliveredIntentClient> dummyClient; 772 772 RefPtr<WebCore::DeliveredIntent> deliveredIntent = WebCore::DeliveredIntent::create(smartData->frame, dummyClient.release(), intent->action(), intent->type(), intent->data(), ports.release(), intent->extras()); 773 773 774 WebCore::DOMWindowIntents::from(smartData->frame->do mWindow())->deliver(deliveredIntent.release());774 WebCore::DOMWindowIntents::from(smartData->frame->document()->domWindow())->deliver(deliveredIntent.release()); 775 775 #endif 776 776 } -
trunk/Source/WebKit/gtk/ChangeLog
r125500 r125615 1 2012-08-14 Adam Barth <abarth@webkit.org> 2 3 Delete Frame::domWindow() and Frame::existingDOMWindow() 4 https://bugs.webkit.org/show_bug.cgi?id=93990 5 6 Reviewed by Eric Seidel. 7 8 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 9 (DumpRenderTreeSupportGtk::getPendingUnloadEventCount): 10 1 11 2012-08-13 Tom Sepez <tsepez@chromium.org> 2 12 -
trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp
r123711 r125615 280 280 g_return_val_if_fail(WEBKIT_IS_WEB_FRAME(frame), 0); 281 281 282 return core(frame)->do mWindow()->pendingUnloadEventListeners();282 return core(frame)->document()->domWindow()->pendingUnloadEventListeners(); 283 283 } 284 284 -
trunk/Source/WebKit/mac/ChangeLog
r125601 r125615 1 2012-08-14 Adam Barth <abarth@webkit.org> 2 3 Delete Frame::domWindow() and Frame::existingDOMWindow() 4 https://bugs.webkit.org/show_bug.cgi?id=93990 5 6 Reviewed by Eric Seidel. 7 8 * WebView/WebFrame.mm: 9 (-[WebFrame _pendingFrameUnloadEventCount]): 10 (-[WebFrame _cacheabilityDictionary]): 11 1 12 2012-08-14 Tom Sepez <tsepez@chromium.org> 2 13 -
trunk/Source/WebKit/mac/WebView/WebFrame.mm
r121381 r125615 907 907 - (unsigned)_pendingFrameUnloadEventCount 908 908 { 909 return _private->coreFrame->do mWindow()->pendingUnloadEventListeners();909 return _private->coreFrame->document()->domWindow()->pendingUnloadEventListeners(); 910 910 } 911 911 … … 1068 1068 [result setObject:[NSNumber numberWithBool:YES] forKey:WebFrameHasPlugins]; 1069 1069 1070 if (DOMWindow* domWindow = _private->coreFrame->do mWindow()) {1070 if (DOMWindow* domWindow = _private->coreFrame->document()->domWindow()) { 1071 1071 if (domWindow->hasEventListeners(eventNames().unloadEvent)) 1072 1072 [result setObject:[NSNumber numberWithBool:YES] forKey:WebFrameHasUnloadListener]; -
trunk/Source/WebKit/qt/ChangeLog
r125603 r125615 1 2012-08-14 Adam Barth <abarth@webkit.org> 2 3 Delete Frame::domWindow() and Frame::existingDOMWindow() 4 https://bugs.webkit.org/show_bug.cgi?id=93990 5 6 Reviewed by Eric Seidel. 7 8 * WebCoreSupport/FrameLoaderClientQt.cpp: 9 (WebCore::FrameLoaderClientQt::dispatchDidFinishDocumentLoad): 10 1 11 2012-08-14 Lauro Neto <lauro.neto@openbossa.org> 2 12 -
trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp
r125500 r125615 504 504 505 505 if (QWebPagePrivate::drtRun) { 506 int unloadEventCount = m_frame->do mWindow()->pendingUnloadEventListeners();506 int unloadEventCount = m_frame->document()->domWindow()->pendingUnloadEventListeners(); 507 507 if (unloadEventCount) 508 508 printf("%s - has %u onunload handler(s)\n", qPrintable(drtDescriptionSuitableForTestResult(m_frame)), unloadEventCount); -
trunk/Source/WebKit/win/ChangeLog
r125500 r125615 1 2012-08-14 Adam Barth <abarth@webkit.org> 2 3 Delete Frame::domWindow() and Frame::existingDOMWindow() 4 https://bugs.webkit.org/show_bug.cgi?id=93990 5 6 Reviewed by Eric Seidel. 7 8 * WebFrame.cpp: 9 (WebFrame::DOMWindow): 10 (WebFrame::pendingFrameUnloadEventCount): 11 1 12 2012-08-13 Tom Sepez <tsepez@chromium.org> 2 13 -
trunk/Source/WebKit/win/WebFrame.cpp
r123718 r125615 479 479 480 480 if (Frame* coreFrame = core(this)) { 481 if (WebCore::DOMWindow* coreWindow = coreFrame->do mWindow())481 if (WebCore::DOMWindow* coreWindow = coreFrame->document()->domWindow()) 482 482 *window = ::DOMWindow::createInstance(coreWindow); 483 483 } … … 990 990 return E_FAIL; 991 991 992 *result = coreFrame->do mWindow()->pendingUnloadEventListeners();992 *result = coreFrame->document()->domWindow()->pendingUnloadEventListeners(); 993 993 return S_OK; 994 994 } -
trunk/Source/WebKit2/ChangeLog
r125603 r125615 1 2012-08-14 Adam Barth <abarth@webkit.org> 2 3 Delete Frame::domWindow() and Frame::existingDOMWindow() 4 https://bugs.webkit.org/show_bug.cgi?id=93990 5 6 Reviewed by Eric Seidel. 7 8 * WebProcess/WebPage/WebFrame.cpp: 9 (WebKit::WebFrame::deliverIntent): 10 (WebKit::WebFrame::pendingUnloadCount): 11 1 12 2012-08-14 Lauro Neto <lauro.neto@openbossa.org> 2 13 -
trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp
r121381 r125615 252 252 SerializedScriptValue::adopt(dataCopy), dummyPorts.release(), 253 253 intentData.extras); 254 WebCore::DOMWindowIntents::from(m_coreFrame->do mWindow())->deliver(deliveredIntent.release());254 WebCore::DOMWindowIntents::from(m_coreFrame->document()->domWindow())->deliver(deliveredIntent.release()); 255 255 } 256 256 #endif … … 494 494 return 0; 495 495 496 return m_coreFrame->do mWindow()->pendingUnloadEventListeners();496 return m_coreFrame->document()->domWindow()->pendingUnloadEventListeners(); 497 497 } 498 498
Note: See TracChangeset
for help on using the changeset viewer.