Changeset 125624 in webkit

Timestamp:

Aug 14, 2012 5:10:36 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Clear pattern to prevent timing problem between cancelVibration and vibrate
​https://bugs.webkit.org/show_bug.cgi?id=93957

Patch by Kihong Kwon <​kihong.kwon@samsung.com> on 2012-08-14
Reviewed by Kentaro Hara.

There is a timing issue in the cancelVibration.
Since vibrate works based on timer, cancelVibration might be called
eariler than vibrate when cancelVibration is called just after vibrate call.
It can be prevented from clearing m_pattern in the cancelVibration.

• Modules/vibration/Vibration.cpp:

(WebCore::Vibration::cancelVibration):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/vibration/Vibration.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-08-14  Kihong Kwon  <kihong.kwon@samsung.com>
+
+        Clear pattern to prevent timing problem between cancelVibration and vibrate
+        https://bugs.webkit.org/show_bug.cgi?id=93957
+
+        Reviewed by Kentaro Hara.
+
+        There is a timing issue in the cancelVibration.
+        Since vibrate works based on timer, cancelVibration might be called
+        eariler than vibrate when cancelVibration is called just after vibrate call.
+        It can be prevented from clearing m_pattern in the cancelVibration.
+
+        * Modules/vibration/Vibration.cpp:
+        (WebCore::Vibration::cancelVibration):
+
 2012-08-14  Alexandru Chiculita  <achicu@adobe.com>
 

trunk/Source/WebCore/Modules/vibration/Vibration.cpp

@@ -74 +74 @@
 void Vibration::cancelVibration()
 {
+    m_pattern.clear();
     if (m_isVibrating) {
         m_vibrationClient->cancelVibration();