Changeset 125696 in webkit


Ignore:
Timestamp:
Aug 15, 2012 12:36:46 PM (12 years ago)
Author:
jsbell@chromium.org
Message:

[chromium] IndexedDB: Delete unused WebKit API cursor accessors
​https://bugs.webkit.org/show_bug.cgi?id=94134

Reviewed by Adam Barth.

Last bit of refactor work from ​http://webkit.org/b/92278 that ships the
cursor key/primaryKey/value to the front end via success messages, eliminating
the need for these accessors and the old success messages.

  • public/WebIDBCallbacks.h:
  • public/WebIDBCursor.h:
Location:
trunk/Source/WebKit/chromium
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/chromium/ChangeLog

    r125682 r125696  
     12012-08-15  Joshua Bell  <jsbell@chromium.org>
     2
     3        [chromium] IndexedDB: Delete unused WebKit API cursor accessors
     4        https://bugs.webkit.org/show_bug.cgi?id=94134
     5
     6        Reviewed by Adam Barth.
     7
     8        Last bit of refactor work from http://webkit.org/b/92278 that ships the
     9        cursor key/primaryKey/value to the front end via success messages, eliminating
     10        the need for these accessors and the old success messages.
     11
     12        * public/WebIDBCallbacks.h:
     13        * public/WebIDBCursor.h:
     14
    1152012-08-15  Anna Cavender  <annacc@chromium.org>
    216

  • trunk/Source/WebKit/chromium/public/WebIDBCallbacks.h

    r125568 r125696  
    5151    virtual void onError(const WebIDBDatabaseError&) { WEBKIT_ASSERT_NOT_REACHED(); }
    5252    virtual void onSuccess(const WebDOMStringList&) { WEBKIT_ASSERT_NOT_REACHED(); }
    53     // FIXME: Remove this no-op method when callers are updated.
    54     virtual void onSuccess(WebIDBCursor*) { }
    5553    virtual void onSuccess(WebIDBCursor*, const WebIDBKey& key, const WebIDBKey& primaryKey, const WebSerializedScriptValue&) { WEBKIT_ASSERT_NOT_REACHED(); }
    5654    virtual void onSuccess(WebIDBDatabase*) { WEBKIT_ASSERT_NOT_REACHED(); }
    … …  
    5957    virtual void onSuccess(const WebSerializedScriptValue&) { WEBKIT_ASSERT_NOT_REACHED(); }
    6058    virtual void onSuccess(const WebSerializedScriptValue&, const WebIDBKey&, const WebIDBKeyPath&) { WEBKIT_ASSERT_NOT_REACHED(); }
    61     // FIXME: Remove this no-op method when callers are updated.
    62     virtual void onSuccessWithContinuation() { }
    6359    virtual void onSuccess(const WebIDBKey& key, const WebIDBKey& primaryKey, const WebSerializedScriptValue&) { WEBKIT_ASSERT_NOT_REACHED(); }
    6460    virtual void onBlocked() { WEBKIT_ASSERT_NOT_REACHED(); }

  • trunk/Source/WebKit/chromium/public/WebIDBCursor.h

    r125568 r125696  
    4848    };
    4949
    50     // FIXME: Remove these methods when callers are updated.
    51     virtual WebIDBKey key() const
    52     {
    53         WEBKIT_ASSERT_NOT_REACHED();
    54         return WebIDBKey::createInvalid();
    55     }
    56     virtual WebIDBKey primaryKey() const
    57     {
    58         WEBKIT_ASSERT_NOT_REACHED();
    59         return WebIDBKey::createInvalid();
    60     }
    61     virtual WebSerializedScriptValue value() const
    62     {
    63         WEBKIT_ASSERT_NOT_REACHED();
    64         return WebSerializedScriptValue();
    65     }
    66 
    6750    virtual void advance(unsigned long, WebIDBCallbacks*, WebExceptionCode&) { WEBKIT_ASSERT_NOT_REACHED(); }
    6851    virtual void continueFunction(const WebIDBKey&, WebIDBCallbacks*, WebExceptionCode&) { WEBKIT_ASSERT_NOT_REACHED(); }
Note: See TracChangeset for help on using the changeset viewer.