Changeset 126021 in webkit

Timestamp:

Aug 20, 2012 5:25:57 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK] Provide backwards compatible method for WebKitDOMWebKitNamedFlow::overflow
​https://bugs.webkit.org/show_bug.cgi?id=94464

Patch by Xan Lopez <​xlopez@igalia.com> on 2012-08-20
Reviewed by Carlos Garcia Campos.

Provide a compatibility method to access the new 'overset'
property through the old 'overflow' name in
WebKitDOMWebKitNamedFlow. Note that trying to access it through
g_object_get directly will give a runtime warning, since the
property does not actually exist anymore; this is done purely to
maintain API compatibility.

• bindings/gobject/WebKitDOMCustom.cpp:

(webkit_dom_webkit_named_flow_get_overflow): add method.

• bindings/gobject/WebKitDOMCustom.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/gobject/WebKitDOMCustom.cpp (modified) (2 diffs)
• bindings/gobject/WebKitDOMCustom.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-08-20  Xan Lopez  <xlopez@igalia.com>
+
+        [GTK] Provide backwards compatible method for WebKitDOMWebKitNamedFlow::overflow
+        https://bugs.webkit.org/show_bug.cgi?id=94464
+
+        Reviewed by Carlos Garcia Campos.
+
+        Provide a compatibility method to access the new 'overset'
+        property through the old 'overflow' name in
+        WebKitDOMWebKitNamedFlow. Note that trying to access it through
+        g_object_get directly will give a runtime warning, since the
+        property does not actually exist anymore; this is done purely to
+        maintain API compatibility.
+
+        * bindings/gobject/WebKitDOMCustom.cpp:
+        (webkit_dom_webkit_named_flow_get_overflow): add method.
+        * bindings/gobject/WebKitDOMCustom.h:
+
 2012-08-20  Sami Kyostila  <skyostil@chromium.org>
 

trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp

@@ -26 +26 @@
 #include "WebKitDOMHTMLTextAreaElement.h"
 #include "WebKitDOMHTMLTextAreaElementPrivate.h"
+#include "WebKitDOMWebKitNamedFlow.h"
 
 using namespace WebKit;
@@ -62 +63 @@
 }
 
+gboolean
+webkit_dom_webkit_named_flow_get_overflow(WebKitDOMWebKitNamedFlow* flow)
+{
+    g_warning("The WebKitDOMWebKitNamedFlow::overflow property has been renamed to WebKitDOMWebKitNamedFlow::overset. Please update your code to use the new name.");
+    return webkit_dom_webkit_named_flow_get_overset(flow);
+}
+
 void
 webkit_dom_html_form_element_dispatch_form_change(WebKitDOMHTMLFormElement* self)

trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.h

@@ -36 +36 @@
 WEBKIT_API void webkit_dom_html_form_element_dispatch_form_change(WebKitDOMHTMLFormElement* self);
 WEBKIT_API void webkit_dom_html_form_element_dispatch_form_input(WebKitDOMHTMLFormElement* self);
+WEBKIT_API gboolean webkit_dom_webkit_named_flow_get_overflow(WebKitDOMWebKitNamedFlow* flow);
 
 G_END_DECLS