Changeset 126031 in webkit

Timestamp:

Aug 20, 2012 8:18:17 AM (12 years ago)

Author:

allan.jensen@nokia.com

Message:

[Qt] Custom tap-highlight-color renders fully opaque
​https://bugs.webkit.org/show_bug.cgi?id=94468

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Adjust the default tap-highlight-color to figure in that is will be
drawn semi-transparent.

• rendering/RenderTheme.h:

(RenderTheme):

Source/WebKit2:

Draw tap-highlight-color at 50% transparency, to better match how
existing WebKit browsers act on custom tap-highlight colors.

• WebProcess/WebPage/TapHighlightController.cpp:

(WebKit::TapHighlightController::drawRect):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/RenderTheme.h (modified) (1 diff)
• WebKit2/ChangeLog (modified) (1 diff)
• WebKit2/WebProcess/WebPage/TapHighlightController.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-08-20  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
+
+        [Qt] Custom tap-highlight-color renders fully opaque
+        https://bugs.webkit.org/show_bug.cgi?id=94468
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Adjust the default tap-highlight-color to figure in that is will be
+        drawn semi-transparent.
+
+        * rendering/RenderTheme.h:
+        (RenderTheme):
+
 2012-08-20  Andrey Adaikin  <aandrey@chromium.org>
 

trunk/Source/WebCore/rendering/RenderTheme.h

@@ -366 +366 @@
 
 #if ENABLE(TOUCH_EVENTS)
-    static const RGBA32 defaultTapHighlightColor = 0x33000000;
+    // This color is expected to be drawn on a semi-transparent overlay,
+    // making it more transparent than its alpha value indicates.
+    static const RGBA32 defaultTapHighlightColor = 0x66000000;
 #endif
 

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2012-08-20  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
+
+        [Qt] Custom tap-highlight-color renders fully opaque
+        https://bugs.webkit.org/show_bug.cgi?id=94468
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Draw tap-highlight-color at 50% transparency, to better match how
+        existing WebKit browsers act on custom tap-highlight colors.
+
+        * WebProcess/WebPage/TapHighlightController.cpp:
+        (WebKit::TapHighlightController::drawRect):
+
 2012-08-20  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit2/WebProcess/WebPage/TapHighlightController.cpp

@@ -106 +106 @@
         GraphicsContextStateSaver stateSaver(context);
         if (m_webPage->drawingArea()->pageOverlayShouldApplyFadeWhenPainting())
-            context.setFillColor(highlightColor(m_color, pageOverlay->fractionFadedIn()), ColorSpaceSRGB);
+            context.setFillColor(highlightColor(m_color, pageOverlay->fractionFadedIn() * 0.5f), ColorSpaceSRGB);
         else
-            context.setFillColor(m_color, ColorSpaceSRGB);
+            context.setFillColor(highlightColor(m_color, 0.5f), ColorSpaceSRGB);
         context.fillPath(m_path);
     }