Changeset 126057 in webkit

Timestamp:

Aug 20, 2012 12:53:44 PM (12 years ago)

Author:

hans@chromium.org

Message:

Respect runtime flags for Device Orientation and Device Motion
​https://bugs.webkit.org/show_bug.cgi?id=94479

Reviewed by Adam Barth.

Source/WebCore:

There are flags that allows disabling of device orientation and device
motion at runtime. These flags determine the availability of the
corresponding event constructors in DOMWindow.

However, the flags should also control the ability to add event
listeners for these events, otherwise the feature can be used even if
it is disabled.

• page/DOMWindow.cpp:

(WebCore::DOMWindow::addEventListener):

Source/WebKit/chromium:

WebRuntimeFeatures::enableDeviceMotion should not be hard-coded to
false.

• src/WebViewImpl.cpp:

(WebKit::WebView::create):

Location:

trunk

Files:

• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/page/DOMWindow.cpp (modified) (1 diff)
• Source/WebKit/chromium/ChangeLog (modified) (1 diff)
• Source/WebKit/chromium/src/WebViewImpl.cpp (modified) (1 diff)
• Tools/DumpRenderTree/chromium/TestShell.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-08-20  Hans Wennborg  <hans@chromium.org>
+
+        Respect runtime flags for Device Orientation and Device Motion
+        https://bugs.webkit.org/show_bug.cgi?id=94479
+
+        Reviewed by Adam Barth.
+
+        There are flags that allows disabling of device orientation and device
+        motion at runtime. These flags determine the availability of the
+        corresponding event constructors in DOMWindow.
+
+        However, the flags should also control the ability to add event
+        listeners for these events, otherwise the feature can be used even if
+        it is disabled.
+
+        * page/DOMWindow.cpp:
+        (WebCore::DOMWindow::addEventListener):
+
 2012-08-20  Philip Rogers  <pdr@google.com>
 

trunk/Source/WebCore/page/DOMWindow.cpp

@@ -1577 +1577 @@
         addBeforeUnloadEventListener(this);
 #if ENABLE(DEVICE_ORIENTATION)
-    else if (eventType == eventNames().devicemotionEvent) {
+    else if (eventType == eventNames().devicemotionEvent && RuntimeEnabledFeatures::deviceMotionEnabled()) {
         if (DeviceMotionController* controller = DeviceMotionController::from(page()))
             controller->addListener(this);
-    } else if (eventType == eventNames().deviceorientationEvent) {
+    } else if (eventType == eventNames().deviceorientationEvent && RuntimeEnabledFeatures::deviceOrientationEnabled()) {
         if (DeviceOrientationController* controller = DeviceOrientationController::from(page()))
             controller->addListener(this);

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2012-08-20  Hans Wennborg  <hans@chromium.org>
+
+        Respect runtime flags for Device Orientation and Device Motion
+        https://bugs.webkit.org/show_bug.cgi?id=94479
+
+        Reviewed by Adam Barth.
+
+        WebRuntimeFeatures::enableDeviceMotion should not be hard-coded to
+        false.
+
+        * src/WebViewImpl.cpp:
+        (WebKit::WebView::create):
+
 2012-08-20  David Reveman  <reveman@chromium.org>
 

trunk/Source/WebKit/chromium/src/WebViewImpl.cpp

@@ -267 +267 @@
 WebView* WebView::create(WebViewClient* client)
 {
-    // Keep runtime flag for device motion turned off until it's implemented.
-    WebRuntimeFeatures::enableDeviceMotion(false);
-
     // Pass the WebViewImpl's self-reference to the caller.
     return adoptRef(new WebViewImpl(client)).leakRef();

trunk/Tools/DumpRenderTree/chromium/TestShell.cpp

@@ -120 +120 @@
 {
     WebRuntimeFeatures::enableDataTransferItems(true);
+    WebRuntimeFeatures::enableDeviceMotion(false);
     WebRuntimeFeatures::enableGeolocation(true);
     WebRuntimeFeatures::enablePointerLock(true);