Changeset 126116 in webkit

Timestamp:

Aug 20, 2012 6:50:14 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Cancel the outstanding vibration pattern if the pattern is 0 or an empty list
​https://bugs.webkit.org/show_bug.cgi?id=94085

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-08-20
Reviewed by Kentaro Hara.

vibrate() method to stop the device from vibrating is getting called before the
vibration is in effect. Hence, it is failing to cancel the pre-existing instance
of processing vibration patterns.

This patch cancel the pre-existing instance of the processing vibration patterns
always when the vibrate() method called with pattern 0 or an empty list.

No new tests since there is no return value in the Vibration API to test this
particular case. Existing test fast/dom/navigator-vibration.html covers testing of
the Vibration API.

• Modules/vibration/Vibration.cpp:

(WebCore::Vibration::vibrate):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/vibration/Vibration.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-08-20  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
+
+        Cancel the outstanding vibration pattern if the pattern is 0 or an empty list
+        https://bugs.webkit.org/show_bug.cgi?id=94085
+
+        Reviewed by Kentaro Hara.
+
+        vibrate() method to stop the device from vibrating is getting called before the
+        vibration is in effect. Hence, it is failing to cancel the pre-existing instance
+        of processing vibration patterns. 
+
+        This patch cancel the pre-existing instance of the processing vibration patterns
+        always when the vibrate() method called with pattern 0 or an empty list.
+
+        No new tests since there is no return value in the Vibration API to test this
+        particular case. Existing test fast/dom/navigator-vibration.html covers testing of
+        the Vibration API.
+
+        * Modules/vibration/Vibration.cpp:
+        (WebCore::Vibration::vibrate):
+
 2012-08-20  Adam Klein  <adamk@chromium.org>
 

trunk/Source/WebCore/Modules/vibration/Vibration.cpp

@@ -59 +59 @@
     int length = pattern.size();
 
+    // Cancel the pre-existing instance of vibration patterns, if the pattern is 0 or an empty list.
+    if (!length || (length == 1 && !pattern[0])) {
+        cancelVibration();
+        return;
+    }
+
     if (m_isVibrating)
         cancelVibration();
-
-    if (!length || (length == 1 && !pattern[0]))
-        return;
 
     if (m_timerStart.isActive())