Changeset 126166 in webkit

Timestamp:

Aug 21, 2012 10:02:28 AM (12 years ago)

Author:

tonikitoo@webkit.org

Message:

[BlackBerry] Properly notify WebKit when Client stops in-region scrolling
​https://bugs.webkit.org/show_bug.cgi?id=94603
PR #195813

Reviewed by Goerge Staikos.
Patch by Antonio Gomes <​agomes@rim.com>

Simplify the API to get a notification of when a in-region
scrolling has finished.

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::notifyInRegionScrollStopped):
Removed an unneeded parameter.
(BlackBerry::WebKit::WebPage::notifyInRegionScrollStopped):
Ditto.

• Api/WebPage.h:
• Api/WebPage_p.h:

(WebPagePrivate):

Location:

trunk/Source/WebKit/blackberry

Files:

• Api/WebPage.cpp (modified) (2 diffs)
• Api/WebPage.h (modified) (1 diff)
• Api/WebPage_p.h (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Source/WebKit/blackberry/Api/WebPage.cpp

@@ -1498 +1498 @@
 }
 
-void WebPagePrivate::notifyInRegionScrollStatusChanged(bool status)
-{
-    if (!status && m_inRegionScroller->d->hasNode()) {
+void WebPagePrivate::notifyInRegionScrollStopped()
+{
+    if (m_inRegionScroller->d->hasNode()) {
         enqueueRenderingOfClippedContentOfScrollableNodeAfterInRegionScrolling(m_inRegionScroller->d->node());
         m_inRegionScroller->d->reset();
@@ -1506 +1506 @@
 }
 
-void WebPage::notifyInRegionScrollStatusChanged(bool status)
-{
-    d->notifyInRegionScrollStatusChanged(status);
+void WebPage::notifyInRegionScrollStopped()
+{
+    d->notifyInRegionScrollStopped();
 }
 

trunk/Source/WebKit/blackberry/Api/WebPage.h

@@ -177 +177 @@
     void setScrollPosition(const Platform::IntPoint&);
     bool scrollBy(const Platform::IntSize&, bool scrollMainFrame = true);
-    void notifyInRegionScrollStatusChanged(bool status);
+    void notifyInRegionScrollStopped();
     void setScrollOriginPoint(const Platform::IntPoint&);
 

trunk/Source/WebKit/blackberry/Api/WebPage_p.h

@@ -151 +151 @@
 
     void enqueueRenderingOfClippedContentOfScrollableNodeAfterInRegionScrolling(WebCore::Node*);
-    void notifyInRegionScrollStatusChanged(bool status);
+    void notifyInRegionScrollStopped();
     void setScrollOriginPoint(const Platform::IntPoint&);
     void setHasInRegionScrollableAreas(bool);

trunk/Source/WebKit/blackberry/ChangeLog

@@ +1 @@
+2012-08-21  Antonio Gomes  <agomes@rim.com>
+
+        [BlackBerry] Properly notify WebKit when Client stops in-region scrolling
+        https://bugs.webkit.org/show_bug.cgi?id=94603
+        PR #195813
+
+        Reviewed by Goerge Staikos.
+
+        Simplify the API to get a notification of when a in-region
+        scrolling has finished.
+
+        * Api/WebPage.cpp:
+        (BlackBerry::WebKit::WebPagePrivate::notifyInRegionScrollStopped):
+        Removed an unneeded parameter.
+        (BlackBerry::WebKit::WebPage::notifyInRegionScrollStopped):
+        Ditto.
+        * Api/WebPage.h:
+        * Api/WebPage_p.h:
+        (WebPagePrivate):
+
 2012-08-20  Sean Wang  <Xuewen.Wang@torchmobile.com.cn>