Changeset 126193 in webkit

Timestamp:

Aug 21, 2012 3:05:33 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Split out crumb list part of styles from elementsPanel.css
​https://bugs.webkit.org/show_bug.cgi?id=94301

Patch by Taiju Tsuiki <​tzik@chromium.org> on 2012-08-21
Reviewed by Pavel Feldman.

As a preparation to use BreadcrumbList on FileSystem, introduce breadcrumbList.css and
move crumb-related style entries into it from elementsPanel.css.

No new tests. This change does not make functional change.

• WebCore.gypi:
• WebCore.vcproj/WebCore.vcproj:
• inspector/front-end/ElementsPanel.js:
• inspector/front-end/WebKit.qrc:
• inspector/front-end/breadcrumbList.css: Added.

(.crumbs):
(.crumbs .crumb):
(.crumbs .crumb.collapsed > *):
(.crumbs .crumb.collapsed::before):
(.crumbs .crumb.compact .extra):
(.crumbs .crumb.dimmed):
(.crumbs .crumb.start):
(.crumbs .crumb.end):
(.crumbs .crumb.selected):
(.crumbs .crumb.selected:hover):
(.crumbs .crumb.selected.end, .crumbs .crumb.selected.end:hover):
(.crumbs .crumb:hover):
(.crumbs .crumb.dimmed:hover):
(.crumbs .crumb.end:hover):

• inspector/front-end/elementsPanel.css:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• WebCore.gypi (modified) (1 diff)
• WebCore.vcproj/WebCore.vcproj (modified) (1 diff)
• inspector/front-end/ElementsPanel.js (modified) (1 diff)
• inspector/front-end/WebKit.qrc (modified) (1 diff)
• inspector/front-end/breadcrumbList.css (added)
• inspector/front-end/elementsPanel.css (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-08-21  Taiju Tsuiki  <tzik@chromium.org>
+
+        Web Inspector: Split out crumb list part of styles from elementsPanel.css
+        https://bugs.webkit.org/show_bug.cgi?id=94301
+
+        Reviewed by Pavel Feldman.
+
+        As a preparation to use BreadcrumbList on FileSystem, introduce breadcrumbList.css and
+        move crumb-related style entries into it from elementsPanel.css.
+
+        No new tests. This change does not make functional change.
+
+        * WebCore.gypi:
+        * WebCore.vcproj/WebCore.vcproj:
+        * inspector/front-end/ElementsPanel.js:
+        * inspector/front-end/WebKit.qrc:
+        * inspector/front-end/breadcrumbList.css: Added.
+        (.crumbs):
+        (.crumbs .crumb):
+        (.crumbs .crumb.collapsed > *):
+        (.crumbs .crumb.collapsed::before):
+        (.crumbs .crumb.compact .extra):
+        (.crumbs .crumb.dimmed):
+        (.crumbs .crumb.start):
+        (.crumbs .crumb.end):
+        (.crumbs .crumb.selected):
+        (.crumbs .crumb.selected:hover):
+        (.crumbs .crumb.selected.end, .crumbs .crumb.selected.end:hover):
+        (.crumbs .crumb:hover):
+        (.crumbs .crumb.dimmed:hover):
+        (.crumbs .crumb.end:hover):
+        * inspector/front-end/elementsPanel.css:
+
 2012-08-21  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
 

trunk/Source/WebCore/WebCore.gypi

@@ -6392 +6392 @@
         'webinspector_standalone_css_files': [
             'inspector/front-end/auditsPanel.css',
+            'inspector/front-end/breadcrumbList.css',
             'inspector/front-end/cm/codemirror.css',
             'inspector/front-end/cmdevtools.css',

trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj

@@ -75583 +75583 @@
                                 </File>
                                 <File
+                                        RelativePath="..\inspector\front-end\breadcrumbList.css"
+                                        >
+                                </File>
+                                <File
                                         RelativePath="..\inspector\front-end\BreakpointManager.js"
                                         >

trunk/Source/WebCore/inspector/front-end/ElementsPanel.js

@@ -41 +41 @@
 {
     WebInspector.Panel.call(this, "elements");
+    this.registerRequiredCSS("breadcrumbList.css");
     this.registerRequiredCSS("elementsPanel.css");
     this.registerRequiredCSS("textPrompt.css");

trunk/Source/WebCore/inspector/front-end/WebKit.qrc

@@ -208 +208 @@
     <file>UglifyJS/parse-js.js</file>
     <file>auditsPanel.css</file>
+    <file>breadcrumbList.css</file>
     <file>dataGrid.css</file>
     <file>cmdevtools.css</file>

trunk/Source/WebCore/inspector/front-end/elementsPanel.css

@@ -60 +60 @@
 }
 
-.crumbs {
-    display: inline-block;
-    pointer-events: auto;
-    cursor: default;
-    font-size: 11px;
-    line-height: 19px;
-    text-shadow: rgba(255, 255, 255, 0.75) 0 1px 0;
-    color: rgb(20, 20, 20);
-    margin-left: -1px;
-    margin-top: -1px;
-    padding-right: 12px;
-}
-
-.crumbs .crumb {
-    height: 24px;
-    border-width: 0 12px 0 2px;
-    -webkit-border-image: url(Images/segment.png) 0 12 0 2;
-    margin-right: -12px;
-    padding-left: 18px;
-    padding-right: 2px;
-    white-space: nowrap;
-    line-height: 23px;
-    float: right;
-}
-
-.crumbs .crumb.collapsed > * {
-    display: none;
-}
-
-.crumbs .crumb.collapsed::before {
-    content: "\2026";
-    font-weight: bold;
-}
-
-.crumbs .crumb.compact .extra {
-    display: none;
-}
-
-.crumbs .crumb.dimmed {
-    color: rgba(0, 0, 0, 0.45);
-}
-
-.crumbs .crumb.start {
-    padding-left: 7px;
-}
-
-.crumbs .crumb.end {
-    border-width: 0 2px 0 2px;
-    padding-right: 6px;
-    -webkit-border-image: url(Images/segmentEnd.png) 0 2 0 2;
-}
-
-.crumbs .crumb.selected {
-    -webkit-border-image: url(Images/segmentSelected.png) 0 12 0 2;
-    color: black;
-    text-shadow: rgba(255, 255, 255, 0.5) 0 1px 0;
-}
-
-.crumbs .crumb.selected:hover {
-    -webkit-border-image: url(Images/segmentSelected.png) 0 12 0 2;
-}
-
-.crumbs .crumb.selected.end, .crumbs .crumb.selected.end:hover {
-    -webkit-border-image: url(Images/segmentSelectedEnd.png) 0 2 0 2;
-}
-
-.crumbs .crumb:hover {
-    -webkit-border-image: url(Images/segmentHover.png) 0 12 0 2;
-    color: black;
-}
-
-.crumbs .crumb.dimmed:hover {
-    -webkit-border-image: url(Images/segmentHover.png) 0 12 0 2;
-    color: rgba(0, 0, 0, 0.75);
-}
-
-.crumbs .crumb.end:hover {
-    -webkit-border-image: url(Images/segmentHoverEnd.png) 0 2 0 2;
-}
-
 .metrics {
     padding: 8px;