Changeset 126201 in webkit

Timestamp:

Aug 21, 2012 3:51:54 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Track -webkit property usage.
​https://bugs.webkit.org/show_bug.cgi?id=93420

Patch by Tab Atkins <​tabatkins@google.com> on 2012-08-21
Reviewed by Ojan Vafai.

First draft of an attempt to track all usage of -webkit prefixed properties across the web.
This attempt is dumb, but should provide useful data as a first-pass.
I plan to optimize this for better data collection in the future.

No tests added, as this is untestable currently.
It should have zero effect besides histogramming.

• css/CSSParser.cpp:

(WebCore::cssPropertyID):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/CSSParser.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-08-21  Tab Atkins  <tabatkins@google.com>
+
+        Track -webkit property usage.
+        https://bugs.webkit.org/show_bug.cgi?id=93420
+
+        Reviewed by Ojan Vafai.
+
+        First draft of an attempt to track all usage of -webkit prefixed properties across the web.
+        This attempt is dumb, but should provide useful data as a first-pass.
+        I plan to optimize this for better data collection in the future.
+
+        No tests added, as this is untestable currently.
+        It should have zero effect besides histogramming.
+
+        * css/CSSParser.cpp:
+        (WebCore::cssPropertyID):
+
 2012-08-21  Alec Flett  <alecflett@chromium.org>
 

trunk/Source/WebCore/css/CSSParser.cpp

@@ -63 +63 @@
 #include "HTMLParserIdioms.h"
 #include "HashTools.h"
+#include "HistogramSupport.h"
 #include "MediaList.h"
 #include "MediaQueryExp.h"
@@ -10125 +10126 @@
 
     const Property* hashTableEntry = findProperty(name, length);
-    return hashTableEntry ? static_cast<CSSPropertyID>(hashTableEntry->id) : CSSPropertyInvalid;
+    const CSSPropertyID propertyID = hashTableEntry ? static_cast<CSSPropertyID>(hashTableEntry->id) : CSSPropertyInvalid;
+
+    // 600 is comfortably larger than numCSSProperties to allow for growth
+    static const int CSSPropertyHistogramSize = 600;
+    COMPILE_ASSERT(CSSPropertyHistogramSize > numCSSProperties, number_of_css_properties_exceed_CSSPropertyHistogramSize);
+
+    if (hasPrefix(buffer, length, "-webkit-") && propertyID != CSSPropertyInvalid)
+        HistogramSupport::histogramEnumeration("CSS.PrefixUsage", max(1, propertyID - firstCSSProperty), CSSPropertyHistogramSize);
+
+    return propertyID;
 }