Changeset 126252 in webkit


Ignore:
Timestamp:
Aug 21, 2012 7:17:33 PM (12 years ago)
Author:
keishi@webkit.org
Message:

range-hit-test-with-padding.html fails unless subpixel layout is on
​https://bugs.webkit.org/show_bug.cgi?id=94585

Reviewed by Kent Tamura.

Ports without subpixel layout didn't exactly match the result, because slider thumb width is an odd number and we are dividing it by two.

  • fast/forms/range/range-hit-test-with-padding-expected.txt:
  • fast/forms/range/range-hit-test-with-padding.html: Adjust the max so it snaps to the step in the middle.
Location:
trunk/LayoutTests
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r126251 r126252  
     12012-08-21  Keishi Hattori  <keishi@webkit.org>
     2
     3        range-hit-test-with-padding.html fails unless subpixel layout is on
     4        https://bugs.webkit.org/show_bug.cgi?id=94585
     5
     6        Reviewed by Kent Tamura.
     7
     8        Ports without subpixel layout didn't exactly match the result, because slider thumb width is an odd number and we are dividing it by two.
     9
     10        * fast/forms/range/range-hit-test-with-padding-expected.txt:
     11        * fast/forms/range/range-hit-test-with-padding.html: Adjust the max so it snaps to the step in the middle.
     12
    1132012-08-21  Julien Chaffraix  <jchaffraix@webkit.org>
    214

  • trunk/LayoutTests/fast/forms/range/range-hit-test-with-padding-expected.txt

    r126132 r126252  
    11Clicking middle of input type=range with padding should set the value to middle.
    22
    3 PASS input.value is "500"
     3PASS input.value is "25"
    44PASS successfullyParsed is true
    55

  • trunk/LayoutTests/fast/forms/range/range-hit-test-with-padding.html

    r126151 r126252  
    77<p id="description">Clicking middle of input type=range with padding should set the value to middle.</p>
    88<div id="console"></div>
    9 <input id="input" type=range min=0 max=1000 step=1 value="0" style="width: 100px; padding: 0 20px;">
     9<input id="input" type=range min=0 max=50 step=1 value="0" style="width: 100px; padding: 0 40px;">
    1010<script>
    1111var input = document.getElementById("input");
    … …  
    1717}
    1818
    19 clickSlider(70); // left padding (20px) + middle (50px)
    20 shouldBe('input.value', '"500"');
     19clickSlider(90); // left padding (40px) + middle (50px)
     20shouldBe('input.value', '"25"');
    2121
    2222</script>
Note: See TracChangeset for help on using the changeset viewer.