Changeset 126276 in webkit

Timestamp:

Aug 22, 2012 1:42:57 AM (12 years ago)

Author:

caseq@chromium.org

Message:

Web Inspector: console.time() should use performance.now()
​https://bugs.webkit.org/show_bug.cgi?id=94263

Reviewed by Pavel Feldman.

• use monotonicallyIncreasingTime() instead of currentTime() for measuring time intervals

with console.time()/console.timeEnd()

• adjust precision to 3 digits after decimal point (i.e. microseconds) when formatting intervals;

• inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::stopTiming):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/InspectorConsoleAgent.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-08-21  Andrey Kosyakov  <caseq@chromium.org>
+
+        Web Inspector: console.time() should use performance.now()
+        https://bugs.webkit.org/show_bug.cgi?id=94263
+
+        Reviewed by Pavel Feldman.
+
+        - use monotonicallyIncreasingTime() instead of currentTime() for measuring time intervals
+            with console.time()/console.timeEnd()
+        - adjust precision to 3 digits after decimal point (i.e. microseconds) when formatting intervals;
+
+        * inspector/InspectorConsoleAgent.cpp:
+        (WebCore::InspectorConsoleAgent::stopTiming):
+
 2012-08-22  Takashi Sakamoto  <tasak@google.com>
 

trunk/Source/WebCore/inspector/InspectorConsoleAgent.cpp

@@ -164 +164 @@
         return;
 
-    m_times.add(title, currentTime() * 1000);
+    m_times.add(title, monotonicallyIncreasingTime());
 }
 
@@ -181 +181 @@
     m_times.remove(it);
 
-    double elapsed = currentTime() * 1000 - startTime;
-    String message = title + String::format(": %.0fms", elapsed);
+    double elapsed = monotonicallyIncreasingTime() - startTime;
+    String message = title + String::format(": %.3fms", elapsed * 1000);
     const ScriptCallFrame& lastCaller = callStack->at(0);
     addMessageToConsole(JSMessageSource, LogMessageType, LogMessageLevel, message, lastCaller.sourceURL(), lastCaller.lineNumber());