Changeset 126288 in webkit


Ignore:
Timestamp:
Aug 22, 2012 3:59:39 AM (12 years ago)
Author:
shinyak@chromium.org
Message:

Test and test expectation of Shadow DOM for button should be fixed.
https://bugs.webkit.org/show_bug.cgi?id=94674

Reviewed by Hajime Morita.

Now that the HTMLButtonElement was AuthroShadowDOM-ready, it's time to update the previous
failing tests for AuthroShadowDOM for button elements.

I've updated the failing tests to follow the current implementation and updated the test expectations.

  • fast/dom/shadow/shadowdom-for-button-complex-shadow-expected.html:
  • fast/dom/shadow/shadowdom-for-button-complex-shadow.html:
  • fast/dom/shadow/shadowdom-for-button-only-shadow-expected.html:
  • fast/dom/shadow/shadowdom-for-button-only-shadow.html:
  • fast/dom/shadow/shadowdom-for-button-without-shadow-expected.html:
  • fast/dom/shadow/shadowdom-for-button-without-shadow.html:
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
Location:
trunk/LayoutTests
Files:
9 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r126287 r126288  
     12012-08-22  Shinya Kawanaka  <shinyak@chromium.org>
     2
     3        Test and test expectation of Shadow DOM for button should be fixed.
     4        https://bugs.webkit.org/show_bug.cgi?id=94674
     5
     6        Reviewed by Hajime Morita.
     7
     8        Now that the HTMLButtonElement was AuthroShadowDOM-ready, it's time to update the previous
     9        failing tests for AuthroShadowDOM for button elements.
     10
     11        I've updated the failing tests to follow the current implementation and updated the test expectations.
     12
     13        * fast/dom/shadow/shadowdom-for-button-complex-shadow-expected.html:
     14        * fast/dom/shadow/shadowdom-for-button-complex-shadow.html:
     15        * fast/dom/shadow/shadowdom-for-button-only-shadow-expected.html:
     16        * fast/dom/shadow/shadowdom-for-button-only-shadow.html:
     17        * fast/dom/shadow/shadowdom-for-button-without-shadow-expected.html:
     18        * fast/dom/shadow/shadowdom-for-button-without-shadow.html:
     19        * platform/chromium/TestExpectations:
     20        * platform/efl/TestExpectations:
     21
    1222012-08-22  Simon Hausmann  <simon.hausmann@nokia.com>
    223
  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-button-complex-shadow-expected.html

    r123713 r126288  
    11<!DOCTYPE html>
     2<html>
     3<body>
    24<script src="resources/polyfill.js"></script>
    35
    46<p>A mixed case of a shadow element and content element.</p>
    57<form>
    6     button<div style="margin: 20px">
    7         <button></button>
    8     </div>   
    9     <input id="submit" type="submit" value="Submit">
     8    <button><span>button 2</span>button 1</button>
    109</form>
     10
     11</body>
     12</html>
  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-button-complex-shadow.html

    r123713 r126288  
    11<!DOCTYPE html>
     2<html>
     3<body>
    24<script src="resources/polyfill.js"></script>
    35
    46<p>A mixed case of a shadow element and content element.</p>
    57<form>
    6     <button id="host">button</button>
    7     <input id="submit" type="submit" value="Submit">
     8    <button id="host">button 1<span>button 2</span></button>
    89</form>
    910
     
    1112var host = document.getElementById('host');
    1213var shadowRoot = new WebKitShadowRoot(host);
    13 shadowRoot.innerHTML = "<content></content><div style='margin: 20px'><shadow></shadow></div>"
     14shadowRoot.innerHTML = '<div><content select="span"></content><shadow></shadow></div>'
    1415</script>
     16
     17</body>
     18</html>
  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-button-only-shadow-expected.html

    r123713 r126288  
    11<!DOCTYPE html>
     2<html>
     3<body>
    24<script src="resources/polyfill.js"></script>
    35
    46<p>When the AuthorShadowDOM has only a shadow element, this should be rendered like no Shadow DOM is added.</p>
    57<form>
    6     <button id="host">button</button>
    7     <input id="submit" type="submit" value="Submit">
     8    <button>button</button>
    89</form>
     10
     11</body>
     12</html>
  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-button-only-shadow.html

    r123713 r126288  
    11<!DOCTYPE html>
     2<html>
     3<body>
    24<script src="resources/polyfill.js"></script>
    35
    46<p>When the AuthorShadowDOM has only a shadow element, this should be rendered like no Shadow DOM is added.</p>
    5 <form id="form" action="shadowdom-for-select.html">
     7<form>
    68    <button id="host">button</button>
    7     <input id="submit" type="submit" value="Submit">
    89</form>
    910
     
    1314shadowRoot.innerHTML = "<shadow></shadow>"
    1415</script>
     16</body>
     17</html>
  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-button-without-shadow-expected.html

    r123713 r126288  
    11<!DOCTYPE html>
     2<html>
     3<body>
    24<script src="resources/polyfill.js"></script>
    35
    4 <p>When the AuthorShadowDOM does not have a shadow element, this should be rendered like div.</p>
     6<p>When the AuthorShadowDOM does not have a shadow element, the content should not be rendered.</p>
    57<form>
    6     <div style="display: inline-block: width: 20px; height: 20px"></div>
    7     <input id="submit" type="submit" value="Submit">
     8    <button></button>
    89</form>
     10
     11</body>
     12</html>
  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-button-without-shadow.html

    r123713 r126288  
    11<!DOCTYPE html>
     2<html>
     3<body>
    24<script src="resources/polyfill.js"></script>
    35
    4 <p>When the AuthorShadowDOM does not have a shadow element, this should be rendered like div.</p>
     6<p>When the AuthorShadowDOM does not have a shadow element, the content should not be rendered.</p>
    57<form>
    6     <button id='host' style="display: inline-block; width: 20px; height: 20px; margin: 0; padding: 0; border: 0">foo bar</button>
    7     <input id="submit" type="submit" value="Submit">
     8    <button id="host">something</button>
    89</form>
    910
     
    1213var shadowRoot = new WebKitShadowRoot(host);
    1314</script>
     15
     16</body>
     17</html>
  • trunk/LayoutTests/platform/chromium/TestExpectations

    r126285 r126288  
    32443244BUGWK91485 : fast/dom/shadow/shadowdom-for-textarea-complex-shadow.html = IMAGE
    32453245BUGWK91485 : fast/dom/shadow/shadowdom-for-textarea-without-shadow.html = IMAGE
    3246 BUGWK91486 : fast/dom/shadow/shadowdom-for-button-complex-shadow.html = IMAGE
    3247 BUGWK91486 : fast/dom/shadow/shadowdom-for-button-only-shadow.html = IMAGE
    3248 BUGWK91486 : fast/dom/shadow/shadowdom-for-button-without-shadow.html = IMAGE
    32493246BUGWK91487 : fast/dom/shadow/shadowdom-for-select-complex-shadow.html = IMAGE
    32503247BUGWK91487 : fast/dom/shadow/shadowdom-for-select-without-shadow.html = IMAGE
  • trunk/LayoutTests/platform/efl/TestExpectations

    r126197 r126288  
    688688BUGWK91485 : fast/dom/shadow/shadowdom-for-textarea-only-shadow.html = IMAGE
    689689BUGWK91485 : fast/dom/shadow/shadowdom-for-textarea-without-shadow.html = IMAGE
    690 BUGWK91486 : fast/dom/shadow/shadowdom-for-button-complex-shadow.html = IMAGE
    691 BUGWK91486 : fast/dom/shadow/shadowdom-for-button-only-shadow.html = IMAGE
    692 BUGWK91486 : fast/dom/shadow/shadowdom-for-button-without-shadow.html = IMAGE
    693690BUGWK91487 : fast/dom/shadow/shadowdom-for-select-complex-shadow.html = IMAGE
    694691BUGWK91487 : fast/dom/shadow/shadowdom-for-select-without-shadow.html = IMAGE
Note: See TracChangeset for help on using the changeset viewer.