Changeset 126303 in webkit

Timestamp:

Aug 22, 2012 8:28:37 AM (12 years ago)

Author:

rwlbuis@webkit.org

Message:

[BlackBerry] Add RSS content handling support
​https://bugs.webkit.org/show_bug.cgi?id=93496

Reviewed by Yong Li.

Cleanup some more.

• platform/network/blackberry/rss/RSSFilterStream.cpp:

(WebCore):
(WebCore::createParser):
(WebCore::defaultEncodingForLanguage):
(WebCore::isTranscodingNeeded):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/blackberry/rss/RSSFilterStream.cpp (modified) (4 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-08-22  Rob Buis  <rbuis@rim.com>
+
+        [BlackBerry] Add RSS content handling support
+        https://bugs.webkit.org/show_bug.cgi?id=93496
+
+        Reviewed by Yong Li.
+
+        Cleanup some more.
+
+        * platform/network/blackberry/rss/RSSFilterStream.cpp:
+        (WebCore):
+        (WebCore::createParser):
+        (WebCore::defaultEncodingForLanguage):
+        (WebCore::isTranscodingNeeded):
+
 2012-08-21  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
 

trunk/Source/WebCore/platform/network/blackberry/rss/RSSFilterStream.cpp

@@ -51 +51 @@
 static const char* const s_contentTypeHeaderKey = "Content-Type";
 
-static const char* const s_atom10VersionKey = "xmlns";
-static const char* const s_atom10VersionValue = "http://www.w3.org/2005/Atom";
-static const char* const s_rss10VersionKey = "xmlns";
-static const char* const s_rss10VersionValue = "http://purl.org/rss/1.0/";
-static const char* const s_rss20VersionKey = "version";
-static const char* const s_rss20VersionValue = "2.0";
-static const char* const s_rssXmlVersionKey = "version";
-static const char* const s_rssXmlVersionValue = "1.0";
-
 static int isASCIISpaceLowerByte(int ch)
 {
@@ -240 +231 @@
         return adoptPtr(new RSS20Parser());
     default:
-        // The following code is just for compiler, it should never reach here.
+        ASSERT_NOT_REACHED();
         return adoptPtr(new RSS20Parser());
     }
@@ -318 +309 @@
 static const char* defaultEncodingForLanguage(const char* language)
 {
-    if (!strcasecmp(language, "en")
-        || !strcasecmp(language, "en-US"))
+    if (!strcasecmp(language, "en") || !strcasecmp(language, "en-US"))
         return s_latin1EncodingName;
     if (!strcasecmp(language, "zh-cn"))
@@ -331 +321 @@
     // When there's no encoding information, or the encoding can not be found in all encodings
     // supported in our phone, we will try to transcode the content anyway, supposed to ASCII.
-
     if (encoding.empty())
         return true;