Changeset 126318 in webkit

Timestamp:

Aug 22, 2012 10:50:22 AM (12 years ago)

Author:

jer.noble@apple.com

Message:

Browser menu visible when calling webkitRequestFullscreen after user manually enters full screen mode
​https://bugs.webkit.org/show_bug.cgi?id=93892

Reviewed by Eric Carlson.

Allow the full screen window to "Join All Spaces", so that once it's original full screen space is destroyed,
it can join the new one.

• UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/mac/WKFullScreenWindowController.mm (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2012-08-22  Jer Noble  <jer.noble@apple.com>
+
+        Browser menu visible when calling webkitRequestFullscreen after user manually enters full screen mode
+        https://bugs.webkit.org/show_bug.cgi?id=93892
+
+        Reviewed by Eric Carlson.
+
+        Allow the full screen window to "Join All Spaces", so that once it's original full screen space is destroyed,
+        it can join the new one.
+
+        * UIProcess/mac/WKFullScreenWindowController.mm:
+        (-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]):
+
 2012-08-22  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm

@@ -553 +553 @@
     WKWindowSetClipRect([self window], finalBounds);
 
-    [[self window] makeKeyAndOrderFront:self];
+    NSWindow* window = [self window];
+    NSWindowCollectionBehavior behavior = [window collectionBehavior];
+    [window setCollectionBehavior:(behavior | NSWindowCollectionBehaviorCanJoinAllSpaces)];
+    [window makeKeyAndOrderFront:self];
+    [window setCollectionBehavior:behavior];
+
 
     if (!_backgroundWindow)