Changeset 126327 in webkit

Timestamp:

Aug 22, 2012 12:09:05 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[chromium] Remove WebFrame::setSelectionToRange
​https://bugs.webkit.org/show_bug.cgi?id=94685

Patch by Iain Merrick <​husky@chromium.org> on 2012-08-22
Reviewed by Adam Barth.

It has basically the same functionality as WebFrame::selectRange.
The calling code was removed in Chromium patch 152608.

• public/WebFrame.h:

(WebFrame):

• src/WebFrameImpl.cpp:
• src/WebFrameImpl.h:

(WebFrameImpl):

Location:

trunk/Source/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• public/WebFrame.h (modified) (1 diff)
• src/WebFrameImpl.cpp (modified) (1 diff)
• src/WebFrameImpl.h (modified) (1 diff)

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2012-08-22  Iain Merrick  <husky@chromium.org>
+
+        [chromium] Remove WebFrame::setSelectionToRange
+        https://bugs.webkit.org/show_bug.cgi?id=94685
+
+        Reviewed by Adam Barth.
+
+        It has basically the same functionality as WebFrame::selectRange.
+        The calling code was removed in Chromium patch 152608.
+
+        * public/WebFrame.h:
+        (WebFrame):
+        * src/WebFrameImpl.cpp:
+        * src/WebFrameImpl.h:
+        (WebFrameImpl):
+
 2012-08-22  Kenneth Russell  <kbr@google.com>
 

trunk/Source/WebKit/chromium/public/WebFrame.h

@@ -434 +434 @@
     virtual WebRange markedRange() const = 0;
 
-    virtual void setSelectionToRange(const WebRange&) = 0;
-
     // Returns the frame rectangle in window coordinate space of the given text
     // range.

trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp

@@ -1236 +1236 @@
 }
 
-void WebFrameImpl::setSelectionToRange(const WebRange& range)
-{
-    if (frame()->selection()->isContentEditable()) {
-        RefPtr<Range> replacementRange = PassRefPtr<Range>(range);
-        frame()->selection()->setSelection(VisibleSelection(replacementRange.get(), SEL_DEFAULT_AFFINITY));
-    }
-}
-
 bool WebFrameImpl::firstRectForCharacterRange(unsigned location, unsigned length, WebRect& rect) const
 {

trunk/Source/WebKit/chromium/src/WebFrameImpl.h

@@ -170 +170 @@
     virtual bool hasMarkedText() const;
     virtual WebRange markedRange() const;
-    virtual void setSelectionToRange(const WebRange&) OVERRIDE;
     virtual bool firstRectForCharacterRange(unsigned location, unsigned length, WebRect&) const;
     virtual size_t characterIndexForPoint(const WebPoint&) const;