Changeset 126353 in webkit

Timestamp:

Aug 22, 2012 2:42:38 PM (12 years ago)

Author:

zandobersek@gmail.com

Message:

REGRESSION(r126189): Reftest mismatches are (again) run through ImageDiff with 0.1 tolerance
​https://bugs.webkit.org/show_bug.cgi?id=94704

Reviewed by Dirk Pranke.

Use tolerance=0 when acquiring diff image of reftest output.

• Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner._compare_output_with_reference):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/controllers/single_test_runner.py (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-08-22  Zan Dobersek  <zandobersek@gmail.com>
+
+        REGRESSION(r126189): Reftest mismatches are (again) run through ImageDiff with 0.1 tolerance
+        https://bugs.webkit.org/show_bug.cgi?id=94704
+
+        Reviewed by Dirk Pranke.
+
+        Use tolerance=0 when acquiring diff image of reftest output.
+
+        * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
+        (SingleTestRunner._compare_output_with_reference):
+
 2012-08-22  Tommy Widenflycht  <tommyw@google.com>
 

trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py

@@ -322 +322 @@
         elif mismatch:
             if reference_driver_output.image_hash == actual_driver_output.image_hash:
-                diff_result = self._port.diff_image(reference_driver_output.image, actual_driver_output.image)
+                diff_result = self._port.diff_image(reference_driver_output.image, actual_driver_output.image, tolerance=0)
                 if not diff_result[0]:
                     failures.append(test_failures.FailureReftestMismatchDidNotOccur(reference_filename))
@@ -329 +329 @@
 
         elif reference_driver_output.image_hash != actual_driver_output.image_hash:
-            diff_result = self._port.diff_image(reference_driver_output.image, actual_driver_output.image)
+            diff_result = self._port.diff_image(reference_driver_output.image, actual_driver_output.image, tolerance=0)
             if diff_result[0]:
                 failures.append(test_failures.FailureReftestMismatch(reference_filename))