Changeset 126395 in webkit


Ignore:
Timestamp:
Aug 22, 2012 11:29:36 PM (12 years ago)
Author:
Philippe Normand
Message:

[GTK] media/video-duration-known-after-eos.html and media/media-element-play-after-eos.html are flaky
​https://bugs.webkit.org/show_bug.cgi?id=83790

Reviewed by Eric Seidel.

Refactor the tests to wait the loadedmetadata event before
starting playback and attempting any access to the duration
attribute. This is an attempt to eliminate flakyness of the tests.

  • media/media-element-play-after-eos-expected.txt:
  • media/media-element-play-after-eos.html:
  • media/video-duration-known-after-eos.html:
  • platform/gtk/TestExpectations:
Location:
trunk/LayoutTests
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r126394 r126395  
     12012-08-23  Philippe Normand  <pnormand@igalia.com>
     2
     3        [GTK] media/video-duration-known-after-eos.html and media/media-element-play-after-eos.html are flaky
     4        https://bugs.webkit.org/show_bug.cgi?id=83790
     5
     6        Reviewed by Eric Seidel.
     7
     8        Refactor the tests to wait the loadedmetadata event before
     9        starting playback and attempting any access to the duration
     10        attribute. This is an attempt to eliminate flakyness of the tests.
     11
     12        * media/media-element-play-after-eos-expected.txt:
     13        * media/media-element-play-after-eos.html:
     14        * media/video-duration-known-after-eos.html:
     15        * platform/gtk/TestExpectations:
     16
    1172012-08-22  Hajime Morrita  <morrita@chromium.org>
    218

  • trunk/LayoutTests/media/media-element-play-after-eos-expected.txt

    r96082 r126395  
    11This tests ensure that media element emits the 'playing' event every time it starts playing after eos. It also ensure that 'pause' and 'ended' events are sent when media playback ends.
    22
     3EVENT(loadedmetadata)
    34RUN(mediaElement.play())
    45EVENT(playing)

  • trunk/LayoutTests/media/media-element-play-after-eos.html

    r103495 r126395  
    1010            function start()
    1111            {
     12                mediaElement.src = findMediaFile('audio', 'content/silence');
     13                waitForEvent("loadedmetadata", mediaLoadedMetadata);
     14            }
     15
     16            function mediaLoadedMetadata()
     17            {
    1218                waitForEvent("playing", mediaPlaying);
    1319                waitForEvent("pause", mediaPause);
    1420                waitForEvent("ended", mediaEnded);
    15                 mediaElement.src = findMediaFile('audio', 'content/silence');
    1621                run("mediaElement.play()");
    1722            }

  • trunk/LayoutTests/media/video-duration-known-after-eos.html

    r79630 r126395  
    2020            }
    2121
     22            function loadedmetadata()
     23            {
     24                video.addEventListener("ended", ended);
     25                video.addEventListener("playing", playing);
     26
     27                run("video.play()");
     28            }
     29
    2230            function start()
    2331            {
    2432                findMediaElement();
    2533
    26                 video.addEventListener("ended", ended);
    27                 video.addEventListener("playing", playing);
    28 
     34                video.addEventListener("loadedmetadata", loadedmetadata);
    2935                video.src = findMediaFile("video", "content/test");
    3036                consoleWrite("");
    31                 run("video.play()");
    3237            }
    3338
    3439        </script>
    3540    </head>
    36     <body>
     41    <body onload="start()">
    3742        <video controls autobuffer></video>
    3843        <p>Tests that duration is known after playback ended.</p>
    39         <script>start()</script>
    4044    </body>
    4145</html>

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r126329 r126395  
    525525BUGWK80158 : plugins/netscape-plugin-page-cache-works.html = PASS TEXT
    526526
    527 BUGWK83790 : media/video-duration-known-after-eos.html = PASS TEXT
    528 BUGWK83790 : media/media-element-play-after-eos.html = PASS TEXT
    529527BUGWK83704 : media/event-attributes.html = PASS TEXT
    530528BUGWK89811 : media/media-blocked-by-beforeload.html = PASS TEXT
Note: See TracChangeset for help on using the changeset viewer.