Changeset 126401 in webkit
- Timestamp:
- Aug 23, 2012 12:54:41 AM (12 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 15 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r126400 r126401 1 2012-08-23 KwangYong Choi <ky0.choi@samsung.com> 2 3 [EFL] Use vertical slider theme when the slider is vertical 4 https://bugs.webkit.org/show_bug.cgi?id=93838 5 6 Reviewed by Kenneth Rohde Christiansen. 7 8 Updated expected result because theme of the slider is changed. 9 10 The size of the renderSlider is changed to 129x12 from 129x11 11 because it has the slider thumb 12x12 and it is not resized when 12 the size is not specified. 13 14 * platform/efl/fast/dom/HTMLInputElement/input-slider-update-expected.txt: 15 * platform/efl/fast/forms/box-shadow-override-expected.png: 16 * platform/efl/fast/forms/box-shadow-override-expected.txt: 17 * platform/efl/fast/forms/datalist/input-appearance-range-with-datalist-expected.png: Added. 18 * platform/efl/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png: Added. 19 * platform/efl/fast/forms/input-appearance-height-expected.png: 20 * platform/efl/fast/forms/input-appearance-height-expected.txt: 21 * platform/efl/fast/forms/range/input-appearance-range-expected.png: 22 * platform/efl/fast/forms/range/input-appearance-range-expected.txt: 23 * platform/efl/fast/forms/range/slider-padding-expected.png: 24 * platform/efl/fast/forms/range/slider-padding-expected.txt: 25 * platform/efl/fast/forms/range/slider-thumb-shared-style-expected.png: 26 * platform/efl/fast/forms/range/slider-thumb-shared-style-expected.txt: 27 * platform/efl/fast/repaint/slider-thumb-drag-release-expected.txt: 28 1 29 2012-08-23 Zan Dobersek <zandobersek@gmail.com> 2 30 -
trunk/LayoutTests/platform/efl/fast/dom/HTMLInputElement/input-slider-update-expected.txt
r120441 r126401 4 4 RenderBlock {HTML} at (0,0) size 800x600 5 5 RenderBody {BODY} at (8,8) size 784x584 6 RenderSlider {INPUT} at (2,2) size 129x1 1[color=#909090] [bgcolor=#FFFFFF]7 RenderDeprecatedFlexibleBox {DIV} at (0,0) size 129x1 16 RenderSlider {INPUT} at (2,2) size 129x12 [color=#909090] [bgcolor=#FFFFFF] 7 RenderDeprecatedFlexibleBox {DIV} at (0,0) size 129x12 8 8 RenderBlock {DIV} at (0,0) size 117x12 9 9 RenderBlock {DIV} at (117,0) size 12x12 -
trunk/LayoutTests/platform/efl/fast/forms/box-shadow-override-expected.txt
r120441 r126401 38 38 RenderText {#text} at (44,14) size 4x19 39 39 text run at (44,14) width 4: " " 40 RenderSlider {INPUT} at (50,1 8) size 129x11[color=#909090] [bgcolor=#FFFFFF]41 RenderDeprecatedFlexibleBox {DIV} at (0,0) size 129x1 140 RenderSlider {INPUT} at (50,17) size 129x12 [color=#909090] [bgcolor=#FFFFFF] 41 RenderDeprecatedFlexibleBox {DIV} at (0,0) size 129x12 42 42 RenderBlock {DIV} at (0,0) size 117x12 43 43 RenderBlock {DIV} at (117,0) size 12x12 … … 81 81 layer at (14,148) size 186x18 82 82 RenderBlock {DIV} at (0,0) size 186x18 83 layer at (116,1 90) size 12x1283 layer at (116,189) size 12x12 84 84 RenderBlock (relative positioned) {DIV} at (0,0) size 12x12 -
trunk/LayoutTests/platform/efl/fast/forms/input-appearance-height-expected.txt
r120441 r126401 50 50 RenderText {#text} at (0,164) size 39x19 51 51 text run at (0,164) width 39: "range " 52 RenderSlider {INPUT} at (41,16 8) size 129x11[color=#909090] [bgcolor=#FFFFFF]53 RenderDeprecatedFlexibleBox {DIV} at (0,0) size 129x1 152 RenderSlider {INPUT} at (41,167) size 129x12 [color=#909090] [bgcolor=#FFFFFF] 53 RenderDeprecatedFlexibleBox {DIV} at (0,0) size 129x12 54 54 RenderBlock {DIV} at (0,0) size 117x12 55 55 RenderBlock {DIV} at (117,0) size 12x12 … … 105 105 layer at (58,360) size 186x18 106 106 RenderBlock {DIV} at (0,0) size 186x18 107 layer at (107,19 4) size 12x12107 layer at (107,193) size 12x12 108 108 RenderBlock (relative positioned) {DIV} at (0,0) size 12x12 -
trunk/LayoutTests/platform/efl/fast/forms/range/input-appearance-range-expected.txt
r120441 r126401 10 10 RenderBlock {DIV} at (117,9) size 12x12 11 11 RenderBlock {DIV} at (0,35) size 784x18 12 RenderSlider {INPUT} at (2, 4) size 129x11[color=#909090] [bgcolor=#FFFFFF]13 RenderDeprecatedFlexibleBox {DIV} at (0,0) size 129x1 112 RenderSlider {INPUT} at (2,3) size 129x12 [color=#909090] [bgcolor=#FFFFFF] 13 RenderDeprecatedFlexibleBox {DIV} at (0,0) size 129x12 14 14 RenderBlock {DIV} at (0,0) size 117x12 15 15 RenderBlock {DIV} at (117,0) size 12x12 16 16 RenderBlock {DIV} at (0,53) size 784x18 17 RenderSlider {INPUT} at (2, 4) size 129x11[color=#909090] [bgcolor=#FFFFFF]18 RenderDeprecatedFlexibleBox {DIV} at (0,0) size 129x1 117 RenderSlider {INPUT} at (2,3) size 129x12 [color=#909090] [bgcolor=#FFFFFF] 18 RenderDeprecatedFlexibleBox {DIV} at (0,0) size 129x12 19 19 RenderBlock {DIV} at (0,0) size 117x12 20 20 RenderBlock {DIV} at (117,0) size 12x12 … … 27 27 layer at (68,19) size 12x12 28 28 RenderBlock (relative positioned) {DIV} at (0,0) size 12x12 29 layer at (10,4 7) size 12x1229 layer at (10,46) size 12x12 30 30 RenderBlock (relative positioned) {DIV} at (0,0) size 12x12 31 layer at (127,6 5) size 12x1231 layer at (127,64) size 12x12 32 32 RenderBlock (relative positioned) {DIV} at (0,0) size 12x12 33 33 layer at (130,145) size 12x12 34 34 RenderBlock (relative positioned) {DIV} at (0,0) size 12x12 35 layer at (10,22 8) size 129x1136 RenderSlider {INPUT} at (2, 4) size 129x11[color=#909090] [bgcolor=#FFFFFF]37 RenderDeprecatedFlexibleBox {DIV} at (0,0) size 129x1 135 layer at (10,227) size 129x12 36 RenderSlider {INPUT} at (2,3) size 129x12 [color=#909090] [bgcolor=#FFFFFF] 37 RenderDeprecatedFlexibleBox {DIV} at (0,0) size 129x12 38 38 RenderBlock {DIV} at (0,0) size 117x12 39 39 RenderBlock {DIV} at (117,0) size 12x12 40 layer at (97,22 8) size 12x1240 layer at (97,227) size 12x12 41 41 RenderBlock (relative positioned) {DIV} at (0,0) size 12x12 -
trunk/LayoutTests/platform/efl/fast/forms/range/slider-padding-expected.txt
r120441 r126401 8 8 text run at (0,0) width 321: "This tests that the slider control considers padding. " 9 9 RenderBR {BR} at (0,0) size 0x0 10 RenderBlock {DIV} at (0,18) size 784x1 5[bgcolor=#ADD8E6]11 RenderSlider {INPUT} at (2,2) size 100x1 1[color=#909090] [bgcolor=#FFFFFF]12 RenderDeprecatedFlexibleBox {DIV} at (0,0) size 100x1 110 RenderBlock {DIV} at (0,18) size 784x16 [bgcolor=#ADD8E6] 11 RenderSlider {INPUT} at (2,2) size 100x12 [color=#909090] [bgcolor=#FFFFFF] 12 RenderDeprecatedFlexibleBox {DIV} at (0,0) size 100x12 13 13 RenderBlock {DIV} at (0,0) size 88x12 14 14 RenderBlock {DIV} at (88,0) size 12x12 15 15 RenderText {#text} at (0,0) size 0x0 16 RenderBlock {PRE} at (0,4 6) size 784x016 RenderBlock {PRE} at (0,47) size 784x0 17 17 layer at (10,28) size 12x12 18 18 RenderBlock (relative positioned) {DIV} at (0,0) size 12x12 -
trunk/LayoutTests/platform/efl/fast/forms/range/slider-thumb-shared-style-expected.txt
r120441 r126401 19 19 RenderText {#text} at (0,0) size 282x19 20 20 text run at (0,0) width 282: "The first slider\x{2019}s thumb should be on the left." 21 RenderBlock {DIV} at (0,68) size 784x3 022 RenderSlider {INPUT} at (2,2) size 129x1 1[color=#909090] [bgcolor=#FFFFFF]23 RenderDeprecatedFlexibleBox {DIV} at (0,0) size 129x1 121 RenderBlock {DIV} at (0,68) size 784x32 22 RenderSlider {INPUT} at (2,2) size 129x12 [color=#909090] [bgcolor=#FFFFFF] 23 RenderDeprecatedFlexibleBox {DIV} at (0,0) size 129x12 24 24 RenderBlock {DIV} at (0,0) size 117x12 25 25 RenderBlock {DIV} at (117,0) size 12x12 26 RenderBR {BR} at (133,1 3) size 0x027 RenderSlider {INPUT} at (2,1 7) size 129x11[color=#909090] [bgcolor=#FFFFFF]28 RenderDeprecatedFlexibleBox {DIV} at (0,0) size 129x1 126 RenderBR {BR} at (133,14) size 0x0 27 RenderSlider {INPUT} at (2,18) size 129x12 [color=#909090] [bgcolor=#FFFFFF] 28 RenderDeprecatedFlexibleBox {DIV} at (0,0) size 129x12 29 29 RenderBlock {DIV} at (0,0) size 117x12 30 30 RenderBlock {DIV} at (117,0) size 12x12 … … 32 32 layer at (10,78) size 12x12 33 33 RenderBlock (relative positioned) {DIV} at (0,0) size 12x12 34 layer at (127,9 3) size 12x1234 layer at (127,94) size 12x12 35 35 RenderBlock (relative positioned) {DIV} at (0,0) size 12x12 -
trunk/LayoutTests/platform/efl/fast/repaint/slider-thumb-drag-release-expected.txt
r120441 r126401 4 4 RenderBlock {HTML} at (0,0) size 800x600 5 5 RenderBody {BODY} at (8,8) size 784x584 6 RenderSlider {INPUT} at (2,2) size 129x1 1[color=#909090] [bgcolor=#FFFFFF]7 RenderDeprecatedFlexibleBox {DIV} at (0,0) size 129x1 16 RenderSlider {INPUT} at (2,2) size 129x12 [color=#909090] [bgcolor=#FFFFFF] 7 RenderDeprecatedFlexibleBox {DIV} at (0,0) size 129x12 8 8 RenderBlock {DIV} at (0,0) size 117x12 9 9 RenderBlock {DIV} at (117,0) size 12x12 -
trunk/Source/WebCore/ChangeLog
r126399 r126401 1 2012-08-23 KwangYong Choi <ky0.choi@samsung.com> 2 3 [EFL] Use vertical slider theme when the slider is vertical 4 https://bugs.webkit.org/show_bug.cgi?id=93838 5 6 Reviewed by Kenneth Rohde Christiansen. 7 8 Applied vertical slider theme to the vertical sliders. The height 9 of the vertical slider is wrong when it's applied horizontal 10 slider theme. 11 12 And do not resize slider when its size is not specified. It's natural 13 to use the default value of renderer. 14 15 No new tests. It's covered by existing range and datalist tests. 16 17 * platform/efl/RenderThemeEfl.cpp: 18 (WebCore::RenderThemeEfl::adjustSliderTrackStyle): 19 1 20 2012-08-23 Kentaro Hara <haraken@chromium.org> 2 21 -
trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp
r126359 r126401 768 768 } 769 769 770 adjustSizeConstraints(style, SliderHorizontal); 770 const ThemePartDesc* desc; 771 if (style->appearance() == SliderHorizontalPart) { 772 adjustSizeConstraints(style, SliderHorizontal); 773 desc = m_partDescs + static_cast<size_t>(SliderHorizontal); 774 } else { 775 adjustSizeConstraints(style, SliderVertical); 776 desc = m_partDescs + static_cast<size_t>(SliderVertical); 777 } 771 778 style->resetBorder(); 772 773 const struct ThemePartDesc *desc = m_partDescs + (size_t)SliderHorizontal; 774 if (style->width().value() < desc->min.width().value()) 779 if (style->width().value() > 0 && style->width().value() < desc->min.width().value()) 775 780 style->setWidth(desc->min.width()); 776 if (style->height().value() < desc->min.height().value())781 if (style->height().value() > 0 && style->height().value() < desc->min.height().value()) 777 782 style->setHeight(desc->min.height()); 778 783 }
Note: See TracChangeset
for help on using the changeset viewer.