Changeset 126551 in webkit

Timestamp:

Aug 24, 2012 12:45:50 AM (12 years ago)

Author:

sergio@webkit.org

Message:

[GTK] Purge unused favicons from IconDatabase after 30 days
​https://bugs.webkit.org/show_bug.cgi?id=82346

Reviewed by Gustavo Noronha Silva.

Favicons will be removed from the icon database after not being used
for more than 30 days. This will keep the database size under
control.

• loader/icon/IconDatabase.cpp:

(WebCore):
(WebCore::IconDatabase::performURLImport): filter icons older than
30 days.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• loader/icon/IconDatabase.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-08-24  Sergio Villar Senin  <svillar@igalia.com>
+
+        [GTK] Purge unused favicons from IconDatabase after 30 days
+        https://bugs.webkit.org/show_bug.cgi?id=82346
+
+        Reviewed by Gustavo Noronha Silva.
+
+        Favicons will be removed from the icon database after not being used
+        for more than 30 days. This will keep the database size under
+        control.
+
+        * loader/icon/IconDatabase.cpp:
+        (WebCore):
+        (WebCore::IconDatabase::performURLImport): filter icons older than
+        30 days.
+
 2012-08-23  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/WebCore/loader/icon/IconDatabase.cpp

@@ -73 +73 @@
 
 static bool checkIntegrityOnOpen = false;
+
+#if PLATFORM(GTK)
+// We are not interested in icons that have been unused for more than
+// 30 days, delete them even if they have not been explicitly released.
+static const int notUsedIconExpirationTime = 60*60*24*30;
+#endif
 
 #if !LOG_DISABLED || !ERROR_DISABLED
@@ -1258 +1264 @@
     ASSERT_ICON_SYNC_THREAD();
 
-    SQLiteStatement query(m_syncDB, "SELECT PageURL.url, IconInfo.url, IconInfo.stamp FROM PageURL INNER JOIN IconInfo ON PageURL.iconID=IconInfo.iconID;");
+# if PLATFORM(GTK)
+    // Do not import icons not used in the last 30 days. They will be automatically pruned later if nobody retains them.
+    // Note that IconInfo.stamp is only set when the icon data is retrieved from the server (and thus is not updated whether
+    // we use it or not). This code works anyway because the IconDatabase downloads icons again if they are older than 4 days,
+    // so if the timestamp goes back in time more than those 30 days we can be sure that the icon was not used at all.
+    String importQuery = String::format("SELECT PageURL.url, IconInfo.url, IconInfo.stamp FROM PageURL INNER JOIN IconInfo ON PageURL.iconID=IconInfo.iconID WHERE IconInfo.stamp > %.0f;", floor(currentTime() - notUsedIconExpirationTime));
+#else
+    String importQuery("SELECT PageURL.url, IconInfo.url, IconInfo.stamp FROM PageURL INNER JOIN IconInfo ON PageURL.iconID=IconInfo.iconID;");
+#endif
+
+    SQLiteStatement query(m_syncDB, importQuery);
     
     if (query.prepare() != SQLResultOk) {