Changeset 126873 in webkit


Ignore:
Timestamp:
Aug 28, 2012 7:11:18 AM (12 years ago)
Author:
Hugo Parente Lima
Message:

[WK2] Send click events to WebCore when the user clicked on a non-special node with TOUCH_ADJUSTMENT enabled.
​https://bugs.webkit.org/show_bug.cgi?id=91012

Reviewed by Antonio Gomes.

Source/WebCore:

Don't abort the gesture tap handling when the tap hits a non user
interactable node like a text node.

Test: touchadjustment/focusout-on-touch.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureTap):

LayoutTests:

  • touchadjustment/focusout-on-touch-expected.txt: Added.
  • touchadjustment/focusout-on-touch.html: Added.
Location:
trunk
Files:
2 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r126869 r126873  
     12012-08-28  Hugo Parente Lima  <hugo.lima@openbossa.org>
     2
     3        [WK2] Send click events to WebCore when the user clicked on a non-special node with TOUCH_ADJUSTMENT enabled.
     4        https://bugs.webkit.org/show_bug.cgi?id=91012
     5
     6        Reviewed by Antonio Gomes.
     7
     8        * touchadjustment/focusout-on-touch-expected.txt: Added.
     9        * touchadjustment/focusout-on-touch.html: Added.
     10
    1112012-08-28  Thiago Marcos P. Santos  <thiago.santos@intel.com>
    212

  • trunk/LayoutTests/platform/chromium/TestExpectations

    r126843 r126873  
    27562756BUGWK77314 WIN MAC : fast/events/touch/send-oncancel-event.html = PASS TEXT
    27572757
     2758// Skipped until setTouchPointRadius get implemented
     2759BUGWK91012 SKIP : touchadjustment/focusout-on-touch.html = PASS TEXT
     2760
    27582761// CRASH comes from BUGCR121442
    27592762BUGWK77397 LINUX : plugins/crash-restoring-plugin-page-from-page-cache.html = TIMEOUT CRASH

  • trunk/Source/WebCore/ChangeLog

    r126872 r126873  
     12012-08-28  Hugo Parente Lima  <hugo.lima@openbossa.org>
     2
     3        [WK2] Send click events to WebCore when the user clicked on a non-special node with TOUCH_ADJUSTMENT enabled.
     4        https://bugs.webkit.org/show_bug.cgi?id=91012
     5
     6        Reviewed by Antonio Gomes.
     7
     8        Don't abort the gesture tap handling when the tap hits a non user
     9        interactable node like a text node.
     10
     11        Test: touchadjustment/focusout-on-touch.html
     12
     13        * page/EventHandler.cpp:
     14        (WebCore::EventHandler::handleGestureTap):
     15
    1162012-08-28  Andreas Kling  <kling@webkit.org>
    217

  • trunk/Source/WebCore/page/EventHandler.cpp

    r126837 r126873  
    24522452    IntPoint adjustedPoint = gestureEvent.position();
    24532453#if ENABLE(TOUCH_ADJUSTMENT)
    2454     if (!gestureEvent.area().isEmpty() && !adjustGesturePosition(gestureEvent, adjustedPoint))
    2455         return false;
     2454    if (!gestureEvent.area().isEmpty())
     2455        adjustGesturePosition(gestureEvent, adjustedPoint);
    24562456#endif
    24572457
Note: See TracChangeset for help on using the changeset viewer.