Changeset 126886 in webkit

Timestamp:

Aug 28, 2012 9:02:03 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK] LLint build fails with -g -02
​https://bugs.webkit.org/show_bug.cgi?id=90098

Patch by Alban Browaeys <​prahal@yahoo.com> on 2012-08-28
Reviewed by Filip Pizlo.

Avoid duplicate offsets for llint, discarding them.

• offlineasm/offsets.rb:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• offlineasm/offsets.rb (modified) (4 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2012-08-28  Alban Browaeys <prahal@yahoo.com>
+
+        [GTK] LLint build fails with -g -02
+        https://bugs.webkit.org/show_bug.cgi?id=90098
+
+        Reviewed by Filip Pizlo.
+
+        Avoid duplicate offsets for llint, discarding them.
+
+        * offlineasm/offsets.rb:
+
 2012-08-27  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/JavaScriptCore/offlineasm/offsets.rb

@@ -62 +62 @@
 #
 # offsetsAndConfigurationIndex(ast, file) ->
-#     [[offsets, index], ...]
+#     {[offsets, index], ...}
 #
 # Parses the offsets from a file and returns a list of offsets and the
@@ -70 +70 @@
 def offsetsAndConfigurationIndex(file)
     endiannessMarkerBytes = nil
-    result = []
+    result = {}
     
     def readInt(endianness, bytes)
@@ -156 +156 @@
                     offsets << readInt(endianness, data)
                 }
-                result << [offsets, index]
+                if not result.has_key?(offsets)
+                    result[offsets] = index
+                end
             }
         end
@@ -162 +164 @@
     
     raise MissingMagicValuesException unless result.length >= 1
-    raise if result.map{|v| v[1]}.uniq.size < result.map{|v| v[1]}.size
     
     result