Changeset 126971 in webkit


Ignore:
Timestamp:
Aug 29, 2012 1:02:53 AM (12 years ago)
Author:
ryuan.choi@samsung.com
Message:

[EFL] Move several files to remove webkit1 dependency from WebCore.
https://bugs.webkit.org/show_bug.cgi?id=95264

Reviewed by Gyuyoung Kim.

Source/WebCore:

ColorChooserEfl.cpp, PopupMenuEfl.cpp and SearchPopupMenuEfl.cpp are WebKit1/Efl
specific files and they can not be shared with WebKit2/Efl.

In order to remove WebKit dependency from WebCore, this patch moves them
to WebKit/efl/WebCoreSupport.

No behavior change. Just a refactoring.

  • PlatformEfl.cmake: Removed files which moved from sources and WebKit/efl/WebCoreSupport from includes.
  • WebCore.gypi: Ditto.

Source/WebKit:

  • PlatformEfl.cmake: Added files which is moved.

Source/WebKit/efl:

ColorChooserEfl.cpp, PopupMenuEfl.cpp and SearchPopupMenuEfl.cpp are WebKit1/Efl
specific files and they can not be shared with WebKit2/Efl.

In order to remove WebKit dependency from WebCore, this patch moves them
to WebKit/efl/WebCoreSupport.

  • WebCoreSupport/ColorChooserEfl.cpp: Renamed from Source/WebCore/platform/efl/ColorChooserEfl.cpp.

(WebCore):
(WebCore::ColorChooserEfl::ColorChooserEfl):
(WebCore::ColorChooserEfl::~ColorChooserEfl):
(WebCore::ColorChooserEfl::setSelectedColor):
(WebCore::ColorChooserEfl::endChooser):

  • WebCoreSupport/ColorChooserEfl.h: Renamed from Source/WebCore/platform/efl/ColorChooserEfl.h.

(WebCore):
(ColorChooserEfl):

  • WebCoreSupport/PopupMenuEfl.cpp: Renamed from Source/WebCore/platform/efl/PopupMenuEfl.cpp.

(WebCore):
(WebCore::PopupMenuEfl::PopupMenuEfl):
(WebCore::PopupMenuEfl::~PopupMenuEfl):
(WebCore::PopupMenuEfl::show):
(WebCore::PopupMenuEfl::hide):
(WebCore::PopupMenuEfl::updateFromElement):
(WebCore::PopupMenuEfl::disconnectClient):

  • WebCoreSupport/PopupMenuEfl.h: Renamed from Source/WebCore/platform/efl/PopupMenuEfl.h.

(WebCore):
(PopupMenuEfl):
(WebCore::PopupMenuEfl::client):

  • WebCoreSupport/SearchPopupMenuEfl.cpp: Renamed from Source/WebCore/platform/efl/SearchPopupMenuEfl.cpp.

(WebCore):
(WebCore::SearchPopupMenuEfl::SearchPopupMenuEfl):
(WebCore::SearchPopupMenuEfl::popupMenu):
(WebCore::SearchPopupMenuEfl::saveRecentSearches):
(WebCore::SearchPopupMenuEfl::loadRecentSearches):
(WebCore::SearchPopupMenuEfl::enabled):

  • WebCoreSupport/SearchPopupMenuEfl.h: Renamed from Source/WebCore/platform/efl/SearchPopupMenuEfl.h.

(WebCore):
(SearchPopupMenuEfl):

Location:
trunk/Source
Files:
6 edited
6 moved

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r126970 r126971  
     12012-08-29  Ryuan Choi  <ryuan.choi@samsung.com>
     2
     3        [EFL] Move several files to remove webkit1 dependency from WebCore.
     4        https://bugs.webkit.org/show_bug.cgi?id=95264
     5
     6        Reviewed by Gyuyoung Kim.
     7
     8        ColorChooserEfl.cpp, PopupMenuEfl.cpp and SearchPopupMenuEfl.cpp are WebKit1/Efl
     9        specific files and they can not be shared with WebKit2/Efl.
     10
     11        In order to remove WebKit dependency from WebCore, this patch moves them
     12        to WebKit/efl/WebCoreSupport.
     13
     14        No behavior change. Just a refactoring.
     15
     16        * PlatformEfl.cmake: Removed files which moved from sources and WebKit/efl/WebCoreSupport from includes.
     17        * WebCore.gypi: Ditto.
     18
    1192012-08-28  Dominic Mazzoni  <dmazzoni@google.com>
    220
  • trunk/Source/WebCore/PlatformEfl.cmake

    r126305 r126971  
    1414  "${WEBCORE_DIR}/platform/text/efl"
    1515  "${WEBCORE_DIR}/plugins/efl"
    16   "${WEBKIT_DIR}/efl/WebCoreSupport"
    1716)
    1817
     
    2423  platform/efl/BatteryProviderEfl.cpp
    2524  platform/efl/ClipboardEfl.cpp
    26   platform/efl/ColorChooserEfl.cpp
    2725  platform/efl/ContextMenuEfl.cpp
    2826  platform/efl/ContextMenuItemEfl.cpp
     
    4745  platform/efl/PlatformScreenEfl.cpp
    4846  platform/efl/PlatformWheelEventEfl.cpp
    49   platform/efl/PopupMenuEfl.cpp
    5047  platform/efl/RefPtrEfl.cpp
    5148  platform/efl/RenderThemeEfl.cpp
     
    5451  platform/efl/ScrollbarEfl.cpp
    5552  platform/efl/ScrollbarThemeEfl.cpp
    56   platform/efl/SearchPopupMenuEfl.cpp
    5753  platform/efl/SharedBufferEfl.cpp
    5854  platform/efl/SharedTimerEfl.cpp
  • trunk/Source/WebCore/WebCore.gypi

    r126961 r126971  
    34953495            'platform/efl/PlatformScreenEfl.cpp',
    34963496            'platform/efl/PlatformWheelEventEfl.cpp',
    3497             'platform/efl/PopupMenuEfl.cpp',
    3498             'platform/efl/PopupMenuEfl.h',
    34993497            'platform/efl/RenderThemeEfl.cpp',
    35003498            'platform/efl/RenderThemeEfl.h',
     
    35043502            'platform/efl/ScrollbarThemeEfl.cpp',
    35053503            'platform/efl/ScrollbarThemeEfl.h',
    3506             'platform/efl/SearchPopupMenuEfl.cpp',
    3507             'platform/efl/SearchPopupMenuEfl.h',
    35083504            'platform/efl/SharedBufferEfl.cpp',
    35093505            'platform/efl/SharedTimerEfl.cpp',
  • trunk/Source/WebKit/ChangeLog

    r126868 r126971  
     12012-08-29  Ryuan Choi  <ryuan.choi@samsung.com>
     2
     3        [EFL] Move several files to remove webkit1 dependency from WebCore.
     4        https://bugs.webkit.org/show_bug.cgi?id=95264
     5
     6        Reviewed by Gyuyoung Kim.
     7
     8        * PlatformEfl.cmake: Added files which is moved.
     9
    1102012-08-28  Thiago Marcos P. Santos  <thiago.santos@intel.com>
    211
  • trunk/Source/WebKit/PlatformEfl.cmake

    r126868 r126971  
    8989    efl/WebCoreSupport/BatteryClientEfl.cpp
    9090    efl/WebCoreSupport/ChromeClientEfl.cpp
     91    efl/WebCoreSupport/ColorChooserEfl.cpp
    9192    efl/WebCoreSupport/DeviceOrientationClientEfl.cpp
    9293    efl/WebCoreSupport/DeviceMotionClientEfl.cpp
     
    104105    efl/WebCoreSupport/PageClientEfl.cpp
    105106    efl/WebCoreSupport/PlatformStrategiesEfl.cpp
     107    efl/WebCoreSupport/PopupMenuEfl.cpp
     108    efl/WebCoreSupport/SearchPopupMenuEfl.cpp
    106109    efl/WebCoreSupport/StorageTrackerClientEfl.cpp
    107110    efl/WebCoreSupport/VibrationClientEfl.cpp
  • trunk/Source/WebKit/efl/ChangeLog

    r126960 r126971  
     12012-08-29  Ryuan Choi  <ryuan.choi@samsung.com>
     2
     3        [EFL] Move several files to remove webkit1 dependency from WebCore.
     4        https://bugs.webkit.org/show_bug.cgi?id=95264
     5
     6        Reviewed by Gyuyoung Kim.
     7
     8        ColorChooserEfl.cpp, PopupMenuEfl.cpp and SearchPopupMenuEfl.cpp are WebKit1/Efl
     9        specific files and they can not be shared with WebKit2/Efl.
     10
     11        In order to remove WebKit dependency from WebCore, this patch moves them
     12        to WebKit/efl/WebCoreSupport.
     13
     14        * WebCoreSupport/ColorChooserEfl.cpp: Renamed from Source/WebCore/platform/efl/ColorChooserEfl.cpp.
     15        (WebCore):
     16        (WebCore::ColorChooserEfl::ColorChooserEfl):
     17        (WebCore::ColorChooserEfl::~ColorChooserEfl):
     18        (WebCore::ColorChooserEfl::setSelectedColor):
     19        (WebCore::ColorChooserEfl::endChooser):
     20        * WebCoreSupport/ColorChooserEfl.h: Renamed from Source/WebCore/platform/efl/ColorChooserEfl.h.
     21        (WebCore):
     22        (ColorChooserEfl):
     23        * WebCoreSupport/PopupMenuEfl.cpp: Renamed from Source/WebCore/platform/efl/PopupMenuEfl.cpp.
     24        (WebCore):
     25        (WebCore::PopupMenuEfl::PopupMenuEfl):
     26        (WebCore::PopupMenuEfl::~PopupMenuEfl):
     27        (WebCore::PopupMenuEfl::show):
     28        (WebCore::PopupMenuEfl::hide):
     29        (WebCore::PopupMenuEfl::updateFromElement):
     30        (WebCore::PopupMenuEfl::disconnectClient):
     31        * WebCoreSupport/PopupMenuEfl.h: Renamed from Source/WebCore/platform/efl/PopupMenuEfl.h.
     32        (WebCore):
     33        (PopupMenuEfl):
     34        (WebCore::PopupMenuEfl::client):
     35        * WebCoreSupport/SearchPopupMenuEfl.cpp: Renamed from Source/WebCore/platform/efl/SearchPopupMenuEfl.cpp.
     36        (WebCore):
     37        (WebCore::SearchPopupMenuEfl::SearchPopupMenuEfl):
     38        (WebCore::SearchPopupMenuEfl::popupMenu):
     39        (WebCore::SearchPopupMenuEfl::saveRecentSearches):
     40        (WebCore::SearchPopupMenuEfl::loadRecentSearches):
     41        (WebCore::SearchPopupMenuEfl::enabled):
     42        * WebCoreSupport/SearchPopupMenuEfl.h: Renamed from Source/WebCore/platform/efl/SearchPopupMenuEfl.h.
     43        (WebCore):
     44        (SearchPopupMenuEfl):
     45
    1462012-08-28  Seokju Kwon  <seokju.kwon@samsung.com>
    247
Note: See TracChangeset for help on using the changeset viewer.