Changeset 127088 in webkit


Ignore:
Timestamp:
Aug 29, 2012 8:12:25 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

Add WebKit prefix to MediaSource, SourceBuffer, & SourceBufferList DOMWindow constructor attributes.
​https://bugs.webkit.org/show_bug.cgi?id=95247

Patch by Aaron Colwell <​acolwell@chromium.org> on 2012-08-29
Reviewed by Eric Carlson.

Source/WebCore:

Add WebKit prefix to MediaSource, SourceBuffer, and SourceBufferList object constructor attributes.

Covered by existing layout tests..

  • page/DOMWindow.idl:

LayoutTests:

Update MediaSource tests to include the WebKit prefix on MediaSource, SourceBuffer, & SourceBufferTest objects.

  • http/tests/media/media-source/media-source.js:
  • http/tests/media/media-source/video-media-source-add-and-remove-buffers.html:
  • http/tests/media/media-source/video-media-source-async-events.html:
  • http/tests/media/media-source/video-media-source-event-attributes.html:
  • http/tests/media/media-source/video-media-source-objects-expected.txt:
  • http/tests/media/media-source/video-media-source-objects.html:
  • http/tests/media/media-source/video-media-source-play.html:
  • http/tests/media/media-source/video-media-source-state-changes.html:
Location:
trunk
Files:
11 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r127084 r127088  
     12012-08-29  Aaron Colwell  <acolwell@chromium.org>
     2
     3        Add WebKit prefix to MediaSource, SourceBuffer, & SourceBufferList DOMWindow constructor attributes.
     4        https://bugs.webkit.org/show_bug.cgi?id=95247
     5
     6        Reviewed by Eric Carlson.
     7
     8        Update MediaSource tests to include the WebKit prefix on MediaSource, SourceBuffer, & SourceBufferTest objects.
     9
     10        * http/tests/media/media-source/media-source.js:
     11        * http/tests/media/media-source/video-media-source-add-and-remove-buffers.html:
     12        * http/tests/media/media-source/video-media-source-async-events.html:
     13        * http/tests/media/media-source/video-media-source-event-attributes.html:
     14        * http/tests/media/media-source/video-media-source-objects-expected.txt:
     15        * http/tests/media/media-source/video-media-source-objects.html:
     16        * http/tests/media/media-source/video-media-source-play.html:
     17        * http/tests/media/media-source/video-media-source-state-changes.html:
     18
    1192012-08-29  Dominic Mazzoni  <dmazzoni@google.com>
    220

  • trunk/LayoutTests/http/tests/media/media-source/media-source.js

    r125429 r127088  
    11var MediaSourceTest = {};
    2 var mediaSource = new MediaSource();
     2var mediaSource = new WebKitMediaSource();
    33
    44MediaSourceTest.SegmentHelper = function(segmentInfo)

  • trunk/LayoutTests/http/tests/media/media-source/video-media-source-add-and-remove-buffers.html

    r125059 r127088  
    169169                findMediaElement();
    170170
    171                 mediaSource = new MediaSource();
     171                mediaSource = new WebKitMediaSource();
    172172                waitForEvent('webkitsourceopen', "", false, false, mediaSource);
    173173

  • trunk/LayoutTests/http/tests/media/media-source/video-media-source-async-events.html

    r126946 r127088  
    6565            {
    6666                var video = document.querySelector('#v');
    67                 var mediaSource = new MediaSource();
     67                var mediaSource = new WebKitMediaSource();
    6868
    6969                mediaSource.addEventListener('webkitsourceopen', onSourceOpen);

  • trunk/LayoutTests/http/tests/media/media-source/video-media-source-event-attributes.html

    r126946 r127088  
    3232               consoleWrite("onLoad()");
    3333               video = document.getElementById('v');
    34                mediaSource = new MediaSource();
     34               mediaSource = new WebKitMediaSource();
    3535               mediaSource.addEventListener('webkitsourceopen', onSourceOpen);
    3636               mediaSource.addEventListener('webkitsourceended', onSourceEnded);

  • trunk/LayoutTests/http/tests/media/media-source/video-media-source-objects-expected.txt

    r125682 r127088  
    44Test MediaSource object type
    55EXPECTED (mediaSource == '[object MediaSource]') OK
    6 EXPECTED (mediaSource instanceof window.MediaSource == 'true') OK
     6EXPECTED (mediaSource instanceof window.WebKitMediaSource == 'true') OK
    77
    88Add a SourceBuffer
    … …  
    1313Test SourceBufferList object type:
    1414EXPECTED (mediaSource.sourceBuffers == '[object SourceBufferList]') OK
    15 EXPECTED (mediaSource.sourceBuffers instanceof window.SourceBufferList == 'true') OK
     15EXPECTED (mediaSource.sourceBuffers instanceof window.WebKitSourceBufferList == 'true') OK
    1616
    1717Test SourceBuffer object type
    18 EXPECTED (segmentHelper.sourceBuffer instanceof window.SourceBuffer == 'true') OK
    19 EXPECTED (mediaSource.sourceBuffers[0] instanceof window.SourceBuffer == 'true') OK
     18EXPECTED (segmentHelper.sourceBuffer instanceof window.WebKitSourceBuffer == 'true') OK
     19EXPECTED (mediaSource.sourceBuffers[0] instanceof window.WebKitSourceBuffer == 'true') OK
    2020
    2121Append init segment

  • trunk/LayoutTests/http/tests/media/media-source/video-media-source-objects.html

    r126946 r127088  
    1212                consoleWrite("Test MediaSource object type");
    1313                testExpected("mediaSource", event.target);
    14                 testExpected("mediaSource instanceof window.MediaSource", true);
     14                testExpected("mediaSource instanceof window.WebKitMediaSource", true);
    1515
    1616                consoleWrite("");
    … …  
    2828                consoleWrite("");
    2929                consoleWrite("Test SourceBuffer object type");
    30                 testExpected("segmentHelper.sourceBuffer instanceof window.SourceBuffer", true);
    31                 testExpected("mediaSource.sourceBuffers[0] instanceof window.SourceBuffer", true);
     30                testExpected("segmentHelper.sourceBuffer instanceof window.WebKitSourceBuffer", true);
     31                testExpected("mediaSource.sourceBuffers[0] instanceof window.WebKitSourceBuffer", true);
    3232
    3333                consoleWrite("");
    … …  
    7373            {
    7474                consoleWrite("Test that addSourceBuffer() throws and error when the MediaSource is not associated with a media element.");
    75                 var mediaSource2 = new MediaSource();
     75                var mediaSource2 = new WebKitMediaSource();
    7676                video.src = webkitURL.createObjectURL(mediaSource2);
    7777                try {
    … …  
    9898                consoleWrite("Test SourceBufferList object type:");
    9999                testExpected("mediaSource.sourceBuffers", event.target);
    100                 testExpected("mediaSource.sourceBuffers instanceof window.SourceBufferList", true);
     100                testExpected("mediaSource.sourceBuffers instanceof window.WebKitSourceBufferList", true);
    101101
    102102                afterSourceBufferAdded();
    … …  
    131131                findMediaElement();
    132132
    133                 mediaSource = new MediaSource();
     133                mediaSource = new WebKitMediaSource();
    134134
    135135                waitForEventAndFail('error');

  • trunk/LayoutTests/http/tests/media/media-source/video-media-source-play.html

    r125059 r127088  
    2424                findMediaElement();
    2525
    26                 mediaSource = new MediaSource();
     26                mediaSource = new WebKitMediaSource();
    2727
    2828                waitForEventAndFail('error');

  • trunk/LayoutTests/http/tests/media/media-source/video-media-source-state-changes.html

    r125059 r127088  
    217217                findMediaElement();
    218218
    219                 mediaSource = new MediaSource();
     219                mediaSource = new WebKitMediaSource();
    220220
    221221                waitForEventAndFail('error');

  • trunk/Source/WebCore/ChangeLog

    r127087 r127088  
     12012-08-29  Aaron Colwell  <acolwell@chromium.org>
     2
     3        Add WebKit prefix to MediaSource, SourceBuffer, & SourceBufferList DOMWindow constructor attributes.
     4        https://bugs.webkit.org/show_bug.cgi?id=95247
     5
     6        Reviewed by Eric Carlson.
     7
     8        Add WebKit prefix to MediaSource, SourceBuffer, and SourceBufferList object constructor attributes.
     9
     10        Covered by existing layout tests..
     11
     12        * page/DOMWindow.idl:
     13
    1142012-08-29  Nate Chapin  <japhet@chromium.org>
    215

  • trunk/Source/WebCore/page/DOMWindow.idl

    r125149 r127088  
    787787        attribute [Conditional=MUTATION_OBSERVERS] MutationObserverConstructor WebKitMutationObserver;
    788788
    789         attribute [Conditional=MEDIA_SOURCE, V8EnabledAtRuntime=mediaSource] MediaSourceConstructor MediaSource;
    790         attribute [Conditional=MEDIA_SOURCE, V8EnabledAtRuntime=mediaSource] SourceBufferConstructor SourceBuffer;
    791         attribute [Conditional=MEDIA_SOURCE, V8EnabledAtRuntime=mediaSource] SourceBufferListConstructor SourceBufferList;
     789        attribute [Conditional=MEDIA_SOURCE, V8EnabledAtRuntime=mediaSource] MediaSourceConstructor WebKitMediaSource;
     790        attribute [Conditional=MEDIA_SOURCE, V8EnabledAtRuntime=mediaSource] SourceBufferConstructor WebKitSourceBuffer;
     791        attribute [Conditional=MEDIA_SOURCE, V8EnabledAtRuntime=mediaSource] SourceBufferListConstructor WebKitSourceBufferList;
    792792
    793793#endif // defined(LANGUAGE_JAVASCRIPT)
Note: See TracChangeset for help on using the changeset viewer.