Changeset 12712 in webkit


Ignore:
Timestamp:
Feb 8, 2006 11:50:14 PM (18 years ago)
Author:
thatcher
Message:

Test: fast/block/positioning/window-height-change.html

Reviewed by Hyatt.


  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Always relayout positioned children of the root, since their positions may depend on the viewport's height which may have changed.
  • rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutBlock): Ditto.
Location:
trunk
Files:
7 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r12699 r12712  
     12006-02-08  Mitz Pettel  <opendarwin.org@mitzpettel.com>
     2
     3        Test: fast/block/positioning/window-height-change.html
     4
     5        Reviewed by Hyatt.
     6       
     7        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5813
     8          positioned blocks don't update when resizing the window vertically
     9
     10        * rendering/RenderBlock.cpp:
     11        (WebCore::RenderBlock::layoutBlock): Always relayout positioned children of
     12        the root, since their positions may depend on the viewport's height which
     13        may have changed.
     14        * rendering/render_flexbox.cpp:
     15        (khtml::RenderFlexibleBox::layoutBlock): Ditto.
     16
    1172006-02-08  Dave Hyatt <hyatt@apple.com>
    218

  • trunk/WebCore/rendering/RenderBlock.cpp

    r12524 r12712  
    426426    if (!relayoutChildren && posChildNeedsLayout() && !normalChildNeedsLayout() && !selfNeedsLayout()) {
    427427        // All we have to is lay out our positioned objects.
    428         layoutPositionedObjects(relayoutChildren);
     428        layoutPositionedObjects(relayoutChildren || isRoot());
    429429        if (hasOverflowClip())
    430430            m_layer->updateScrollInfoAfterLayout();
    … …  
    533533    }
    534534
    535     layoutPositionedObjects( relayoutChildren );
     535    layoutPositionedObjects(relayoutChildren || isRoot());
    536536
    537537    // Always ensure our overflow width/height are at least as large as our width/height.

  • trunk/WebCore/rendering/render_flexbox.cpp

    r12524 r12712  
    247247    if (!relayoutChildren && posChildNeedsLayout() && !normalChildNeedsLayout() && !selfNeedsLayout()) {
    248248        // All we have to is lay out our positioned objects.
    249         layoutPositionedObjects(relayoutChildren);
     249        layoutPositionedObjects(relayoutChildren || isRoot());
    250250        if (hasOverflowClip())
    251251            m_layer->updateScrollInfoAfterLayout();
    … …  
    306306        relayoutChildren = true;
    307307
    308     layoutPositionedObjects( relayoutChildren );
     308    layoutPositionedObjects(relayoutChildren || isRoot());
    309309
    310310    //kdDebug() << renderName() << " layout width=" << m_width << " height=" << m_height << endl;
Note: See TracChangeset for help on using the changeset viewer.