Changeset 127380 in webkit


Ignore:
Timestamp:
Sep 1, 2012 12:42:46 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

fast/events/message-port-clone.html hits ASSERT in Debug (usually in later tests)
​https://bugs.webkit.org/show_bug.cgi?id=85811

Patch by Li Yin <​li.yin@intel.com> on 2012-09-01
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

When MessagePort invoked close function, the close status is needed to set,
regardless of whether the port is cloned or not.

Tests: fast/events/message-port-clone.html

fast/events/message-port-close.html

  • dom/MessagePort.cpp:

(WebCore::MessagePort::close): Must set m_closed to be true.

LayoutTests:

  • platform/gtk/TestExpectations:
  • platform/mac/Skipped:
  • platform/qt-4.8/TestExpectations:
  • platform/qt-mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/Skipped:
Location:
trunk
Files:
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r127379 r127380  
     12012-09-01  Li Yin  <li.yin@intel.com>
     2
     3        fast/events/message-port-clone.html hits ASSERT in Debug (usually in later tests)
     4        https://bugs.webkit.org/show_bug.cgi?id=85811
     5
     6        Reviewed by Kenneth Rohde Christiansen.
     7
     8        * platform/gtk/TestExpectations:
     9        * platform/mac/Skipped:
     10        * platform/qt-4.8/TestExpectations:
     11        * platform/qt-mac/TestExpectations:
     12        * platform/qt/TestExpectations:
     13        * platform/win/Skipped:
     14
    1152012-09-01  Xianzhu Wang  <wangxianzhu@chromium.org>
    216

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r127299 r127380  
    443443
    444444BUGWK74297 DEBUG : http/tests/security/cross-origin-xsl-redirect-BLOCKED.html = CRASH PASS
    445 
    446 BUGWK85811 DEBUG : fast/events/message-port-close.html = CRASH PASS
    447445
    448446BUGWK86443 : plugins/npruntime/delete-plugin-within-getProperty.html = CRASH

  • trunk/LayoutTests/platform/mac/Skipped

    r127347 r127380  
    873873fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgba5551.html
    874874
    875 # Asserts in MessagePort::contextDestroyed
    876 # https://bugs.webkit.org/show_bug.cgi?id=85811
    877 fast/events/message-port-clone.html
    878 
    879875# Times out without keyboard interaction
    880876# https://bugs.webkit.org/show_bug.cgi?id=87748

  • trunk/LayoutTests/platform/qt-4.8/TestExpectations

    r126190 r127380  
    164164BUGWK91379 : http/tests/security/contentSecurityPolicy/object-src-none-allowed.html = TEXT PASS
    165165
    166 BUGWK85811 DEBUG : fast/events/message-port-close.html = CRASH
    167 
    168166// Needs rebaseline after https://bugs.webkit.org/show_bug.cgi?id=80219
    169167BUGWK80219 : compositing/overflow/clip-descendents.html = TEXT

  • trunk/LayoutTests/platform/qt-mac/TestExpectations

    r126190 r127380  
    164164BUGWK91379 : http/tests/security/contentSecurityPolicy/object-src-none-allowed.html = TEXT PASS
    165165
    166 BUGWK85811 DEBUG : fast/events/message-port-close.html = CRASH
    167 
    168166// Needs rebaseline after https://bugs.webkit.org/show_bug.cgi?id=80219
    169167BUGWK80219 : compositing/overflow/clip-descendents.html = TEXT

  • trunk/LayoutTests/platform/qt/TestExpectations

    r127245 r127380  
    124124BUGWK91379 : http/tests/security/contentSecurityPolicy/object-src-none-allowed.html = TEXT PASS
    125125
    126 BUGWK85811 DEBUG : fast/events/message-port-close.html = CRASH
    127 
    128126// Needs rebaseline after https://bugs.webkit.org/show_bug.cgi?id=80219
    129127BUGWK80219 : compositing/overflow/clip-descendents.html = TEXT

  • trunk/LayoutTests/platform/win/Skipped

    r127335 r127380  
    18671867# https://bugs.webkit.org/show_bug.cgi?id=88150
    18681868compositing/geometry/clipping-foreground.html
    1869 
    1870 # Asserts in MessagePort::contextDestroyed
    1871 # https://bugs.webkit.org/show_bug.cgi?id=85811
    1872 fast/events/message-port-clone.html
    18731869
    18741870# Require rebaseline after bug 88171

  • trunk/Source/WebCore/ChangeLog

    r127375 r127380  
     12012-09-01  Li Yin  <li.yin@intel.com>
     2
     3        fast/events/message-port-clone.html hits ASSERT in Debug (usually in later tests)
     4        https://bugs.webkit.org/show_bug.cgi?id=85811
     5
     6        Reviewed by Kenneth Rohde Christiansen.
     7
     8        When MessagePort invoked close function, the close status is needed to set,
     9        regardless of whether the port is cloned or not.
     10
     11        Tests: fast/events/message-port-clone.html
     12               fast/events/message-port-close.html
     13
     14        * dom/MessagePort.cpp:
     15        (WebCore::MessagePort::close): Must set m_closed to be true.
     16
    1172012-09-01  Andreas Kling  <kling@webkit.org>
    218

  • trunk/Source/WebCore/dom/MessagePort.cpp

    r126286 r127380  
    134134void MessagePort::close()
    135135{
    136     if (!isEntangled())
    137         return;
    138     m_entangledChannel->close();
     136    if (isEntangled())
     137        m_entangledChannel->close();
    139138    m_closed = true;
    140139}
Note: See TracChangeset for help on using the changeset viewer.