Changeset 127432 in webkit

Timestamp:

Sep 3, 2012 12:14:42 PM (12 years ago)

Author:

allan.jensen@nokia.com

Message:

[Qt] Not all activated elements highlighted, but some frames are
​https://bugs.webkit.org/show_bug.cgi?id=95683

Reviewed by Kenneth Rohde Christiansen.

Use the new function Node::willRespondToMouseClickEvents to better determine if the element
can be tap-activated and avoid documents and frames completely.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::highlightPotentialActivation):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/WebPage.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2012-09-03  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
+
+        [Qt] Not all activated elements highlighted, but some frames are
+        https://bugs.webkit.org/show_bug.cgi?id=95683
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Use the new function Node::willRespondToMouseClickEvents to better determine if the element
+        can be tap-activated and avoid documents and frames completely.
+
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::WebPage::highlightPotentialActivation):
+
 2012-09-03  Eunmi Lee  <eunmi15.lee@samsung.com>
 

trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp

@@ -1563 +1563 @@
         // Instead find the enclosing link or focusable element, or the last enclosing inline element.
         for (Node* node = adjustedNode; node; node = node->parentOrHostNode()) {
-            if (node->isMouseFocusable() || node->isLink()) {
+            if (node->isDocumentNode() || node->isFrameOwnerElement())
+                break;
+            if (node->isMouseFocusable() || node->willRespondToMouseClickEvents()) {
                 activationNode = node;
                 break;