Changeset 127469 in webkit

Timestamp:

Sep 4, 2012 8:45:38 AM (12 years ago)

Author:

Philippe Normand

Message:

[GStreamer] 0.11 build breaks due to rename of gst_message_new_duration
​https://bugs.webkit.org/show_bug.cgi?id=95751

Reviewed by Martin Robinson.

In gstreamer commit f712a9596c2bc1863edf9b816d9854eefca9ba45
gst_message_new_duration was renamed to
gst_message_new_duration_changed.

However the only place where we used this is in the HTTP source
element and only if appsrc < 0.10.27 is used at runtime. In the
case of GStreamer 1.0 this condition will be always false so we
can disable this code at build time.

• platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(StreamingClient::didReceiveResponse):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-09-04  Philippe Normand  <pnormand@igalia.com>
+
+        [GStreamer] 0.11 build breaks due to rename of gst_message_new_duration
+        https://bugs.webkit.org/show_bug.cgi?id=95751
+
+        Reviewed by Martin Robinson.
+
+        In gstreamer commit f712a9596c2bc1863edf9b816d9854eefca9ba45
+        gst_message_new_duration was renamed to
+        gst_message_new_duration_changed.
+
+        However the only place where we used this is in the HTTP source
+        element and only if appsrc < 0.10.27 is used at runtime. In the
+        case of GStreamer 1.0 this condition will be always false so we
+        can disable this code at build time.
+
+        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
+        (StreamingClient::didReceiveResponse):
+
 2012-09-04  Andrei Poenaru  <poenaru@adobe.com>
 

trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp

@@ -783 +783 @@
         length += priv->requestedOffset;
         gst_app_src_set_size(priv->appsrc, length);
+
+#ifndef GST_API_VERSION_1
         if (!priv->haveAppSrc27) {
-#ifdef GST_API_VERSION_1
-            GstSegment* segment = &GST_BASE_SRC(priv->appsrc)->segment;
-            segment->duration = length;
-            segment->format = GST_FORMAT_BYTES;
-#else
             gst_segment_set_duration(&GST_BASE_SRC(priv->appsrc)->segment, GST_FORMAT_BYTES, length);
-#endif
             gst_element_post_message(GST_ELEMENT(priv->appsrc),
                                      gst_message_new_duration(GST_OBJECT(priv->appsrc),
                                                               GST_FORMAT_BYTES, length));
         }
+#endif
     }