Changeset 127482 in webkit

Timestamp:

Sep 4, 2012 12:11:43 PM (12 years ago)

Author:

ojan@chromium.org

Message:

Elide test names when running new-run-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=95626

Patch by Tony Chang <​tony@chromium.org> on 2012-09-04
Reviewed by Dirk Pranke.

When the test name exceeds the number of terminal columns, it leaves
text on the screen. Avoid this by eliding the test name when running
tests. This is similar to what ninja does when compiling.

• Scripts/webkitpy/layout_tests/views/metered_stream.py:

(MeteredStream):
(MeteredStream.number_of_columns): Helper method to get number of
terminal columns. Won't work on Win32 python, but meh.

• Scripts/webkitpy/layout_tests/views/printing.py:

(Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
because stderr appears to be ascii only.
(Printer.print_started_test): Route through _test_status_line.
(Printer.print_finished_test): Route through _test_status_line.
(Printer._print_test_trace): Route through _test_status_line.
(Printer._print_baseline): Route through _test_status_line.

• Scripts/webkitpy/layout_tests/views/printing_unittest.py:

(test_test_status_line): Test for _test_status_line.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestResultServer/static-dashboards/builders.js (modified) (3 diffs)

trunk/Tools/ChangeLog

@@ -74 +74 @@
         (WebViewHost):
         (WebViewHost::setPointerLockWillRespondAsynchronously):
+
+2012-09-04  Ojan Vafai  <ojan@chromium.org>
+
+        Move content shell bots to their own builder group
+        https://bugs.webkit.org/show_bug.cgi?id=95765
+
+        Reviewed by Adam Barth.
+
+        In their current state of instability, they add too much noise. Once they get more stable,
+        we can add them back to the regular group or just have them replace the other bots.
+
+        Also, fix the filter for Apple Windows bots since some of them are now "Apple Win ...".
+
+        * TestResultServer/static-dashboards/builders.js:
+        (isWebkitTestRunner):
+        (isChromiumContentShellTestRunner):
+        (isChromiumWebkitTipOfTreeTestRunner):
+        (loadBuildersList):
 
 2012-09-03  Ryuan Choi  <ryuan.choi@samsung.com>

trunk/Tools/TestResultServer/static-dashboards/builders.js

@@ -166 +166 @@
     if (builder.indexOf('Tests') != -1) {
         // Apple Windows bots still run old-run-webkit-tests, so they don't upload data.
-        return builder.indexOf('Windows') == -1 || (builder.indexOf('Qt') != -1 && builder.indexOf('Chromium') != -1);
+        return builder.indexOf('Win') == -1 || (builder.indexOf('Qt') != -1 && builder.indexOf('Chromium') != -1);
     }
     return builder.indexOf('GTK') != -1 || builder == 'Qt Linux Release';
 }
 
+function isChromiumContentShellTestRunner(builder)
+{
+    return builder.indexOf('(Content Shell)') != -1;
+}
+
 function isChromiumWebkitTipOfTreeTestRunner(builder)
 {
-    return (builder.indexOf('Webkit') != -1 && builder.indexOf('Builder') == -1 && builder.indexOf('(deps)') == -1 && builder.indexOf('ASAN') == -1) || builder.indexOf('(Content Shell)') != -1;
+    return builder.indexOf('Webkit') != -1 && builder.indexOf('Builder') == -1 && builder.indexOf('(deps)') == -1 && builder.indexOf('ASAN') == -1;
 }
 
@@ -251 +256 @@
     case 'layout-tests':
         switch(groupName) {
+        case 'Content Shell @ToT - chromium.org':
+            var builderGroup = new BuilderGroup(BuilderGroup.TOT_WEBKIT);
+            requestBuilderList(LAYOUT_TESTS_BUILDER_GROUPS, isChromiumContentShellTestRunner, CHROMIUM_WEBKIT_BUILDER_MASTER, groupName, builderGroup);
+            break;
+
         case '@ToT - chromium.org':
             var builderGroup = new BuilderGroup(BuilderGroup.TOT_WEBKIT);
@@ -297 +307 @@
     '@ToT - webkit.org': null,
     '@DEPS - chromium.org': null,
+    'Content Shell @ToT - chromium.org': null,
 };