Changeset 127613 in webkit

Timestamp:

Sep 5, 2012 11:16:58 AM (12 years ago)

Author:

mifenton@rim.com

Message:

[BlackBerry] PlatformKeyboardEvent::getCurrentModifierState should initialize values.
​https://bugs.webkit.org/show_bug.cgi?id=95773

Reviewed by Rob Buis.

Properly initialize the passed variables even
though we haven't implemented the modifier state
to ensure the values are deterministic.

• platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/blackberry/PlatformKeyboardEventBlackBerry.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-09-05  Mike Fenton  <mifenton@rim.com>
+
+        [BlackBerry] PlatformKeyboardEvent::getCurrentModifierState should initialize values.
+        https://bugs.webkit.org/show_bug.cgi?id=95773
+
+        Reviewed by Rob Buis.
+
+        Properly initialize the passed variables even
+        though we haven't implemented the modifier state
+        to ensure the values are deterministic.
+
+        * platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:
+        (WebCore::PlatformKeyboardEvent::getCurrentModifierState):
+
 2012-09-05  Tommy Widenflycht  <tommyw@google.com>
 

trunk/Source/WebCore/platform/blackberry/PlatformKeyboardEventBlackBerry.cpp

@@ -480 +480 @@
 }
 
-void PlatformKeyboardEvent::getCurrentModifierState(bool&, bool&, bool&, bool&)
+void PlatformKeyboardEvent::getCurrentModifierState(bool& shiftKey, bool& ctrlKey, bool& altKey, bool& metaKey)
 {
     notImplemented();
+    shiftKey = false;
+    ctrlKey = false;
+    altKey = false;
+    metaKey = false;
 }