Changeset 127670 in webkit

Timestamp:

Sep 5, 2012 6:11:35 PM (12 years ago)

Author:

staikos@webkit.org

Message:

[BlackBerry] Assignment operators missing self-check
​https://bugs.webkit.org/show_bug.cgi?id=95774

Reviewed by Rob Buis.

Add a test for self-assignment.

• Api/WebAnimation.cpp:

(BlackBerry::WebKit::WebAnimation::operator=):

• Api/WebString.cpp:

(BlackBerry::WebKit::WebString::operator=):

Location:

trunk/Source/WebKit/blackberry

Files:

• Api/WebAnimation.cpp (modified) (1 diff)
• Api/WebString.cpp (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Source/WebKit/blackberry/Api/WebAnimation.cpp

@@ -71 +71 @@
 WebAnimation& WebAnimation::operator=(const WebAnimation& o)
 {
-    *d = *o.d;
+    if (&o != this)
+        *d = *o.d;
     return *this;
 }

trunk/Source/WebKit/blackberry/Api/WebString.cpp

@@ -68 +68 @@
 WebString& WebString::operator=(const WebString& str)
 {
+    if (&str == this)
+        return *this;
     if (str.m_impl)
         str.m_impl->ref();

trunk/Source/WebKit/blackberry/ChangeLog

@@ +1 @@
+2012-09-05  George Staikos  <staikos@webkit.org>
+
+        [BlackBerry] Assignment operators missing self-check
+        https://bugs.webkit.org/show_bug.cgi?id=95774
+
+        Reviewed by Rob Buis.
+
+        Add a test for self-assignment.
+
+        * Api/WebAnimation.cpp:
+        (BlackBerry::WebKit::WebAnimation::operator=):
+        * Api/WebString.cpp:
+        (BlackBerry::WebKit::WebString::operator=):
+
 2012-09-05  Leo Yang  <leoyang@rim.com>