Changeset 127688 in webkit

Timestamp:

Sep 5, 2012 9:37:42 PM (12 years ago)

Author:

dpranke@chromium.org

Message:

NRWT lies about the number of tests that it's skipping when used with --repeat-each
​https://bugs.webkit.org/show_bug.cgi?id=95789

Reviewed by Ojan Vafai.

Fix miscalculation in log message.

• Scripts/webkitpy/layout_tests/views/printing.py:

(Printer.print_found):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/views/printing.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-09-05  Dirk Pranke  <dpranke@chromium.org>
+
+        NRWT lies about the number of tests that it's skipping when used with --repeat-each
+        https://bugs.webkit.org/show_bug.cgi?id=95789
+
+        Reviewed by Ojan Vafai.
+
+        Fix miscalculation in log message.
+
+        * Scripts/webkitpy/layout_tests/views/printing.py:
+        (Printer.print_found):
+
 2012-09-05  Kenichi Ishibashi  <bashi@chromium.org>
 

trunk/Tools/Scripts/webkitpy/layout_tests/views/printing.py

@@ -110 +110 @@
 
     def print_found(self, num_all_test_files, num_to_run, repeat_each, iterations):
-        found_str = 'Found %s; running %d' % (grammar.pluralize('test', num_all_test_files), num_to_run)
+        num_unique_tests = num_to_run / (repeat_each * iterations)
+        found_str = 'Found %s; running %d' % (grammar.pluralize('test', num_all_test_files), num_unique_tests)
         if repeat_each * iterations > 1:
             found_str += ' (%d times each: --repeat-each=%d --iterations=%d)' % (repeat_each * iterations, repeat_each, iterations)
-        found_str += ', skipping %d' % (num_all_test_files - num_to_run)
+        found_str += ', skipping %d' % (num_all_test_files - num_unique_tests)
         self._print_default(found_str + '.')