Changeset 127997 in webkit

Timestamp:

Sep 9, 2012 2:21:10 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Unreviewed, rolling out r127979.
​http://trac.webkit.org/changeset/127979
​https://bugs.webkit.org/show_bug.cgi?id=96217

Appears to have broken the windows and linux builds (Requested
by jamesr_ on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-09

• bindings/scripts/CodeGeneratorV8.pm:

(NativeToJSValue):

• bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::convertEventTargetToV8Object):
(V8DOMWrapper):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/scripts/CodeGeneratorV8.pm (modified) (1 diff)
• bindings/v8/V8DOMWrapper.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r127979.
+        http://trac.webkit.org/changeset/127979
+        https://bugs.webkit.org/show_bug.cgi?id=96217
+
+        Appears to have broken the windows and linux builds (Requested
+        by jamesr_ on #webkit).
+
+        * bindings/scripts/CodeGeneratorV8.pm:
+        (NativeToJSValue):
+        * bindings/v8/V8DOMWrapper.h:
+        (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
+        (V8DOMWrapper):
+
 2012-09-09  James Robinson  <jamesr@chromium.org>
 

trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm

@@ -4063 +4063 @@
 
     if ($type eq "EventTarget") {
-        return "V8DOMWrapper::convertEventTargetToV8Object(WTF::getPtr($value)$getCreationContextArg$getIsolateArg)";
+        return "V8DOMWrapper::convertEventTargetToV8Object($value$getCreationContextArg$getIsolateArg)";
     }
 

trunk/Source/WebCore/bindings/v8/V8DOMWrapper.h

@@ -81 +81 @@
 
         static WrapperTypeInfo* domWrapperType(v8::Handle<v8::Object>);
+
+        static v8::Handle<v8::Value> convertEventTargetToV8Object(PassRefPtr<EventTarget> eventTarget, v8::Handle<v8::Object> creationContext = v8::Handle<v8::Object>(), v8::Isolate* isolate = 0)
+        {
+            return convertEventTargetToV8Object(eventTarget.get(), creationContext, isolate);
+        }
 
         static v8::Handle<v8::Value> convertEventTargetToV8Object(EventTarget*, v8::Handle<v8::Object> creationContext = v8::Handle<v8::Object>(), v8::Isolate* = 0);