Changeset 128008 in webkit

Timestamp:

Sep 9, 2012 5:45:58 PM (12 years ago)

Author:

Patrick Gansterer

Message:

Replace WTF::numberToString() with String::numberToStringECMAScript()
​https://bugs.webkit.org/show_bug.cgi?id=96130

Reviewed by Benjamin Poulain.

The String class provides a nice wrapper for this function
in the meantime, so just use it to avoid code duplication.

• html/parser/HTMLParserIdioms.cpp:

(WebCore::serializeForNumberType):

• platform/Decimal.cpp:

(WebCore::Decimal::fromDouble):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/parser/HTMLParserIdioms.cpp (modified) (2 diffs)
• platform/Decimal.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-09-09  Patrick Gansterer  <paroga@webkit.org>
+
+        Replace WTF::numberToString() with String::numberToStringECMAScript()
+        https://bugs.webkit.org/show_bug.cgi?id=96130
+
+        Reviewed by Benjamin Poulain.
+
+        The String class provides a nice wrapper for this function
+        in the meantime, so just use it to avoid code duplication.
+
+        * html/parser/HTMLParserIdioms.cpp:
+        (WebCore::serializeForNumberType):
+        * platform/Decimal.cpp:
+        (WebCore::Decimal::fromDouble):
+
 2012-09-09  Emil A Eklund  <eae@chromium.org>
 

trunk/Source/WebCore/html/parser/HTMLParserIdioms.cpp

@@ -29 +29 @@
 #include <limits>
 #include <wtf/MathExtras.h>
-#include <wtf/dtoa.h>
 #include <wtf/text/AtomicString.h>
 #include <wtf/text/StringBuilder.h>
@@ -88 +87 @@
     // According to HTML5, "the best representation of the number n as a floating
     // point number" is a string produced by applying ToString() to n.
-    NumberToStringBuffer buffer;
-    return String(numberToString(number, buffer));
+    return String::numberToStringECMAScript(number);
 }
 

trunk/Source/WebCore/platform/Decimal.cpp

@@ -38 +38 @@
 #include <wtf/MathExtras.h>
 #include <wtf/Noncopyable.h>
-#include <wtf/dtoa.h>
 #include <wtf/text/StringBuilder.h>
 
@@ -682 +681 @@
 Decimal Decimal::fromDouble(double doubleValue)
 {
-    if (isfinite(doubleValue)) {
-        NumberToStringBuffer buffer;
-        return fromString(numberToString(doubleValue, buffer));
-    }
+    if (isfinite(doubleValue))
+        return fromString(String::numberToStringECMAScript(doubleValue));
 
     if (isinf(doubleValue))