Changeset 128018 in webkit


Ignore:
Timestamp:
Sep 9, 2012 11:22:35 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

successCallback of ResolveLocalFileSystemURL should not be optional.
​https://bugs.webkit.org/show_bug.cgi?id=94802

Patch by Taiju Tsuiki <​tzik@chromium.org> on 2012-09-09
Reviewed by Kent Tamura.

Spec says it should not optional.
​http://www.w3.org/TR/file-system-api/#widl-LocalFileSystem-resolveLocalFileSystemURL-void-DOMString-url-EntryCallback-successCallback-ErrorCallback-errorCallback

Source/WebCore:

Tests: fast/filesystem/entry-points-missing-arguments.html

  • Modules/filesystem/DOMWindowFileSystem.idl:
  • Modules/filesystem/WorkerContextFileSystem.idl:

LayoutTests:

  • fast/filesystem/entry-points-missing-arguments-expected.txt: Added.
  • fast/filesystem/entry-points-missing-arguments.html: Added.
  • fast/filesystem/filesystem-no-callback-null-ptr-crash.html:
Location:
trunk
Files:
2 added
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r128017 r128018  
     12012-09-09  Taiju Tsuiki  <tzik@chromium.org>
     2
     3        successCallback of ResolveLocalFileSystemURL should not be optional.
     4        https://bugs.webkit.org/show_bug.cgi?id=94802
     5
     6        Reviewed by Kent Tamura.
     7
     8        Spec says it should not optional.
     9        http://www.w3.org/TR/file-system-api/#widl-LocalFileSystem-resolveLocalFileSystemURL-void-DOMString-url-EntryCallback-successCallback-ErrorCallback-errorCallback
     10
     11        * fast/filesystem/entry-points-missing-arguments-expected.txt: Added.
     12        * fast/filesystem/entry-points-missing-arguments.html: Added.
     13        * fast/filesystem/filesystem-no-callback-null-ptr-crash.html:
     14
    1152012-09-09  Csaba Osztrogonác  <ossy@webkit.org>
    216

  • trunk/LayoutTests/fast/filesystem/filesystem-no-callback-null-ptr-crash.html

    r120798 r128018  
    99  if (window.webkitRequestFileSystem) {
    1010      // These two calls should throw an exception but should NOT cause a NULL pointer crash:
    11       webkitResolveLocalFileSystemURL('');
     11      webkitResolveLocalFileSystemURL('', function() {});
    1212      try {
    1313          webkitRequestFileSystem(TEMPORARY, 100);

  • trunk/Source/WebCore/ChangeLog

    r128014 r128018  
     12012-09-09  Taiju Tsuiki  <tzik@chromium.org>
     2
     3        successCallback of ResolveLocalFileSystemURL should not be optional.
     4        https://bugs.webkit.org/show_bug.cgi?id=94802
     5
     6        Reviewed by Kent Tamura.
     7
     8        Spec says it should not optional.
     9        http://www.w3.org/TR/file-system-api/#widl-LocalFileSystem-resolveLocalFileSystemURL-void-DOMString-url-EntryCallback-successCallback-ErrorCallback-errorCallback
     10
     11        Tests: fast/filesystem/entry-points-missing-arguments.html
     12
     13        * Modules/filesystem/DOMWindowFileSystem.idl:
     14        * Modules/filesystem/WorkerContextFileSystem.idl:
     15
    1162012-09-09  Patrick Gansterer  <paroga@webkit.org>
    217

  • trunk/Source/WebCore/Modules/filesystem/DOMWindowFileSystem.idl

    r110957 r128018  
    3737                in [Callback] FileSystemCallback successCallback, in [Callback, Optional] ErrorCallback errorCallback);
    3838        [V8EnabledAtRuntime=FileSystem] void webkitResolveLocalFileSystemURL(in DOMString url,
    39                 in [Callback, Optional] EntryCallback successCallback, in [Callback, Optional] ErrorCallback errorCallback);
     39                in [Callback] EntryCallback successCallback, in [Callback, Optional] ErrorCallback errorCallback);
    4040    };
    4141

  • trunk/Source/WebCore/Modules/filesystem/WorkerContextFileSystem.idl

    r111075 r128018  
    3636        [V8EnabledAtRuntime=FileSystem] void webkitRequestFileSystem(in unsigned short type, in long long size, in [Callback, Optional] FileSystemCallback successCallback, in [Callback, Optional] ErrorCallback errorCallback);
    3737        [V8EnabledAtRuntime=FileSystem] DOMFileSystemSync webkitRequestFileSystemSync(in unsigned short type, in long long size) raises (FileException);
    38         [V8EnabledAtRuntime=FileSystem] void webkitResolveLocalFileSystemURL(in DOMString url, in [Callback, Optional] EntryCallback successCallback, in [Callback, Optional] ErrorCallback errorCallback);
     38        [V8EnabledAtRuntime=FileSystem] void webkitResolveLocalFileSystemURL(in DOMString url, in [Callback] EntryCallback successCallback, in [Callback, Optional] ErrorCallback errorCallback);
    3939        [V8EnabledAtRuntime=FileSystem] EntrySync webkitResolveLocalFileSystemSyncURL(in DOMString url) raises (FileException);
    4040
Note: See TracChangeset for help on using the changeset viewer.