Changeset 128030 in webkit


Ignore:
Timestamp:
Sep 10, 2012 1:16:32 AM (12 years ago)
Author:
commit-queue@webkit.org
Message:

[WK2] New fast/forms/number/number-interactive-validation-required.html fails
​https://bugs.webkit.org/show_bug.cgi?id=95936

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-10
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add WKPreference private API for manipulate the interactive form
validation setting. This is now needed by WebKitTestRunner.

  • Shared/WebPreferencesStore.h:

(WebKit):

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetInteractiveFormValidationEnabled):
(WKPreferencesGetInteractiveFormValidationEnabled):

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Tools:

Enable interactive form validation setting in WebKitTestRunner as
we are currently doing in DumpRenderTree. This is needed for some
tests to pass.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

LayoutTests:

Unskip fast/forms/number/number-interactive-validation-required.html for
several WebKit2 ports now that the interactive form validation setting is
enabled in WebKitTestRunner.

  • platform/efl-wk2/TestExpectations:
  • platform/qt-5.0-wk2/Skipped:
Location:
trunk
Files:
10 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r128029 r128030  
     12012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
     2
     3        [WK2] New fast/forms/number/number-interactive-validation-required.html fails
     4        https://bugs.webkit.org/show_bug.cgi?id=95936
     5
     6        Reviewed by Kenneth Rohde Christiansen.
     7
     8        Unskip fast/forms/number/number-interactive-validation-required.html for
     9        several WebKit2 ports now that the interactive form validation setting is
     10        enabled in WebKitTestRunner.
     11
     12        * platform/efl-wk2/TestExpectations:
     13        * platform/qt-5.0-wk2/Skipped:
     14
     152012-09-10  Csaba Osztrogonác  <ossy@webkit.org>
     16
     17        [Qt][WK2] REGRESSION(r127861): It made one test fail and one test crash
     18        https://bugs.webkit.org/show_bug.cgi?id=96243
     19
     20        Unreviewed gardening, skip new failing and crashing tests to paint the bot green.
     21
     22        * platform/qt-5.0-wk2/Skipped:
     23
     242012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
     25
     26        [EFL] Several fast/block test cases need rebaseline after r127163
     27        https://bugs.webkit.org/show_bug.cgi?id=96237
     28
     29        Unreviewed EFL gardening.
     30
     31        Rebaseline 4 fast/block test cases due to r127163.
     32
     33        * platform/efl/TestExpectations:
     34        * platform/efl/fast/block/float/024-expected.png:
     35        * platform/efl/fast/block/float/024-expected.txt:
     36        * platform/efl/fast/block/margin-collapse/025-expected.txt:
     37        * platform/efl/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
     38        * platform/efl/fast/block/margin-collapse/empty-clear-blocks-expected.png:
     39        * platform/efl/fast/block/margin-collapse/empty-clear-blocks-expected.txt:
     40
     412012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
     42
     43        [EFL] Add baseline for css3/masking test cases
     44        https://bugs.webkit.org/show_bug.cgi?id=96235
     45
     46        Unreviewed EFL gardening.
     47
     48        Generate baselines for css3/masking test cases added
     49        in r127608.
     50
     51        * platform/efl/TestExpectations:
     52        * platform/efl/css3/masking/clip-path-circle-expected.png: Added.
     53        * platform/efl/css3/masking/clip-path-circle-expected.txt: Added.
     54        * platform/efl/css3/masking/clip-path-circle-filter-expected.png: Added.
     55        * platform/efl/css3/masking/clip-path-circle-filter-expected.txt: Added.
     56        * platform/efl/css3/masking/clip-path-circle-overflow-expected.png: Added.
     57        * platform/efl/css3/masking/clip-path-circle-overflow-expected.txt: Added.
     58        * platform/efl/css3/masking/clip-path-circle-overflow-hidden-expected.png: Added.
     59        * platform/efl/css3/masking/clip-path-circle-overflow-hidden-expected.txt: Added.
     60        * platform/efl/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
     61        * platform/efl/css3/masking/clip-path-circle-relative-overflow-expected.txt: Added.
     62        * platform/efl/css3/masking/clip-path-ellipse-expected.png: Added.
     63        * platform/efl/css3/masking/clip-path-ellipse-expected.txt: Added.
     64        * platform/efl/css3/masking/clip-path-polygon-evenodd-expected.png: Added.
     65        * platform/efl/css3/masking/clip-path-polygon-evenodd-expected.txt: Added.
     66        * platform/efl/css3/masking/clip-path-polygon-expected.png: Added.
     67        * platform/efl/css3/masking/clip-path-polygon-expected.txt: Added.
     68        * platform/efl/css3/masking/clip-path-polygon-nonzero-expected.png: Added.
     69        * platform/efl/css3/masking/clip-path-polygon-nonzero-expected.txt: Added.
     70        * platform/efl/css3/masking/clip-path-rectangle-expected.png: Added.
     71        * platform/efl/css3/masking/clip-path-rectangle-expected.txt: Added.
     72
    1732012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
    274

  • trunk/LayoutTests/platform/efl-wk2/TestExpectations

    r127990 r128030  
    153153BUGWKEFL : fast/events/popup-blocking-click-in-iframe.html = TEXT
    154154
    155 // Interactive form validation setting is not enabled in WebKitTestRunner
    156 BUGWK95936 : fast/forms/number/number-interactive-validation-required.html = TEXT
    157 
    158155// WebKitTestRunner eventSender needs touch events support
    159156BUGWKEFL : fast/events/touch/basic-multi-touch-events-limited.html = TEXT

  • trunk/LayoutTests/platform/qt-5.0-wk2/Skipped

    r128026 r128030  
    497497http/tests/security/cross-origin-plugin.html
    498498
    499 # [Qt][WK2] New fast/forms/number/number-interactive-validation-required.html fails
    500 # https://bugs.webkit.org/show_bug.cgi?id=95936
    501 fast/forms/number/number-interactive-validation-required.html
    502 
    503499# ENABLE(OVERFLOW_SCROLLING) is disabled (not enabled)
    504500compositing/overflow/overflow-auto-with-touch-toggle.html

  • trunk/Source/WebKit2/ChangeLog

    r128021 r128030  
     12012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
     2
     3        [WK2] New fast/forms/number/number-interactive-validation-required.html fails
     4        https://bugs.webkit.org/show_bug.cgi?id=95936
     5
     6        Reviewed by Kenneth Rohde Christiansen.
     7
     8        Add WKPreference private API for manipulate the interactive form
     9        validation setting. This is now needed by WebKitTestRunner.
     10
     11        * Shared/WebPreferencesStore.h:
     12        (WebKit):
     13        * UIProcess/API/C/WKPreferences.cpp:
     14        (WKPreferencesSetInteractiveFormValidationEnabled):
     15        (WKPreferencesGetInteractiveFormValidationEnabled):
     16        * UIProcess/API/C/WKPreferencesPrivate.h:
     17        * WebProcess/WebPage/WebPage.cpp:
     18        (WebKit::WebPage::updatePreferences):
     19
    1202012-09-09  Sam Weinig  <sam@webkit.org>
    221

  • trunk/Source/WebKit2/Shared/WebPreferencesStore.h

    r127966 r128030  
    125125    macro(ArtificialPluginInitializationDelayEnabled, artificialPluginInitializationDelayEnabled, Bool, bool, false) \
    126126    macro(TabToLinksEnabled, tabToLinksEnabled, Bool, bool, false) \
     127    macro(InteractiveFormValidationEnabled, interactiveFormValidationEnabled, Bool, bool, false) \
    127128    macro(ScrollingPerformanceLoggingEnabled, scrollingPerformanceLoggingEnabled, Bool, bool, false) \
    128129    macro(StorageBlockingPolicy, storageBlockingPolicy, UInt32, uint32_t, 0) \

  • trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp

    r127966 r128030  
    885885}
    886886
     887void WKPreferencesSetInteractiveFormValidationEnabled(WKPreferencesRef preferencesRef, bool enabled)
     888{
     889    toImpl(preferencesRef)->setInteractiveFormValidationEnabled(enabled);
     890}
     891
     892bool WKPreferencesGetInteractiveFormValidationEnabled(WKPreferencesRef preferencesRef)
     893{
     894    return toImpl(preferencesRef)->interactiveFormValidationEnabled();
     895}
     896
    887897void WKPreferencesSetScrollingPerformanceLoggingEnabled(WKPreferencesRef preferencesRef, bool enabled)
    888898{

  • trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h

    r127966 r128030  
    209209
    210210// Defaults to false
     211WK_EXPORT void WKPreferencesSetInteractiveFormValidationEnabled(WKPreferencesRef preferencesRef, bool enabled);
     212WK_EXPORT bool WKPreferencesGetInteractiveFormValidationEnabled(WKPreferencesRef preferencesRef);
     213
     214// Defaults to false
    211215WK_EXPORT void WKPreferencesSetScrollingPerformanceLoggingEnabled(WKPreferencesRef preferencesRef, bool enabled);
    212216WK_EXPORT bool WKPreferencesGetScrollingPerformanceLoggingEnabled(WKPreferencesRef preferencesRef);

  • trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp

    r128006 r128030  
    20732073    settings->setEnableScrollAnimator(store.getBoolValueForKey(WebPreferencesKey::scrollAnimatorEnabledKey()));
    20742074#endif
     2075    settings->setInteractiveFormValidationEnabled(store.getBoolValueForKey(WebPreferencesKey::interactiveFormValidationEnabledKey()));
    20752076
    20762077    // <rdar://problem/10697417>: It is necessary to force compositing when accelerate drawing

  • trunk/Tools/ChangeLog

    r128020 r128030  
     12012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
     2
     3        [WK2] New fast/forms/number/number-interactive-validation-required.html fails
     4        https://bugs.webkit.org/show_bug.cgi?id=95936
     5
     6        Reviewed by Kenneth Rohde Christiansen.
     7
     8        Enable interactive form validation setting in WebKitTestRunner as
     9        we are currently doing in DumpRenderTree. This is needed for some
     10        tests to pass.
     11
     12        * WebKitTestRunner/TestController.cpp:
     13        (WTR::TestController::resetStateToConsistentValues):
     14
    1152012-09-09  Zan Dobersek  <zandobersek@gmail.com>
    216

  • trunk/Tools/WebKitTestRunner/TestController.cpp

    r127966 r128030  
    477477    WKPreferencesSetArtificialPluginInitializationDelayEnabled(preferences, false);
    478478    WKPreferencesSetTabToLinksEnabled(preferences, false);
     479    WKPreferencesSetInteractiveFormValidationEnabled(preferences, true);
    479480
    480481// [Qt][WK2]REGRESSION(r104881):It broke hundreds of tests
Note: See TracChangeset for help on using the changeset viewer.