Changeset 128032 in webkit

Timestamp:

Sep 10, 2012 1:57:27 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL] fast/forms/menulist-restrict-line-height.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=94878

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-10
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

<select> element's text is no longer clipped when a CSS
line-height is specified. The fix is the same as for
Mac port in r24886.

Test: fast/forms/menulist-restrict-line-height.html

• platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::adjustMenuListStyle):

LayoutTests:

Generate baseline for fast/forms/menulist-restrict-line-height.html
and unskip the test now that <select> element's text is no longer
clipped when a CSS line-height is specified.

• platform/efl/TestExpectations:
• platform/efl/fast/forms/menulist-restrict-line-height-expected.png: Added.
• platform/efl/fast/forms/menulist-restrict-line-height-expected.txt: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/efl/TestExpectations (modified) (1 diff)
• LayoutTests/platform/efl/fast/forms/menulist-restrict-line-height-expected.png (added)
• LayoutTests/platform/efl/fast/forms/menulist-restrict-line-height-expected.txt (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/efl/RenderThemeEfl.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
+
+        [EFL] fast/forms/menulist-restrict-line-height.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=94878
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Generate baseline for fast/forms/menulist-restrict-line-height.html
+        and unskip the test now that <select> element's text is no longer
+        clipped when a CSS line-height is specified.
+
+        * platform/efl/TestExpectations:
+        * platform/efl/fast/forms/menulist-restrict-line-height-expected.png: Added.
+        * platform/efl/fast/forms/menulist-restrict-line-height-expected.txt: Added.
+
 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
 

trunk/LayoutTests/platform/efl/TestExpectations

@@ -1024 +1024 @@
 BUGWK94877 : fast/forms/listbox-hit-test-zoomed.html = MISSING
 
-// The text in the popup button is clipped.
-BUGWK94878 : fast/forms/menulist-restrict-line-height.html = MISSING
-
 // Cancel mark in search field is not working.
 BUGWK94880 : fast/forms/search-cancel-button-style-sharing.html = MISSING

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
+
+        [EFL] fast/forms/menulist-restrict-line-height.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=94878
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        <select> element's text is no longer clipped when a CSS
+        line-height is specified. The fix is the same as for
+        Mac port in r24886.
+
+        Test: fast/forms/menulist-restrict-line-height.html
+
+        * platform/efl/RenderThemeEfl.cpp:
+        (WebCore::RenderThemeEfl::adjustMenuListStyle):
+
 2012-09-10  Kevin Funk  <kevin.funk@kdab.com>
 

trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp

@@ -898 +898 @@
     style->resetBorder();
     style->setWhiteSpace(PRE);
+
+    style->setLineHeight(RenderStyle::initialLineHeight());
 }