Changeset 128058 in webkit


Ignore:
Timestamp:
Sep 10, 2012 7:03:23 AM (12 years ago)
Author:
commit-queue@webkit.org
Message:

[chromium] Don't use WebGestureEvent.boundingBox for touch adjustment
https://bugs.webkit.org/show_bug.cgi?id=95996

Patch by Rick Byers <rbyers@chromium.org> on 2012-09-10
Reviewed by Adam Barth.

Switch from WebGestureEvent.boundingBox to new gesture-type specific
data fields.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):

Location:
trunk/Source/WebKit/chromium
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/chromium/ChangeLog

    r128016 r128058  
     12012-09-10  Rick Byers  <rbyers@chromium.org>
     2
     3        [chromium] Don't use WebGestureEvent.boundingBox for touch adjustment
     4        https://bugs.webkit.org/show_bug.cgi?id=95996
     5
     6        Reviewed by Adam Barth.
     7
     8        Switch from WebGestureEvent.boundingBox to new gesture-type specific
     9        data fields.
     10        * src/WebViewImpl.cpp:
     11        (WebKit::WebViewImpl::handleGestureEvent):
     12
    1132012-09-09  Keishi Hattori  <keishi@webkit.org>
    214
  • trunk/Source/WebKit/chromium/src/WebViewImpl.cpp

    r128006 r128058  
    712712        ASSERT(!m_selectPopup);
    713713
    714         if (!event.boundingBox.isEmpty()) {
     714        if (event.data.tap.width > 0) {
     715            IntRect boundingBox(event.x - event.data.tap.width / 2, event.y - event.data.tap.height / 2, event.data.tap.width, event.data.tap.height);
    715716            Vector<IntRect> goodTargets;
    716             findGoodTouchTargets(event.boundingBox, mainFrameImpl()->frame(), pageScaleFactor(), goodTargets);
     717            findGoodTouchTargets(boundingBox, mainFrameImpl()->frame(), pageScaleFactor(), goodTargets);
    717718            // FIXME: replace touch adjustment code when numberOfGoodTargets == 1?
    718719            // Single candidate case is currently handled by: https://bugs.webkit.org/show_bug.cgi?id=85101
  • trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp

    r127776 r128058  
    12771277    event.x = x;
    12781278    event.y = y;
    1279     event.boundingBox = WebCore::IntRect(x - 25, y - 25, 50, 50);
     1279    event.data.tap.width = 50;
     1280    event.data.tap.height = 50;
    12801281    return event;
    12811282}
Note: See TracChangeset for help on using the changeset viewer.