Changeset 128078 in webkit


Ignore:
Timestamp:
Sep 10, 2012 10:42:39 AM (12 years ago)
Author:
robert@webkit.org
Message:

CSS 2.1 failure: content-counter-010.htm fails
​https://bugs.webkit.org/show_bug.cgi?id=81447

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: fast/css/content-counter-010.htm

Per ​http://lists.w3.org/Archives/Public/public-css-testsuite/2010Nov/0064.html, the correct rendering of
7000 to 7999 in Armenian changed in Nov 2010. Update implementation to match the revised spec.

  • rendering/RenderListMarker.cpp:

(WebCore::toArmenianUnder10000):

LayoutTests:

  • fast/css/content-counter-010-expected.html: Added.
  • fast/css/content-counter-010.htm: Added. Note that <meta http-equiv="Content-Type" content="text/html; charset=utf-8" was added to the suite test to allow it to render correctly from a file:/ url.
  • fast/lists/w3-css3-lower-armenian-expected.txt:
  • fast/lists/w3-css3-lower-armenian.html:
  • fast/lists/w3-css3-upper-armenian-expected.txt:
  • fast/lists/w3-css3-upper-armenian.html: Amended tests to conform to revised specification for numbers between 7000 and 7999.
Location:
trunk
Files:
2 added
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r128076 r128078  
     12012-09-04  Robert Hogan  <robert@webkit.org>
     2
     3        CSS 2.1 failure: content-counter-010.htm fails
     4        https://bugs.webkit.org/show_bug.cgi?id=81447
     5
     6        Reviewed by Alexey Proskuryakov.
     7
     8        * fast/css/content-counter-010-expected.html: Added.
     9        * fast/css/content-counter-010.htm: Added.
     10          Note that <meta http-equiv="Content-Type" content="text/html; charset=utf-8"  was added to the suite test
     11          to allow it to render correctly from a file:/ url.
     12        * fast/lists/w3-css3-lower-armenian-expected.txt:
     13        * fast/lists/w3-css3-lower-armenian.html:
     14        * fast/lists/w3-css3-upper-armenian-expected.txt:
     15        * fast/lists/w3-css3-upper-armenian.html:
     16          Amended tests to conform to revised specification for numbers between 7000 and 7999.
     17
    1182012-09-10  Thiago Marcos P. Santos  <thiago.santos@intel.com>
    219

  • trunk/LayoutTests/fast/lists/w3-css3-lower-armenian-expected.txt

    r73338 r128078  
    3232PASS list marker is ռպկե.
    3333PASS list marker is րպկե.
    34 PASS list marker is ուե.
    35 PASS list marker is ուպ.
    36 PASS list marker is ուպկե.
     34PASS list marker is ւե.
     35PASS list marker is ւպ.
     36PASS list marker is ւպկե.
    3737PASS list marker is քջղթ.
    3838

  • trunk/LayoutTests/fast/lists/w3-css3-lower-armenian.html

    r122687 r128078  
    2323    <h1>CSS3 Lower Armenian</h1>
    2424    <div id="description">This test was derived from Richard Ishida's test "lower-armenian, up to 9,999" listed at <a href="http://www.w3.org/International/tests/tests-html-css/list-lists">http://www.w3.org/International/tests/tests-html-css/list-lists</a> (last updated 04/12/2010) and as it appeared when accessed on 11/16/2010. This test PASSED if the list item matches its bullet for every list item (below).
     25    The test was updated under https://bugs.webkit.org/show_bug.cgi?id=81447 to reflect the revised rendering of numbers 7000-7999 which now begin with Ւ rather than ՈՒ.
    2526    <p>Distributed under both the <a href="http://www.w3.org/Consortium/Legal/2008/04-testsuite-license">W3C Test Suite License</a> and the <a href="http://www.w3.org/Consortium/Legal/2008/03-bsd-license">W3C 3-clause BSD License</a>. To contribute to a W3C Test Suite, see the <a href="http://www.w3.org/2004/10/27-testcases">policies and contribution forms</a>.</p>   
    2627    </div>
    … …  
    8788        </ol>
    8889        <ol class="lower-armenian" start="7005">
    89             <li>ուե</li>
     90            <li>ւե</li>
    9091        </ol>
    9192        <ol class="lower-armenian" start="7800">
    92             <li>ուպ</li>
     93            <li>ւպ</li>
    9394        </ol>
    9495        <ol class="lower-armenian" start="7865">
    95             <li>ուպկե</li>
     96            <li>ւպկե</li>
    9697        </ol>
    9798        <ol class="lower-armenian" start="9999">

  • trunk/LayoutTests/fast/lists/w3-css3-upper-armenian-expected.txt

    r73338 r128078  
    3232PASS list marker is ՌՊԿԵ.
    3333PASS list marker is ՐՊԿԵ.
    34 PASS list marker is ՈՒԵ.
    35 PASS list marker is ՈՒՊ.
    36 PASS list marker is ՈՒՊԿԵ.
     34PASS list marker is ՒԵ.
     35PASS list marker is ՒՊ.
     36PASS list marker is ՒՊԿԵ.
    3737PASS list marker is ՔՋՂԹ.
    3838

  • trunk/LayoutTests/fast/lists/w3-css3-upper-armenian.html

    r122687 r128078  
    2222<body>
    2323    <h1>CSS3 Upper Armenian</h1>
    24     <div id="description">This test was derived from Richard Ishida's test "upper-armenian, up to 9,999" listed at <a href="http://www.w3.org/International/tests/tests-html-css/list-lists">http://www.w3.org/International/tests/tests-html-css/list-lists</a> (last updated 04/12/2010) and as it appeared when accessed on 11/17/2010. This test PASSED if the list item matches its bullet for every list item (below).
     24    <div id="description">This test was derived from Richard Ishida's test "upper-armenian, up to 9,999" listed at <a href="http://www.w3.org/International/tests/tests-html-css/list-lists">http://www.w3.org/International/tests/tests-html-css/list-lists</a> (last updated 04/12/2010) and as it appeared when accessed on 11/17/2010. This test PASSED if the list item matches its bullet for every list item (below).
     25    The test was updated under https://bugs.webkit.org/show_bug.cgi?id=81447 to reflect the revised rendering of numbers 7000-7999 which now begin with Ւ rather than ՈՒ.
    2526    <p>Distributed under both the <a href="http://www.w3.org/Consortium/Legal/2008/04-testsuite-license">W3C Test Suite License</a> and the <a href="http://www.w3.org/Consortium/Legal/2008/03-bsd-license">W3C 3-clause BSD License</a>. To contribute to a W3C Test Suite, see the <a href="http://www.w3.org/2004/10/27-testcases">policies and contribution forms</a>.</p>
    2627    </div>
    … …  
    8788        </ol>
    8889        <ol class="upper-armenian" start="7005">
    89             <li>ՈՒԵ</li>
     90            <li>ՒԵ</li>
    9091        </ol>
    9192        <ol class="upper-armenian" start="7800">
    92             <li>ՈՒՊ</li>
     93            <li>ՒՊ</li>
    9394        </ol>
    9495        <ol class="upper-armenian" start="7865">
    95             <li>ՈՒՊԿԵ</li>
     96            <li>ՒՊԿԵ</li>
    9697        </ol>
    9798        <ol class="upper-armenian" start="9999">

  • trunk/Source/WebCore/ChangeLog

    r128076 r128078  
     12012-09-04  Robert Hogan  <robert@webkit.org>
     2
     3        CSS 2.1 failure: content-counter-010.htm fails
     4        https://bugs.webkit.org/show_bug.cgi?id=81447
     5
     6        Reviewed by Alexey Proskuryakov.
     7
     8        Test: fast/css/content-counter-010.htm
     9
     10        Per http://lists.w3.org/Archives/Public/public-css-testsuite/2010Nov/0064.html, the correct rendering of
     11        7000 to 7999 in Armenian changed in Nov 2010. Update implementation to match the revised spec.
     12       
     13        * rendering/RenderListMarker.cpp:
     14        (WebCore::toArmenianUnder10000):
     15
    1162012-09-10  Thiago Marcos P. Santos  <thiago.santos@intel.com>
    217

  • trunk/Source/WebCore/rendering/RenderListMarker.cpp

    r126359 r128078  
    223223    if (int thousands = number / 1000) {
    224224        if (thousands == 7) {
    225             letters[length++] = 0x0548 + lowerOffset;
    226225            letters[length++] = 0x0552 + lowerOffset;
    227226            if (addCircumflex)
Note: See TracChangeset for help on using the changeset viewer.