Changeset 128093 in webkit


Ignore:
Timestamp:
Sep 10, 2012 1:09:45 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

Source/WebKit/chromium: [chromium] Add unused GestureTapCancel
https://bugs.webkit.org/show_bug.cgi?id=96183

Patch by Rick Byers <rbyers@chromium.org> on 2012-09-10
Reviewed by Adam Barth.

This adds a new 'tap cancel' gesture type. This is temporarily unused,
so that we can change chromium to start sending the gesture type
without breaking anything.

  • public/WebInputEvent.h:
  • src/PageWidgetDelegate.cpp:

(WebKit::PageWidgetDelegate::handleInputEvent):

  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):

Tools: Add handling of new GestureTapCancel in DRT

https://bugs.webkit.org/show_bug.cgi?id=96183

Patch by Rick Byers <rbyers@chromium.org> on 2012-09-10
Reviewed by Adam Barth.

  • DumpRenderTree/chromium/TestWebPlugin.cpp:

(TestWebPlugin::handleInputEvent):

Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/chromium/ChangeLog

    r128087 r128093  
     12012-09-10  Rick Byers  <rbyers@chromium.org>
     2
     3        [chromium] Add unused GestureTapCancel
     4        https://bugs.webkit.org/show_bug.cgi?id=96183
     5
     6        Reviewed by Adam Barth.
     7
     8        This adds a new 'tap cancel' gesture type.  This is temporarily unused,
     9        so that we can change chromium to start sending the gesture type
     10        without breaking anything.
     11
     12        * public/WebInputEvent.h:
     13        * src/PageWidgetDelegate.cpp:
     14        (WebKit::PageWidgetDelegate::handleInputEvent):
     15        * src/WebInputEventConversion.cpp:
     16        (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
     17        * src/WebPopupMenuImpl.cpp:
     18        (WebKit::WebPopupMenuImpl::handleInputEvent):
     19        * src/WebViewImpl.cpp:
     20        (WebKit::WebViewImpl::handleGestureEvent):
     21
    1222012-09-10  Mark Pilgrim  <pilgrim@chromium.org>
    223
  • trunk/Source/WebKit/chromium/public/WebInputEvent.h

    r127767 r128093  
    117117        GestureTap,
    118118        GestureTapDown,
     119        GestureTapCancel,
    119120        GestureDoubleTap,
    120121        GestureTwoFingerTap,
     
    217218            || type == GestureTap
    218219            || type == GestureTapDown
     220            || type == GestureTapCancel
    219221            || type == GestureDoubleTap
    220222            || type == GestureTwoFingerTap
  • trunk/Source/WebKit/chromium/src/PageWidgetDelegate.cpp

    r120381 r128093  
    155155    case WebInputEvent::GestureTap:
    156156    case WebInputEvent::GestureTapDown:
     157    case WebInputEvent::GestureTapCancel:
    157158    case WebInputEvent::GestureDoubleTap:
    158159    case WebInputEvent::GestureTwoFingerTap:
  • trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp

    r126940 r128093  
    289289    case WebInputEvent::MouseEnter:
    290290    case WebInputEvent::ContextMenu:
     291    case WebInputEvent::GestureTapCancel:
    291292        return false;
    292293    }
  • trunk/Source/WebKit/chromium/src/WebViewImpl.cpp

    r128058 r128093  
    772772        return mainFrameImpl()->frame()->eventHandler()->handleGestureEvent(platformEvent);
    773773    }
     774    case WebInputEvent::GestureTapCancel:
     775        // FIXME: Update WebCore to handle this event after chromium has been updated to send it
     776        // http://wkb.ug/96060
     777        return false;
    774778    default:
    775779        ASSERT_NOT_REACHED();
  • trunk/Tools/ChangeLog

    r128088 r128093  
     12012-09-10  Rick Byers  <rbyers@chromium.org>
     2
     3        Add handling of new GestureTapCancel in DRT
     4       
     5        https://bugs.webkit.org/show_bug.cgi?id=96183
     6
     7        Reviewed by Adam Barth.
     8
     9        * DumpRenderTree/chromium/TestWebPlugin.cpp:
     10        (TestWebPlugin::handleInputEvent):
     11
    1122012-09-10  Brady Eidson  <beidson@apple.com>
    213
  • trunk/Tools/DumpRenderTree/chromium/TestWebPlugin.cpp

    r124098 r128093  
    393393    case WebKit::WebInputEvent::GestureTap:          eventName = "GestureTap"; break;
    394394    case WebKit::WebInputEvent::GestureTapDown:      eventName = "GestureTapDown"; break;
     395    case WebKit::WebInputEvent::GestureTapCancel:    eventName = "GestureTapCancel"; break;
    395396    case WebKit::WebInputEvent::GestureDoubleTap:    eventName = "GestureDoubleTap"; break;
    396397    case WebKit::WebInputEvent::GestureTwoFingerTap: eventName = "GestureTwoFingerTap"; break;
Note: See TracChangeset for help on using the changeset viewer.