Changeset 128107 in webkit


Ignore:
Timestamp:
Sep 10, 2012 2:41:14 PM (12 years ago)
Author:
tony@chromium.org
Message:

Remove stray spaces found after :: in case statements
​https://bugs.webkit.org/show_bug.cgi?id=96314

Reviewed by Ojan Vafai.

New contributors keep copy/pasting this style error and it makes me sad.
Also remove the extra spaces in MediaQueryEvaluator.cpp.

No new tests, this is just a style refactor.

  • css/CSSPrimitiveValue.cpp:

(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::unitCategory):

  • css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::MediaQueryEvaluator):

Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r128102 r128107  
     12012-09-10  Tony Chang  <tony@chromium.org>
     2
     3        Remove stray spaces found after :: in case statements
     4        https://bugs.webkit.org/show_bug.cgi?id=96314
     5
     6        Reviewed by Ojan Vafai.
     7
     8        New contributors keep copy/pasting this style error and it makes me sad.
     9        Also remove the extra spaces in MediaQueryEvaluator.cpp.
     10
     11        No new tests, this is just a style refactor.
     12
     13        * css/CSSPrimitiveValue.cpp:
     14        (WebCore::isValidCSSUnitTypeForDoubleConversion):
     15        (WebCore::unitCategory):
     16        * css/MediaQueryEvaluator.cpp:
     17        (WebCore::MediaQueryEvaluator::MediaQueryEvaluator):
     18
    1192012-09-10  Adam Barth  <abarth@webkit.org>
    220

  • trunk/Source/WebCore/css/CSSPrimitiveValue.cpp

    r127933 r128107  
    5757{
    5858    switch (unitType) {
    59     case CSSPrimitiveValue:: CSS_CALC:
    60     case CSSPrimitiveValue:: CSS_CALC_PERCENTAGE_WITH_NUMBER:
    61     case CSSPrimitiveValue:: CSS_CALC_PERCENTAGE_WITH_LENGTH:
    62     case CSSPrimitiveValue:: CSS_CM:
    63     case CSSPrimitiveValue:: CSS_DEG:
    64     case CSSPrimitiveValue:: CSS_DIMENSION:
     59    case CSSPrimitiveValue::CSS_CALC:
     60    case CSSPrimitiveValue::CSS_CALC_PERCENTAGE_WITH_NUMBER:
     61    case CSSPrimitiveValue::CSS_CALC_PERCENTAGE_WITH_LENGTH:
     62    case CSSPrimitiveValue::CSS_CM:
     63    case CSSPrimitiveValue::CSS_DEG:
     64    case CSSPrimitiveValue::CSS_DIMENSION:
    6565#if ENABLE(CSS_IMAGE_RESOLUTION)
    66     case CSSPrimitiveValue:: CSS_DPPX:
    67     case CSSPrimitiveValue:: CSS_DPI:
    68     case CSSPrimitiveValue:: CSS_DPCM:
    69 #endif
    70     case CSSPrimitiveValue:: CSS_EMS:
    71     case CSSPrimitiveValue:: CSS_EXS:
    72     case CSSPrimitiveValue:: CSS_GRAD:
    73     case CSSPrimitiveValue:: CSS_HZ:
    74     case CSSPrimitiveValue:: CSS_IN:
    75     case CSSPrimitiveValue:: CSS_KHZ:
    76     case CSSPrimitiveValue:: CSS_MM:
    77     case CSSPrimitiveValue:: CSS_MS:
    78     case CSSPrimitiveValue:: CSS_NUMBER:
    79     case CSSPrimitiveValue:: CSS_PERCENTAGE:
    80     case CSSPrimitiveValue:: CSS_PC:
    81     case CSSPrimitiveValue:: CSS_PT:
    82     case CSSPrimitiveValue:: CSS_PX:
    83     case CSSPrimitiveValue:: CSS_RAD:
    84     case CSSPrimitiveValue:: CSS_REMS:
    85     case CSSPrimitiveValue:: CSS_S:
    86     case CSSPrimitiveValue:: CSS_TURN:
    87     case CSSPrimitiveValue:: CSS_VW:
    88     case CSSPrimitiveValue:: CSS_VH:
    89     case CSSPrimitiveValue:: CSS_VMIN:
     66    case CSSPrimitiveValue::CSS_DPPX:
     67    case CSSPrimitiveValue::CSS_DPI:
     68    case CSSPrimitiveValue::CSS_DPCM:
     69#endif
     70    case CSSPrimitiveValue::CSS_EMS:
     71    case CSSPrimitiveValue::CSS_EXS:
     72    case CSSPrimitiveValue::CSS_GRAD:
     73    case CSSPrimitiveValue::CSS_HZ:
     74    case CSSPrimitiveValue::CSS_IN:
     75    case CSSPrimitiveValue::CSS_KHZ:
     76    case CSSPrimitiveValue::CSS_MM:
     77    case CSSPrimitiveValue::CSS_MS:
     78    case CSSPrimitiveValue::CSS_NUMBER:
     79    case CSSPrimitiveValue::CSS_PERCENTAGE:
     80    case CSSPrimitiveValue::CSS_PC:
     81    case CSSPrimitiveValue::CSS_PT:
     82    case CSSPrimitiveValue::CSS_PX:
     83    case CSSPrimitiveValue::CSS_RAD:
     84    case CSSPrimitiveValue::CSS_REMS:
     85    case CSSPrimitiveValue::CSS_S:
     86    case CSSPrimitiveValue::CSS_TURN:
     87    case CSSPrimitiveValue::CSS_VW:
     88    case CSSPrimitiveValue::CSS_VH:
     89    case CSSPrimitiveValue::CSS_VMIN:
    9090        return true;
    91     case CSSPrimitiveValue:: CSS_ATTR:
    92     case CSSPrimitiveValue:: CSS_COUNTER:
    93     case CSSPrimitiveValue:: CSS_COUNTER_NAME:
     91    case CSSPrimitiveValue::CSS_ATTR:
     92    case CSSPrimitiveValue::CSS_COUNTER:
     93    case CSSPrimitiveValue::CSS_COUNTER_NAME:
    9494#if ENABLE(DASHBOARD_SUPPORT) || ENABLE(WIDGET_REGION)
    95     case CSSPrimitiveValue:: CSS_DASHBOARD_REGION:
     95    case CSSPrimitiveValue::CSS_DASHBOARD_REGION:
    9696#endif
    9797#if !ENABLE(CSS_IMAGE_RESOLUTION)
    98     case CSSPrimitiveValue:: CSS_DPPX:
    99     case CSSPrimitiveValue:: CSS_DPI:
    100     case CSSPrimitiveValue:: CSS_DPCM:
    101 #endif
    102     case CSSPrimitiveValue:: CSS_IDENT:
    103     case CSSPrimitiveValue:: CSS_PAIR:
    104     case CSSPrimitiveValue:: CSS_PARSER_HEXCOLOR:
    105     case CSSPrimitiveValue:: CSS_PARSER_IDENTIFIER:
    106     case CSSPrimitiveValue:: CSS_PARSER_INTEGER:
    107     case CSSPrimitiveValue:: CSS_PARSER_OPERATOR:
    108     case CSSPrimitiveValue:: CSS_RECT:
    109     case CSSPrimitiveValue:: CSS_QUAD:
    110     case CSSPrimitiveValue:: CSS_RGBCOLOR:
    111     case CSSPrimitiveValue:: CSS_SHAPE:
    112     case CSSPrimitiveValue:: CSS_STRING:
    113     case CSSPrimitiveValue:: CSS_UNICODE_RANGE:
    114     case CSSPrimitiveValue:: CSS_UNKNOWN:
    115     case CSSPrimitiveValue:: CSS_URI:
     98    case CSSPrimitiveValue::CSS_DPPX:
     99    case CSSPrimitiveValue::CSS_DPI:
     100    case CSSPrimitiveValue::CSS_DPCM:
     101#endif
     102    case CSSPrimitiveValue::CSS_IDENT:
     103    case CSSPrimitiveValue::CSS_PAIR:
     104    case CSSPrimitiveValue::CSS_PARSER_HEXCOLOR:
     105    case CSSPrimitiveValue::CSS_PARSER_IDENTIFIER:
     106    case CSSPrimitiveValue::CSS_PARSER_INTEGER:
     107    case CSSPrimitiveValue::CSS_PARSER_OPERATOR:
     108    case CSSPrimitiveValue::CSS_RECT:
     109    case CSSPrimitiveValue::CSS_QUAD:
     110    case CSSPrimitiveValue::CSS_RGBCOLOR:
     111    case CSSPrimitiveValue::CSS_SHAPE:
     112    case CSSPrimitiveValue::CSS_STRING:
     113    case CSSPrimitiveValue::CSS_UNICODE_RANGE:
     114    case CSSPrimitiveValue::CSS_UNKNOWN:
     115    case CSSPrimitiveValue::CSS_URI:
    116116#if ENABLE(CSS_VARIABLES)
    117     case CSSPrimitiveValue:: CSS_VARIABLE_NAME:
     117    case CSSPrimitiveValue::CSS_VARIABLE_NAME:
    118118#endif
    119119        return false;
    … …  
    156156        return CSSPrimitiveValue::UViewportPercentageLength;
    157157#if ENABLE(CSS_IMAGE_RESOLUTION)
    158     case CSSPrimitiveValue:: CSS_DPPX:
    159     case CSSPrimitiveValue:: CSS_DPI:
    160     case CSSPrimitiveValue:: CSS_DPCM:
     158    case CSSPrimitiveValue::CSS_DPPX:
     159    case CSSPrimitiveValue::CSS_DPI:
     160    case CSSPrimitiveValue::CSS_DPCM:
    161161        return CSSPrimitiveValue::UResolution;
    162162#endif

  • trunk/Source/WebCore/css/MediaQueryEvaluator.cpp

    r121289 r128107  
    8383}
    8484
    85 MediaQueryEvaluator:: MediaQueryEvaluator(const String& acceptedMediaType, bool mediaFeatureResult)
     85MediaQueryEvaluator::MediaQueryEvaluator(const String& acceptedMediaType, bool mediaFeatureResult)
    8686    : m_mediaType(acceptedMediaType)
    8787    , m_frame(0)
    … …  
    9191}
    9292
    93 MediaQueryEvaluator:: MediaQueryEvaluator(const char* acceptedMediaType, bool mediaFeatureResult)
     93MediaQueryEvaluator::MediaQueryEvaluator(const char* acceptedMediaType, bool mediaFeatureResult)
    9494    : m_mediaType(acceptedMediaType)
    9595    , m_frame(0)
    … …  
    9999}
    100100
    101 MediaQueryEvaluator:: MediaQueryEvaluator(const String& acceptedMediaType, Frame* frame, RenderStyle* style)
     101MediaQueryEvaluator::MediaQueryEvaluator(const String& acceptedMediaType, Frame* frame, RenderStyle* style)
    102102    : m_mediaType(acceptedMediaType)
    103103    , m_frame(frame)
Note: See TracChangeset for help on using the changeset viewer.