Changeset 128127 in webkit

Timestamp:

Sep 10, 2012 4:23:36 PM (12 years ago)

Author:

abarth@webkit.org

Message:

[V8] V8PerIsolateData::m_toStringTemplate leaks memory
​https://bugs.webkit.org/show_bug.cgi?id=96322

Patch by Adam Barth <​abarth@chromium.org> on 2012-09-10
Reviewed by Kentaro Hara.

We never call Dispose to balance the call to v8::Persistent::New. This
patch uses ScopedPersistent to call Dispose automatically.

• bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::toStringTemplate):

• I've changed this function to return a new local handle in case anyone is trying to hold on to these handles during shutdown.

• bindings/v8/V8PerIsolateData.h:

(V8PerIsolateData):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/v8/V8PerIsolateData.cpp (modified) (1 diff)
• bindings/v8/V8PerIsolateData.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-09-10  Adam Barth  <abarth@chromium.org>
+
+        [V8] V8PerIsolateData::m_toStringTemplate leaks memory
+        https://bugs.webkit.org/show_bug.cgi?id=96322
+
+        Reviewed by Kentaro Hara.
+
+        We never call Dispose to balance the call to v8::Persistent::New. This
+        patch uses ScopedPersistent to call Dispose automatically.
+
+        * bindings/v8/V8PerIsolateData.cpp:
+        (WebCore::V8PerIsolateData::toStringTemplate):
+            - I've changed this function to return a new local handle in case
+              anyone is trying to hold on to these handles during shutdown.
+        * bindings/v8/V8PerIsolateData.h:
+        (V8PerIsolateData):
+
 2012-09-10  Adam Barth  <abarth@chromium.org>
 

trunk/Source/WebCore/bindings/v8/V8PerIsolateData.cpp

@@ -75 +75 @@
 }
 
+v8::Handle<v8::FunctionTemplate> V8PerIsolateData::toStringTemplate()
+{
+    if (m_toStringTemplate.isEmpty())
+        m_toStringTemplate.set(v8::FunctionTemplate::New(constructorOfToString));
+    return v8::Local<v8::FunctionTemplate>::New(m_toStringTemplate.get());
+}
+
 void V8PerIsolateData::reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const
 {

trunk/Source/WebCore/bindings/v8/V8PerIsolateData.h

@@ -72 +72 @@
     TemplateMap& templateMap() { return m_templates; }
 
-    v8::Persistent<v8::FunctionTemplate>& toStringTemplate()
-    {
-        if (m_toStringTemplate.IsEmpty())
-            m_toStringTemplate = v8::Persistent<v8::FunctionTemplate>::New(v8::FunctionTemplate::New(constructorOfToString));
-        return m_toStringTemplate;
-    }
-
+    v8::Handle<v8::FunctionTemplate> toStringTemplate();
     v8::Persistent<v8::FunctionTemplate>& lazyEventListenerToStringTemplate()
     {
@@ -144 +138 @@
     TemplateMap m_rawTemplates;
     TemplateMap m_templates;
-    v8::Persistent<v8::FunctionTemplate> m_toStringTemplate;
+    ScopedPersistent<v8::FunctionTemplate> m_toStringTemplate;
     v8::Persistent<v8::FunctionTemplate> m_lazyEventListenerToStringTemplate;
     OwnPtr<StringCache> m_stringCache;