Changeset 128156 in webkit

Timestamp:

Sep 11, 2012 1:15:20 AM (12 years ago)

Author:

keishi@webkit.org

Message:

Create Localizer factory method for LocaleMac
​https://bugs.webkit.org/show_bug.cgi?id=96355

Reviewed by Kent Tamura.

Source/WebCore:

Preparing to use Localizer instead of LocaleMac/Win/ICU

No new tests. Covered in unit test tests/LocaleMacTest.cpp

• platform/text/Localizer.h:

(Localizer):

• platform/text/mac/LocaleMac.mm:

(WebCore::Localizer::create):
(WebCore):

Source/WebKit/chromium:

• tests/LocaleMacTest.cpp:

(testNumberIsReversible): Use Localizer::create.
(testNumbers):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/text/Localizer.h (modified) (1 diff)
• WebCore/platform/text/mac/LocaleMac.mm (modified) (1 diff)
• WebKit/chromium/ChangeLog (modified) (1 diff)
• WebKit/chromium/tests/LocaleMacTest.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-09-11  Keishi Hattori  <keishi@webkit.org>
+
+        Create Localizer factory method for LocaleMac
+        https://bugs.webkit.org/show_bug.cgi?id=96355
+
+        Reviewed by Kent Tamura.
+
+        Preparing to use Localizer instead of LocaleMac/Win/ICU
+
+        No new tests. Covered in unit test tests/LocaleMacTest.cpp
+
+        * platform/text/Localizer.h:
+        (Localizer):
+        * platform/text/mac/LocaleMac.mm:
+        (WebCore::Localizer::create):
+        (WebCore):
+
 2012-09-11  Mihnea Ovidenie  <mihnea@adobe.com>
 

trunk/Source/WebCore/platform/text/Localizer.h

@@ -33 +33 @@
 class Localizer {
 public:
+    static PassOwnPtr<Localizer> create(const AtomicString&);
     String convertToLocalizedNumber(const String&);
     String convertFromLocalizedNumber(const String&);

trunk/Source/WebCore/platform/text/mac/LocaleMac.mm

@@ -46 +46 @@
 namespace WebCore {
 
+PassOwnPtr<Localizer> Localizer::create(const AtomicString& locale)
+{
+    return LocaleMac::create(locale.string());
+}
+
 static NSDateFormatter* createDateTimeFormatter(NSLocale* locale, NSDateFormatterStyle dateStyle, NSDateFormatterStyle timeStyle)
 {

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2012-09-11  Keishi Hattori  <keishi@webkit.org>
+
+        Create Localizer factory method for LocaleMac
+        https://bugs.webkit.org/show_bug.cgi?id=96355
+
+        Reviewed by Kent Tamura.
+
+        * tests/LocaleMacTest.cpp:
+        (testNumberIsReversible): Use Localizer::create.
+        (testNumbers):
+
 2012-09-11  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/WebKit/chromium/tests/LocaleMacTest.cpp

@@ -222 +222 @@
 #endif
 
-static void testNumberIsReversible(const String& localeString, const char* original, const char* shouldHave = 0)
-{
-    OwnPtr<LocaleMac> locale = LocaleMac::create(localeString);
+static void testNumberIsReversible(const AtomicString& localeString, const char* original, const char* shouldHave = 0)
+{
+    OwnPtr<Localizer> locale = Localizer::create(localeString);
     String localized = locale->convertToLocalizedNumber(original);
     if (shouldHave)
@@ -232 +232 @@
 }
 
-void testNumbers(const String& localeString, const char* decimalSeparatorShouldBe = 0)
+void testNumbers(const AtomicString& localeString, const char* decimalSeparatorShouldBe = 0)
 {
     testNumberIsReversible(localeString, "123456789012345678901234567890");