Changeset 128171 in webkit

Timestamp:

Sep 11, 2012 4:54:59 AM (12 years ago)

Author:

apavlov@chromium.org

Message:

Web Inspector: Remove no-op TreeElement.prototype.didChange method
​https://bugs.webkit.org/show_bug.cgi?id=96376

Reviewed by Yury Semikhatsky.

• inspector/front-end/treeoutline.js:

(TreeElement.prototype.set title):
(TreeElement.prototype.set tooltip):
(TreeElement.prototype.set hasChildren):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/treeoutline.js (modified) (4 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-09-11  Alexander Pavlov  <apavlov@chromium.org>
+
+        Web Inspector: Remove no-op TreeElement.prototype.didChange method
+        https://bugs.webkit.org/show_bug.cgi?id=96376
+
+        Reviewed by Yury Semikhatsky.
+
+        * inspector/front-end/treeoutline.js:
+        (TreeElement.prototype.set title):
+        (TreeElement.prototype.set tooltip):
+        (TreeElement.prototype.set hasChildren):
+
 2012-09-11  Tommy Widenflycht  <tommyw@google.com>
 

trunk/Source/WebCore/inspector/front-end/treeoutline.js

@@ -624 +624 @@
         this._title = x;
         this._setListItemNodeContent();
-        this.didChange();
     },
 
@@ -635 +634 @@
         if (this._listItemNode)
             this._listItemNode.title = x ? x : "";
-        this.didChange();
     },
 
@@ -657 +655 @@
             this.collapse();
         }
-
-        this.didChange();
     },
 
@@ -692 +688 @@
         if (x && this.expanded)
             this.expand();
-    },
-
-    _fireDidChange: function()
-    {
-        delete this._didChangeTimeoutIdentifier;
-    },
-
-    didChange: function()
-    {
-        if (!this.treeOutline)
-            return;
-
-        // Prevent telling the TreeOutline multiple times in a row by delaying it with a timeout.
-        if (!this._didChangeTimeoutIdentifier)
-            this._didChangeTimeoutIdentifier = setTimeout(this._fireDidChange.bind(this), 0);
     },