Changeset 128189 in webkit


Ignore:
Timestamp:
Sep 11, 2012 8:12:28 AM (12 years ago)
Author:
commit-queue@webkit.org
Message:

[Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing
​https://bugs.webkit.org/show_bug.cgi?id=91988

Patch by Luciano Wolf <Luciano Miguel Wolf> on 2012-09-11
Reviewed by Kenneth Rohde Christiansen.

Tools:

Regular key events generated by Qt for the tab key fill both
keyCode and keyText, so we should do the same for our fake events.

  • WebKitTestRunner/qt/EventSenderProxyQt.cpp:

(WTR::EventSenderProxy::keyDown):

LayoutTests:

Unskip related tests.

  • platform/qt-5.0-wk2/Skipped:
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r128186 r128189  
     12012-09-11  Luciano Wolf  <luciano.wolf@openbossa.org>
     2
     3        [Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing
     4        https://bugs.webkit.org/show_bug.cgi?id=91988
     5
     6        Reviewed by Kenneth Rohde Christiansen.
     7
     8        Unskip related tests.
     9
     10        * platform/qt-5.0-wk2/Skipped:
     11
    1122012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
    213

  • trunk/LayoutTests/platform/qt-5.0-wk2/Skipped

    r128046 r128189  
    447447editing/selection/14971.html
    448448
    449 # [Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing
    450 # https://bugs.webkit.org/show_bug.cgi?id=91988
    451 editing/inserting/typing-tab-designmode-forms.html
    452 editing/inserting/typing-tab-designmode.html
    453 
    454449# Size of select is different when running DRT/WTR
    455450fast/replaced/three-selects-break.html

  • trunk/Tools/ChangeLog

    r128186 r128189  
     12012-09-11  Luciano Wolf  <luciano.wolf@openbossa.org>
     2
     3        [Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing
     4        https://bugs.webkit.org/show_bug.cgi?id=91988
     5
     6        Reviewed by Kenneth Rohde Christiansen.
     7
     8        Regular key events generated by Qt for the tab key fill both
     9        keyCode and keyText, so we should do the same for our fake events.
     10
     11        * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
     12        (WTR::EventSenderProxy::keyDown):
     13
    1142012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
    215

  • trunk/Tools/WebKitTestRunner/qt/EventSenderProxyQt.cpp

    r127070 r128189  
    132132            if (modifiers == Qt::ShiftModifier)
    133133                code = Qt::Key_Backtab;
    134             keyText = QString();
     134            keyText = QStringLiteral("\t");
    135135        } else if (code == KEYCODE_DEL || code == KEYCODE_BACKSPACE) {
    136136            code = Qt::Key_Backspace;
Note: See TracChangeset for help on using the changeset viewer.