Changeset 128195 in webkit

Timestamp:

Sep 11, 2012 9:42:11 AM (12 years ago)

Author:

sergio@webkit.org

Message:

[GTK] WebKitGtk+ crashes with non-UTF8 HTTP header names
​https://bugs.webkit.org/show_bug.cgi?id=96284

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Non UTF-8 characters sent as part of a HTTP header name were
causing crashes as String::fromUTF8() was returning NULL for
them. Use String::fromUTF8WithLatin1Fallback() instead.

Test: http/tests/misc/non-utf8-header-name.php

• platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::ResourceResponse::updateFromSoupMessage):

LayoutTests:

Added a new test to make sure that WebKitGtk+ does not crash when
a non-UTF8 character is sent as part of a HTTP header name.

• http/tests/misc/non-utf8-header-name-expected.txt: Added.
• http/tests/misc/non-utf8-header-name.php: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/http/tests/misc/non-utf8-header-name-expected.txt (added)
• LayoutTests/http/tests/misc/non-utf8-header-name.php (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-09-11  Sergio Villar Senin  <svillar@igalia.com>
+
+        [GTK] WebKitGtk+ crashes with non-UTF8 HTTP header names
+        https://bugs.webkit.org/show_bug.cgi?id=96284
+
+        Reviewed by Gustavo Noronha Silva.
+
+        Added a new test to make sure that WebKitGtk+ does not crash when
+        a non-UTF8 character is sent as part of a HTTP header name.
+
+        * http/tests/misc/non-utf8-header-name-expected.txt: Added.
+        * http/tests/misc/non-utf8-header-name.php: Added.
+
 2012-09-11  Csaba Osztrogonác  <ossy@webkit.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-09-11  Sergio Villar Senin  <svillar@igalia.com>
+
+        [GTK] WebKitGtk+ crashes with non-UTF8 HTTP header names
+        https://bugs.webkit.org/show_bug.cgi?id=96284
+
+        Reviewed by Gustavo Noronha Silva.
+
+        Non UTF-8 characters sent as part of a HTTP header name were
+        causing crashes as String::fromUTF8() was returning NULL for
+        them. Use String::fromUTF8WithLatin1Fallback() instead.
+
+        Test: http/tests/misc/non-utf8-header-name.php
+
+        * platform/network/soup/ResourceResponseSoup.cpp:
+        (WebCore::ResourceResponse::updateFromSoupMessage):
+
 2012-09-11  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp

@@ -70 +70 @@
     soup_message_headers_iter_init(&headersIter, soupMessage->response_headers);
     while (soup_message_headers_iter_next(&headersIter, &headerName, &headerValue))
-        m_httpHeaderFields.set(String::fromUTF8(headerName),
+        m_httpHeaderFields.set(String::fromUTF8WithLatin1Fallback(headerName, strlen(headerName)),
                                String::fromUTF8WithLatin1Fallback(headerValue, strlen(headerValue)));