Changeset 128196 in webkit

Timestamp:

Sep 11, 2012 9:44:34 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Fix FilterTypeZoom to properly call canvas->restore()
​https://bugs.webkit.org/show_bug.cgi?id=96082

Patch by Zach Kuznia <​zork@chromium.org> on 2012-09-11
Reviewed by Adrienne Walker.

Source/Platform:

Fix zoom filter to properly indicate that it affects pixels.

• chromium/src/WebFilterOperations.cpp:

(WebKit::WebFilterOperations::hasFilterThatMovesPixels):
(WebKit::WebFilterOperations::hasFilterThatAffectsOpacity):

Source/WebCore:

Fix zoom filter to properly call canvas->restore()

• platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:

(WebCore::CCRenderSurfaceFilters::apply):

Location:

trunk/Source

Files:

• Platform/ChangeLog (modified) (1 diff)
• Platform/chromium/src/WebFilterOperations.cpp (modified) (2 diffs)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp (modified) (1 diff)

trunk/Source/Platform/ChangeLog

@@ +1 @@
+2012-09-11  Zach Kuznia  <zork@chromium.org>
+
+        Fix FilterTypeZoom to properly call canvas->restore()
+        https://bugs.webkit.org/show_bug.cgi?id=96082
+
+        Reviewed by Adrienne Walker.
+
+        Fix zoom filter to properly indicate that it affects pixels.
+
+        * chromium/src/WebFilterOperations.cpp:
+        (WebKit::WebFilterOperations::hasFilterThatMovesPixels):
+        (WebKit::WebFilterOperations::hasFilterThatAffectsOpacity):
+
 2012-09-11  Tommy Widenflycht  <tommyw@google.com>
 

trunk/Source/Platform/chromium/src/WebFilterOperations.cpp

@@ -117 +117 @@
         case WebFilterOperation::FilterTypeBlur:
         case WebFilterOperation::FilterTypeDropShadow:
+        case WebFilterOperation::FilterTypeZoom:
             return true;
         default:
@@ -133 +134 @@
         case WebFilterOperation::FilterTypeBlur:
         case WebFilterOperation::FilterTypeDropShadow:
+        case WebFilterOperation::FilterTypeZoom:
             return true;
         case WebFilterOperation::FilterTypeColorMatrix: {

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-09-11  Zach Kuznia  <zork@chromium.org>
+
+        Fix FilterTypeZoom to properly call canvas->restore()
+        https://bugs.webkit.org/show_bug.cgi?id=96082
+
+        Reviewed by Adrienne Walker.
+
+        Fix zoom filter to properly call canvas->restore()
+
+        * platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:
+        (WebCore::CCRenderSurfaceFilters::apply):
+
 2012-09-11  Sergio Villar Senin  <svillar@igalia.com>
 

trunk/Source/WebCore/platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp

@@ -442 +442 @@
             canvas->saveLayer(0, &paint);
             canvas->drawBitmap(state.source(), 0, 0);
+            canvas->restore();
             break;
         }